From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYu1q-0001k0-Sg for guix-patches@gnu.org; Sat, 22 Jul 2017 09:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYu1n-0000mL-2x for guix-patches@gnu.org; Sat, 22 Jul 2017 09:01:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49331) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYu1m-0000m9-Pg for guix-patches@gnu.org; Sat, 22 Jul 2017 09:01:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dYu1m-000832-ET for guix-patches@gnu.org; Sat, 22 Jul 2017 09:01:02 -0400 Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Sat, 22 Jul 2017 15:00:32 +0200 Message-ID: <87zibw4oen.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jelle Licht , 27791@debbugs.gnu.org --=-=-= Content-Type: text/plain Hi Jelle, Jelle Licht writes: > Hello guix, > > Attached is a patch to include passmenu, a dmenu interface to the pass > password store. > > I was not quite sure how to structure this patch, as it basically installs > and wraps a shell script from the `password-store' sources. We could > instead include it as a separate output of our `password-store' package, > but I already had it like this in my GUIX_PACKAGE_PATH and I was not even > sure if that approach was in general preferable. I don't think wrapping it with dmenu in PATH is necessary. Users of this script are expected to have dmenu from before, and may want to use another implementation (e.g. rofi), another version, etc. Can you try to simply add a phase to the normal password-store package that copies this file to out/bin? We can probably avoid the wrapper too by giving it the full path to `xdotool`, e.g.: (substitute "passmenu" (("xdotool") (string-append (assoc-ref inputs "xdotool") "/bin/xdotool"))) Adding 'xdotool' adds ~8MiB to the password-store closure size, so I don't think we need a separate output either. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllzTHEACgkQoqBt8qM6 VPqCMggAlerDrLkGVmGF0/uo/4cGpAU4wn8qDuPPsYZLVsEIVzzrAIxk7j5qT+86 XiwHcLZW4siORg7P8HnhEVXjBob/7VG6eDRO82M/j3ujLtGr17QHs3Q9XHVbmo5D 6/SMYBSB+Wd7q6N+TXE0QmXt69/cyDvUAxHmi3EVIsR6c00EKv4zgSrgMxwwapfU wrtlDHAKnoHhhxf8uNfV3CFyO2E/LDIt2znd+NflfA6+9D5EEgCnUBepuP/uXN7X x8Q6vLQ1mywnHL4KbDxE/ZPecVP49hFrUsCjQ4+q3fi6VS5QYhc+Wd7yO55N05jt mmHwUH8hFEA7L0tcQ7+pWPw1f3DTVg== =MAXW -----END PGP SIGNATURE----- --=-=-=--