From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJ0wQ-0003Ua-6E for guix-patches@gnu.org; Sun, 26 Nov 2017 12:42:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJ0wM-0000Bu-9L for guix-patches@gnu.org; Sun, 26 Nov 2017 12:42:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJ0wM-0000Bp-53 for guix-patches@gnu.org; Sun, 26 Nov 2017 12:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJ0wL-0005W3-V9 for guix-patches@gnu.org; Sun, 26 Nov 2017 12:42:01 -0500 Subject: [bug#29449] [PATCH] gnu: node: Update to 8.9.1. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <877eudg6d7.fsf@gnu.org> Date: Sun, 26 Nov 2017 18:41:47 +0100 In-Reply-To: <877eudg6d7.fsf@gnu.org> (Mike Gerwitz's message of "Sat, 25 Nov 2017 20:45:40 -0500") Message-ID: <87zi79ueck.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mike Gerwitz Cc: 29449@debbugs.gnu.org Hello Mike, Mike Gerwitz skribis: > Let me know if there is a better way to accomplish removing the > `doc-only' invocation as part of the `check' target. It invokes npm and > attempts to download `js-yaml', so I figured we may as well just skip it > altogether since it isn't otherwise used. What you did LGTM. > From 918303981e0dd3212f1e0c1f1f87fc8ca608cc5e Mon Sep 17 00:00:00 2001 > From: Mike Gerwitz > Date: Sat, 25 Nov 2017 20:34:12 -0500 > Subject: [PATCH] gnu: node: Update to 8.9.1. > > * gnu/packages/node.scm (node): Update to 8.9.1. > [arguments]: Skip 'doc-only' target in 'check', which attempts to use > npm to retrieve 'js-yaml' package. Remove test/doctool/test-make-doc.js. > Do not remove now-missing test case. Remove new test case that fails in > containers due to networking. The =E2=80=98check=E2=80=99 phase fails for me (on x86_64): --8<---------------cut here---------------start------------->8--- [----------] 10 tests from InspectorSocketServerTest (88 ms total) [----------] Global test environment tear-down [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D] 62 tests from 7 test cases ran. (3863 ms t= otal) [ PASSED ] 62 tests. /gnu/store/zlbbayv8rv6z7gnhz435gjq8pzjm06v6-python-2.7.13/bin/python tools/= test.py --mode=3Drelease -J \ async-hooks \ default \ addons addons-napi \ doctool \ known_issues =3D=3D=3D release test-http2-server-rst-stream =3D=3D=3D Path: parallel/test-http2-server-rst-stream (node:12213) ExperimentalWarning: The http2 module is an experimental API. assert.js:42 throw new errors.AssertionError({ ^ AssertionError [ERR_ASSERTION]: rstWithCancel is not match rstCode at ClientHttp2Stream.req.on.common.mustCall (/tmp/guix-build-node-8.9.1= .drv-0/node-v8.9.1/test/parallel/test-http2-server-rst-stream.js:55:14) at ClientHttp2Stream. (/tmp/guix-build-node-8.9.1.drv-0/node= -v8.9.1/test/common/index.js:533:15) at emitOne (events.js:121:20) at ClientHttp2Stream.emit (events.js:211:7) at emit (internal/http2/core.js:140:8) at _combinedTickCallback (internal/process/next_tick.js:141:11) at process._tickCallback (internal/process/next_tick.js:180:9) Command: out/Release/node /tmp/guix-build-node-8.9.1.drv-0/node-v8.9.1/test= /parallel/test-http2-server-rst-stream.js [10:05|% 100|+ 2010|- 1]: Done=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 make: *** [Makefile:218: test] Error 1 phase `check' failed after 667.7 seconds --8<---------------cut here---------------end--------------->8--- Any ideas? Could it be a non-deterministic issue? Thanks, Ludo=E2=80=99.