From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ePnLb-0003GU-8w
	for guix-patches@gnu.org; Fri, 15 Dec 2017 05:36:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ePnLW-0007Ql-8L
	for guix-patches@gnu.org; Fri, 15 Dec 2017 05:36:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54254)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ePnLW-0007Qd-4h
	for guix-patches@gnu.org; Fri, 15 Dec 2017 05:36:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ePnLV-0004be-Tw
	for guix-patches@gnu.org; Fri, 15 Dec 2017 05:36:01 -0500
Subject: [bug#29409] [PATCH v2 2/4] bootloader: Factorize write-file-on-device.
Resent-Message-ID: <handler.29409.B29409.151333410317639@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <1513162937-13145-1-git-send-email-m.othacehe@gmail.com>
	<1513162937-13145-2-git-send-email-m.othacehe@gmail.com>
Date: Fri, 15 Dec 2017 11:34:56 +0100
In-Reply-To: <1513162937-13145-2-git-send-email-m.othacehe@gmail.com>
	(m. othacehe's message of "Wed, 13 Dec 2017 12:02:15 +0100")
Message-ID: <87zi6kjn3j.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: m.othacehe@gmail.com
Cc: 29409@debbugs.gnu.org

m.othacehe@gmail.com skribis:

> From: Mathieu Othacehe <m.othacehe@gmail.com>
>
> * gnu/bootloader/extlinux.scm (install-extlinux): Factorize bootloader
>   writing in a new procedure ...
> * gnu/bootloader.scm (write-file-on-device): ... defined and exported her=
e.
> ---
>  gnu/bootloader/extlinux.scm | 10 +++-------
>  gnu/build/bootloader.scm    | 37 +++++++++++++++++++++++++++++++++++++
>  gnu/local.mk                |  1 +
>  gnu/system/vm.scm           |  6 ++++--
>  guix/scripts/system.scm     |  6 ++++--
>  5 files changed, 49 insertions(+), 11 deletions(-)
>  create mode 100644 gnu/build/bootloader.scm

Please mention all the files in the commit log.

Otherwise LGTM, thanks!

Ludo=E2=80=99.