From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZfxW-0001Ns-Sp
	for guix-patches@gnu.org; Thu, 11 Jan 2018 11:44:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZfxR-00068R-TM
	for guix-patches@gnu.org; Thu, 11 Jan 2018 11:44:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:44502)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eZfxR-00068N-PN
	for guix-patches@gnu.org; Thu, 11 Jan 2018 11:44:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eZfxR-0002Rj-IM
	for guix-patches@gnu.org; Thu, 11 Jan 2018 11:44:01 -0500
Subject: [bug#29932] [PATCH 0/2] Clean up operating-system-kernel-arguments.
Resent-Message-ID: <handler.29932.B29932.15156889919333@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180101132200.26157-1-dannym@scratchpost.org>
	<878td8k8f5.fsf@gnu.org> <20180109113954.530505c0@scratchpost.org>
	<20180109195941.10076cb4@scratchpost.org>
Date: Thu, 11 Jan 2018 17:43:06 +0100
In-Reply-To: <20180109195941.10076cb4@scratchpost.org> (Danny Milosavljevic's
	message of "Tue, 9 Jan 2018 19:59:41 +0100")
Message-ID: <87zi5kpcrp.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 29932@debbugs.gnu.org

Hello,

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> +(define* (operating-system-boot-kernel-arguments os)
> +  "Kernel arguments that allow OS (only) to be booted."
> +  (let* ((root-file-system (operating-system-root-file-system os))
> +         (root-device (file-system-device root-file-system)))
> +    #~(boot-kernel-arguments #$os root-device)))

This should be:

  (boot-kernel-arguments os root-device)

That=E2=80=99s why you were getting:

> In gnu/system.scm:
>     905:2  2 (_ _)
>    939:14  1 (_ _)
> In unknown file:
>            0 (append #<gexp (boot-kernel-arguments #<gexp-input #<<?> ?)
> ERROR: In procedure append: Wrong type argument in position 1 (expecting =
empty list): #<gexp (boot-kernel-arguments #<gexp-input #<<operating-system=
> kern...

=E2=80=A6 which tells you the first argument is a gexp, whereas =E2=80=98ap=
pend=E2=80=99 expects
a list.

HTH!

Ludo=E2=80=99.