From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebj7i-0001M4-V0 for guix-patches@gnu.org; Wed, 17 Jan 2018 03:31:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebj7f-0001FY-08 for guix-patches@gnu.org; Wed, 17 Jan 2018 03:31:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51474) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebj7e-0001FE-SQ for guix-patches@gnu.org; Wed, 17 Jan 2018 03:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebj7e-0000Oy-JX for guix-patches@gnu.org; Wed, 17 Jan 2018 03:31:02 -0500 Subject: [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8. Resent-Message-ID: From: Chris Marusich References: <20171229191700.981-1-boskovits@gmail.com> Date: Wed, 17 Jan 2018 00:30:03 -0800 In-Reply-To: <20171229191700.981-1-boskovits@gmail.com> ("=?UTF-8?Q?G=C3=A1bor?= Boskovits"'s message of "Fri, 29 Dec 2017 20:17:00 +0100") Message-ID: <87zi5cga5w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?G=C3=A1bor?= Boskovits Cc: 29897@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > * gnu/packages/java.scm (java-aqute-libg)[arguments]: Add keyword make-fl= ags to use > source and target 1.7. As a matter of Git style, the first line of a commit message should not be longer than about 50 characters, and it should not span more than 1 line. Maybe we could replace the first line with the following instead? gnu: java-aqute-libg: Explicitly build for Java 7. In addition, the comment in the commit message is helpful, but it would be better to move it or copy it into the actual source code. That way, when somebody reads the source, they'll know immediately why we explicitly build for Java 7 without having to resort to searching the Git history. > + #:make-flags (list (string-append "-Dant.build.javac.source=3D" "= 1.7") > + (string-append "-Dant.build.javac.target=3D" "= 1.7")) You can also write this list in the following form, which is simpler: (list "-Dant.build.javac.source=3D1.7" "-Dant.build.javac.target=3D1.7") I'll make these changes and commit this in the next day or two, unless you have additional comments or you submit a new patch before then. =2D=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlpfCYsACgkQ3UCaFdgi Rp056w/+PwZr39SM6Az4mVSZ9oDfGP+VZBqdzBQJ/yoflvwozopfnXOeCv1UZY2a E+3IaLLp7CTrdPrT3UMHaddcODuSuR+tJ4n2NnX0nO8CaRAWxSGPFBH8U7JI+qUw XAyU332tVn2Y+6eq202PNeiXa91TpQQXt+UK8sxS/6gRenYmewRNyXVFWXoh+kD8 dGwzpMzt/0Qr8KyHi0fQXxfHGDQRvY45G7jrkfNZIWS4/NoxYAiS2ckXaRp7az+o VVkj0s/ROYl+VLew+PqTTOXtmgUriWQWCHPEWSnvAbBSKPalXrlO7LZj7uRTrPbS ZzRpsrIs1A6R+pjJf/Spfe2muTWqz1LxTUldqWlHa/2n1T2SDLxL9qT15SAdrkk0 Utn7TuUS5lw4LlNi4tqPylaw1zo/2cqvTUtNxhWvtEu0VLdk96V6XjZF+hwV8vRN yjkz0V7taVsYPEe95ASdioMsz2C49ypgj2wvN3udBhzKW9hmethVjSHwx093LlTZ TobctXUdexu8i1X9CDL4t7sgt6H+8aocjOE8lwqP3Ksg8FuGcwPD+Jaljutgncya CERQkAgGZBVQUmTur1ct7SbXz2QkbCfAoNLXrjWN8Tf0NZfP6wgIjARCO5CmDKlK UTuNGiBha/OmVE3J1Tc10YZV6kXdG0wVGdx05PXmyAGht7CePx4= =tUwK -----END PGP SIGNATURE----- --=-=-=--