unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
@ 2018-03-28 16:17 Roel Janssen
  2018-03-28 19:06 ` Marius Bakke
  0 siblings, 1 reply; 7+ messages in thread
From: Roel Janssen @ 2018-03-28 16:17 UTC (permalink / raw)
  To: 30972

[-- Attachment #1: 0001-gnu-virtuoso-ose-Unbundle-zlib-and-build-with-readli.patch --]
[-- Type: text/x-patch, Size: 1877 bytes --]

From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Wed, 28 Mar 2018 18:13:23 +0200
Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
 support.

* gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
  readline support.
---
 gnu/packages/databases.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 0622b5f37..d66fdb957 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -12,7 +12,7 @@
 ;;; Copyright © 2016 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;; Copyright © 2015, 2016, 2017, 2018 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016, 2017 Nils Gillmann <ng0@n0.is>
-;;; Copyright © 2016, 2017 Roel Janssen <roel@gnu.org>
+;;; Copyright © 2016, 2017, 2018 Roel Janssen <roel@gnu.org>
 ;;; Copyright © 2016 David Craven <david@craven.ch>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2016 Andy Patterson <ajpatter@uwaterloo.ca>
@@ -2040,10 +2040,14 @@ implementation for Python.")
         (base32 "12dqam1gc1v93l0bj0vlpvjqppki6y1hqrlznywxnw0rrz9pb002"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f)) ; Tests require a network connection.
+     `(#:tests? #f ; Tests require a network connection.
+       #:configure-flags '("--without-internal-zlib"
+                           "--with-readline")))
     (inputs
      `(("openssl" ,openssl)
-       ("net-tools" ,net-tools)))
+       ("net-tools" ,net-tools)
+       ("readline" ,readline)
+       ("zlib" ,zlib)))
     (home-page "http://vos.openlinksw.com/owiki/wiki/VOS/")
     (synopsis "Multi-model database system")
     (description "Virtuoso is a scalable cross-platform server that combines
-- 
2.16.2


[-- Attachment #2: Type: text/plain, Size: 206 bytes --]

Dear Guix,

I'd like to change the Virtuoso recipe to use readline so that we can go
to previous commands in the “isql” command-line program.  And I'd like
to unbundle zlib.

Kind regards,
Roel Janssen

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
  2018-03-28 16:17 [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline Roel Janssen
@ 2018-03-28 19:06 ` Marius Bakke
  2018-03-28 22:29   ` Roel Janssen
  0 siblings, 1 reply; 7+ messages in thread
From: Marius Bakke @ 2018-03-28 19:06 UTC (permalink / raw)
  To: Roel Janssen, 30972

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Roel Janssen <roel@gnu.org> writes:

> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Wed, 28 Mar 2018 18:13:23 +0200
> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>  support.
>
> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>   readline support.

Please mention the changes to [inputs] and [arguments] here.  Also,
assuming there is an internal copy of zlib, can you remove it with a
source 'snippet'?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
  2018-03-28 19:06 ` Marius Bakke
@ 2018-03-28 22:29   ` Roel Janssen
  2018-03-29 16:21     ` Marius Bakke
  0 siblings, 1 reply; 7+ messages in thread
From: Roel Janssen @ 2018-03-28 22:29 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 30972


Marius Bakke <mbakke@fastmail.com> writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>  support.
>>
>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>   readline support.
>
> Please mention the changes to [inputs] and [arguments] here.  Also,
> assuming there is an internal copy of zlib, can you remove it with a
> source 'snippet'?

Thanks for the quick response!

Then I'll need to rerun “autogen.sh” to make sure
“libsrc/zlib/Makefile.in” isn't included in the configure phase.  That
in turns needs the following packages added to native-inputs: autoconf,
automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.

Does that justify removing the zlib source directory?  If so, I'll send
the updated patch.  Otherwise, I'll just update the commit message.
Would this be a proper commit message:

gnu: virtuoso-ose: Unbundle zlib and build with readline support.

* gnu/packages/databases.scm (virtuoso-ose):
  [inputs]: Add zlib, and readline;
  [arguments]: Add --without-internal-zlib, and --with-readline.


Thanks for your time.

Kind regards,
Roel Janssen

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
  2018-03-28 22:29   ` Roel Janssen
@ 2018-03-29 16:21     ` Marius Bakke
  2018-03-29 22:16       ` Roel Janssen
  0 siblings, 1 reply; 7+ messages in thread
From: Marius Bakke @ 2018-03-29 16:21 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 30972

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

Roel Janssen <roel@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Roel Janssen <roel@gnu.org> writes:
>>
>>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>>> From: Roel Janssen <roel@gnu.org>
>>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>>  support.
>>>
>>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>>   readline support.
>>
>> Please mention the changes to [inputs] and [arguments] here.  Also,
>> assuming there is an internal copy of zlib, can you remove it with a
>> source 'snippet'?
>
> Thanks for the quick response!
>
> Then I'll need to rerun “autogen.sh” to make sure
> “libsrc/zlib/Makefile.in” isn't included in the configure phase.  That
> in turns needs the following packages added to native-inputs: autoconf,
> automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.

I came across a similar problem in <https://bugs.gnu.org/30974>.  Can
you see if the same solution works for you (preserve the autoconfery)?

> Does that justify removing the zlib source directory?  If so, I'll send
> the updated patch.  Otherwise, I'll just update the commit message.
> Would this be a proper commit message:
>
> gnu: virtuoso-ose: Unbundle zlib and build with readline support.
>
> * gnu/packages/databases.scm (virtuoso-ose):
>   [inputs]: Add zlib, and readline;
>   [arguments]: Add --without-internal-zlib, and --with-readline.

Looks good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
  2018-03-29 16:21     ` Marius Bakke
@ 2018-03-29 22:16       ` Roel Janssen
  2018-04-03 10:50         ` Marius Bakke
  0 siblings, 1 reply; 7+ messages in thread
From: Roel Janssen @ 2018-03-29 22:16 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 30972


Marius Bakke <mbakke@fastmail.com> writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Roel Janssen <roel@gnu.org> writes:
>>>
>>>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>>>> From: Roel Janssen <roel@gnu.org>
>>>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>>>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>>>  support.
>>>>
>>>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>>>   readline support.
>>>
>>> Please mention the changes to [inputs] and [arguments] here.  Also,
>>> assuming there is an internal copy of zlib, can you remove it with a
>>> source 'snippet'?
>>
>> Thanks for the quick response!
>>
>> Then I'll need to rerun “autogen.sh” to make sure
>> “libsrc/zlib/Makefile.in” isn't included in the configure phase.  That
>> in turns needs the following packages added to native-inputs: autoconf,
>> automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.
>
> I came across a similar problem in <https://bugs.gnu.org/30974>.  Can
> you see if the same solution works for you (preserve the autoconfery)?

I couldn't get this to work after spending two hours at it.  So I
checked whether it actually affects the build, and here's what I found:

Built with “--without-internal-zlib”:
roel@yellowstone /gnu/store/lngvklw1hniykn6skz3gghps3d08is7d-virtuoso-ose-7.2.4.2/bin$ ldd virtuoso-t 
        linux-vdso.so.1 (0x00007ffe331a0000)
        libssl.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libssl.so.1.0.0 (0x00007f2b552a7000)
        libcrypto.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libcrypto.so.1.0.0 (0x00007f2b54e50000)
        liblzma.so.5 => /gnu/store/pj8xqlnkwgjia87jy6i8slglip9k8x6a-xz-5.2.3/lib/liblzma.so.5 (0x00007f2b54c2a000)
        libpthread.so.0 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libpthread.so.0 (0x00007f2b54a0c000)
        libdl.so.2 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libdl.so.2 (0x00007f2b54808000)
        libm.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libm.so.6 (0x00007f2b544bc000)
        libz.so.1 => /gnu/store/8hxm8am4ll05sa8wlwgdq2lj4ddag464-zlib-1.2.11/lib/libz.so.1 (0x00007f2b542a1000)
        libgcc_s.so.1 => /gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libgcc_s.so.1 (0x00007f2b5408a000)
        libc.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libc.so.6 (0x00007f2b53cd8000)
        /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/ld-linux-x86-64.so.2 (0x00007f2b5551a000)

Built without “--without-internal-zlib”:
roel@yellowstone /gnu/store/nf3j0zc64flq47nlq65kvnhqzmp3lm1v-virtuoso-ose-7.2.4.2/bin$ ldd virtuoso-t 
        linux-vdso.so.1 (0x00007ffda150f000)
        libssl.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libssl.so.1.0.0 (0x00007f09d4f93000)
        libcrypto.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libcrypto.so.1.0.0 (0x00007f09d4b3c000)
        liblzma.so.5 => /gnu/store/pj8xqlnkwgjia87jy6i8slglip9k8x6a-xz-5.2.3/lib/liblzma.so.5 (0x00007f09d4916000)
        libpthread.so.0 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libpthread.so.0 (0x00007f09d46f8000)
        libdl.so.2 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libdl.so.2 (0x00007f09d44f4000)
        libm.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libm.so.6 (0x00007f09d41a8000)
        libgcc_s.so.1 => /gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libgcc_s.so.1 (0x00007f09d3f91000)
        libc.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libc.so.6 (0x00007f09d3bdf000)
        /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/ld-linux-x86-64.so.2 (0x00007f09d5206000)

So at least it does seem to affect the resulting binaries.

I also tried adding the native-inputs and run autogen.sh.  This also
failed to build when removing the “libsrc/zlib” directory.  It seems to
be tied into the build deeper than I thought at first.

What should I do now?

>
>> Does that justify removing the zlib source directory?  If so, I'll send
>> the updated patch.  Otherwise, I'll just update the commit message.
>> Would this be a proper commit message:
>>
>> gnu: virtuoso-ose: Unbundle zlib and build with readline support.
>>
>> * gnu/packages/databases.scm (virtuoso-ose):
>>   [inputs]: Add zlib, and readline;
>>   [arguments]: Add --without-internal-zlib, and --with-readline.
>
> Looks good.

Kind regards,
Roel Janssen

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
  2018-03-29 22:16       ` Roel Janssen
@ 2018-04-03 10:50         ` Marius Bakke
  2018-04-03 11:10           ` bug#30972: " Roel Janssen
  0 siblings, 1 reply; 7+ messages in thread
From: Marius Bakke @ 2018-04-03 10:50 UTC (permalink / raw)
  To: Roel Janssen; +Cc: 30972

[-- Attachment #1: Type: text/plain, Size: 4688 bytes --]

Roel Janssen <roel@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Roel Janssen <roel@gnu.org> writes:
>>
>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>
>>>> Roel Janssen <roel@gnu.org> writes:
>>>>
>>>>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>>>>> From: Roel Janssen <roel@gnu.org>
>>>>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>>>>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>>>>  support.
>>>>>
>>>>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>>>>   readline support.
>>>>
>>>> Please mention the changes to [inputs] and [arguments] here.  Also,
>>>> assuming there is an internal copy of zlib, can you remove it with a
>>>> source 'snippet'?
>>>
>>> Thanks for the quick response!
>>>
>>> Then I'll need to rerun “autogen.sh” to make sure
>>> “libsrc/zlib/Makefile.in” isn't included in the configure phase.  That
>>> in turns needs the following packages added to native-inputs: autoconf,
>>> automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.
>>
>> I came across a similar problem in <https://bugs.gnu.org/30974>.  Can
>> you see if the same solution works for you (preserve the autoconfery)?
>
> I couldn't get this to work after spending two hours at it.  So I
> checked whether it actually affects the build, and here's what I found:
>
> Built with “--without-internal-zlib”:
> roel@yellowstone /gnu/store/lngvklw1hniykn6skz3gghps3d08is7d-virtuoso-ose-7.2.4.2/bin$ ldd virtuoso-t 
>         linux-vdso.so.1 (0x00007ffe331a0000)
>         libssl.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libssl.so.1.0.0 (0x00007f2b552a7000)
>         libcrypto.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libcrypto.so.1.0.0 (0x00007f2b54e50000)
>         liblzma.so.5 => /gnu/store/pj8xqlnkwgjia87jy6i8slglip9k8x6a-xz-5.2.3/lib/liblzma.so.5 (0x00007f2b54c2a000)
>         libpthread.so.0 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libpthread.so.0 (0x00007f2b54a0c000)
>         libdl.so.2 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libdl.so.2 (0x00007f2b54808000)
>         libm.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libm.so.6 (0x00007f2b544bc000)
>         libz.so.1 => /gnu/store/8hxm8am4ll05sa8wlwgdq2lj4ddag464-zlib-1.2.11/lib/libz.so.1 (0x00007f2b542a1000)
>         libgcc_s.so.1 => /gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libgcc_s.so.1 (0x00007f2b5408a000)
>         libc.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libc.so.6 (0x00007f2b53cd8000)
>         /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/ld-linux-x86-64.so.2 (0x00007f2b5551a000)
>
> Built without “--without-internal-zlib”:
> roel@yellowstone /gnu/store/nf3j0zc64flq47nlq65kvnhqzmp3lm1v-virtuoso-ose-7.2.4.2/bin$ ldd virtuoso-t 
>         linux-vdso.so.1 (0x00007ffda150f000)
>         libssl.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libssl.so.1.0.0 (0x00007f09d4f93000)
>         libcrypto.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libcrypto.so.1.0.0 (0x00007f09d4b3c000)
>         liblzma.so.5 => /gnu/store/pj8xqlnkwgjia87jy6i8slglip9k8x6a-xz-5.2.3/lib/liblzma.so.5 (0x00007f09d4916000)
>         libpthread.so.0 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libpthread.so.0 (0x00007f09d46f8000)
>         libdl.so.2 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libdl.so.2 (0x00007f09d44f4000)
>         libm.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libm.so.6 (0x00007f09d41a8000)
>         libgcc_s.so.1 => /gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libgcc_s.so.1 (0x00007f09d3f91000)
>         libc.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libc.so.6 (0x00007f09d3bdf000)
>         /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/ld-linux-x86-64.so.2 (0x00007f09d5206000)
>
> So at least it does seem to affect the resulting binaries.
>
> I also tried adding the native-inputs and run autogen.sh.  This also
> failed to build when removing the “libsrc/zlib” directory.  It seems to
> be tied into the build deeper than I thought at first.
>
> What should I do now?

Oh well.  I guess leaving it is fine, with a TODO note somewhere.

Thanks for checking!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* bug#30972: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
  2018-04-03 10:50         ` Marius Bakke
@ 2018-04-03 11:10           ` Roel Janssen
  0 siblings, 0 replies; 7+ messages in thread
From: Roel Janssen @ 2018-04-03 11:10 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 30972-done


Marius Bakke <mbakke@fastmail.com> writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Roel Janssen <roel@gnu.org> writes:
>>>
>>>> Marius Bakke <mbakke@fastmail.com> writes:
>>>>
>>>>> Roel Janssen <roel@gnu.org> writes:
>>>>>
>>>>>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>>>>>> From: Roel Janssen <roel@gnu.org>
>>>>>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>>>>>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>>>>>  support.
>>>>>>
>>>>>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>>>>>   readline support.
>>>>>
>>>>> Please mention the changes to [inputs] and [arguments] here.  Also,
>>>>> assuming there is an internal copy of zlib, can you remove it with a
>>>>> source 'snippet'?
>>>>
>>>> Thanks for the quick response!
>>>>
>>>> Then I'll need to rerun “autogen.sh” to make sure
>>>> “libsrc/zlib/Makefile.in” isn't included in the configure phase.  That
>>>> in turns needs the following packages added to native-inputs: autoconf,
>>>> automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.
>>>
>>> I came across a similar problem in <https://bugs.gnu.org/30974>.  Can
>>> you see if the same solution works for you (preserve the autoconfery)?
>>
>> I couldn't get this to work after spending two hours at it.  So I
>> checked whether it actually affects the build, and here's what I found:
>>
>> Built with “--without-internal-zlib”:
>> roel@yellowstone /gnu/store/lngvklw1hniykn6skz3gghps3d08is7d-virtuoso-ose-7.2.4.2/bin$ ldd virtuoso-t 
>>         linux-vdso.so.1 (0x00007ffe331a0000)
>>         libssl.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libssl.so.1.0.0 (0x00007f2b552a7000)
>>         libcrypto.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libcrypto.so.1.0.0 (0x00007f2b54e50000)
>>         liblzma.so.5 => /gnu/store/pj8xqlnkwgjia87jy6i8slglip9k8x6a-xz-5.2.3/lib/liblzma.so.5 (0x00007f2b54c2a000)
>>         libpthread.so.0 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libpthread.so.0 (0x00007f2b54a0c000)
>>         libdl.so.2 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libdl.so.2 (0x00007f2b54808000)
>>         libm.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libm.so.6 (0x00007f2b544bc000)
>>         libz.so.1 => /gnu/store/8hxm8am4ll05sa8wlwgdq2lj4ddag464-zlib-1.2.11/lib/libz.so.1 (0x00007f2b542a1000)
>>         libgcc_s.so.1 => /gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libgcc_s.so.1 (0x00007f2b5408a000)
>>         libc.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libc.so.6 (0x00007f2b53cd8000)
>>         /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/ld-linux-x86-64.so.2 (0x00007f2b5551a000)
>>
>> Built without “--without-internal-zlib”:
>> roel@yellowstone /gnu/store/nf3j0zc64flq47nlq65kvnhqzmp3lm1v-virtuoso-ose-7.2.4.2/bin$ ldd virtuoso-t 
>>         linux-vdso.so.1 (0x00007ffda150f000)
>>         libssl.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libssl.so.1.0.0 (0x00007f09d4f93000)
>>         libcrypto.so.1.0.0 => /gnu/store/ggrpw6gh2rnqjwyjf99z8cdw5digc4hb-openssl-1.0.2o/lib/libcrypto.so.1.0.0 (0x00007f09d4b3c000)
>>         liblzma.so.5 => /gnu/store/pj8xqlnkwgjia87jy6i8slglip9k8x6a-xz-5.2.3/lib/liblzma.so.5 (0x00007f09d4916000)
>>         libpthread.so.0 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libpthread.so.0 (0x00007f09d46f8000)
>>         libdl.so.2 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libdl.so.2 (0x00007f09d44f4000)
>>         libm.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libm.so.6 (0x00007f09d41a8000)
>>         libgcc_s.so.1 => /gnu/store/2ifmksc425qcysl5rkxkbv6yrgc1w9cs-gcc-5.5.0-lib/lib/libgcc_s.so.1 (0x00007f09d3f91000)
>>         libc.so.6 => /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/libc.so.6 (0x00007f09d3bdf000)
>>         /gnu/store/4sqaib7c2dfjv62ivrg9b8wa7bh226la-glibc-2.26.105-g0890d5379c/lib/ld-linux-x86-64.so.2 (0x00007f09d5206000)
>>
>> So at least it does seem to affect the resulting binaries.
>>
>> I also tried adding the native-inputs and run autogen.sh.  This also
>> failed to build when removing the “libsrc/zlib” directory.  It seems to
>> be tied into the build deeper than I thought at first.
>>
>> What should I do now?
>
> Oh well.  I guess leaving it is fine, with a TODO note somewhere.
>
> Thanks for checking!

Thanks for your reply!

I added the TODO note, and pushed in 6d09a7b5e.

Kind regards,
Roel Janssen

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-04-03 11:12 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-28 16:17 [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline Roel Janssen
2018-03-28 19:06 ` Marius Bakke
2018-03-28 22:29   ` Roel Janssen
2018-03-29 16:21     ` Marius Bakke
2018-03-29 22:16       ` Roel Janssen
2018-04-03 10:50         ` Marius Bakke
2018-04-03 11:10           ` bug#30972: " Roel Janssen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).