From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKWYd-0003wI-Ny for guix-patches@gnu.org; Sun, 20 May 2018 18:12:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKWYc-0001Xj-RM for guix-patches@gnu.org; Sun, 20 May 2018 18:12:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKWYc-0001Xa-NW for guix-patches@gnu.org; Sun, 20 May 2018 18:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKWYc-0002XQ-Gi for guix-patches@gnu.org; Sun, 20 May 2018 18:12:02 -0400 Subject: [bug#31447] [PATCH] linux-libre: Add aarch64-linux. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87bmdivr91.fsf@aikidev.net> <87lgci4q90.fsf@gnu.org> <87d0xu5dgu.fsf@netris.org> <87vabmsztc.fsf@aikidev.net> <87lgcgtx2z.fsf@aikidev.net> <871se7te3f.fsf@aikidev.net> Date: Mon, 21 May 2018 00:11:38 +0200 In-Reply-To: <871se7te3f.fsf@aikidev.net> (Vagrant Cascadian's message of "Sat, 19 May 2018 16:33:56 -0700") Message-ID: <87zi0u565h.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vagrant Cascadian Cc: 31447@debbugs.gnu.org, Mark H Weaver Heya, Vagrant Cascadian skribis: > On 2018-05-18, Vagrant Cascadian wrote: >> On 2018-05-17, Vagrant Cascadian wrote: >>> Since submitting, I did notice that the way .dtb files are installed, it >>> doesn't preserve the subdirectory structure. Unlike the "arm" >>> architecture, where .dtb files are all placed in a single directory, on >>> "arm64" there are sub-directories for each soc family: >>> >>> allwinner/sun50i-a64-pine64-plus.dtb >>> >>> It looks like the linux Makefile supports setting INSTALL_DTBS_PATH >>> variable, and both "arm" and "arm64" architectures have a "dtbs_install" >>> target, which may simply do "the right thing". > > Attached is a patch which does that. Did test builds of linux-libre on > x86_64-linux (no dtb files), aarch64-linux (dtb files in subdirs) and > armhf-linux (dtb files in one big huge directory); all of these variants > appear to be doing the right thing. > > The patch basically follows the previous behavior by checking for the > presence of .dtb files, but rather than installing them manually, > invokes "make dtbs_install". > > I did try to restrict dtb installation based on architecture (only arm, > arm64 and mips linux architectures currently implement the dtbs_install > Makefile target), which would seem a little cleaner to me. My attempt > was essentially: > > (if (string=3D? (getenv "ARCH") (or "arm" "arm64" "mips")) > (invoke "make" "dtbs_install" ... ) > ) You could do: (when (member (getenv "ARCH") '("arm" "arm64" "mips")) =E2=80=A6) But I think what you did is even nicer (no need to hardwire the list of architectures.) > From 4e5ea2e07282b3c3125fc1922e729085a2e2706f Mon Sep 17 00:00:00 2001 > From: Vagrant Cascadian > Date: Sat, 19 May 2018 21:08:41 +0000 > Subject: [PATCH 2/2] gnu: linux-libre: Use "make dtbs_install" to install > device tree files. > > * gnu/packages/linux.scm (make-linux-libre): > Use "make dtbs_install" to install device tree files. I adjusted the indentation and committed. Thank you! Ludo=E2=80=99.