From: ludo@gnu.org (Ludovic Courtès)
To: Vagrant Cascadian <vagrant@debian.org>
Cc: 31447@debbugs.gnu.org, Mark H Weaver <mhw@netris.org>
Subject: [bug#31447] [PATCH] linux-libre: Add aarch64-linux.
Date: Mon, 21 May 2018 00:11:38 +0200 [thread overview]
Message-ID: <87zi0u565h.fsf@gnu.org> (raw)
In-Reply-To: <871se7te3f.fsf@aikidev.net> (Vagrant Cascadian's message of "Sat, 19 May 2018 16:33:56 -0700")
Heya,
Vagrant Cascadian <vagrant@debian.org> skribis:
> On 2018-05-18, Vagrant Cascadian wrote:
>> On 2018-05-17, Vagrant Cascadian wrote:
>>> Since submitting, I did notice that the way .dtb files are installed, it
>>> doesn't preserve the subdirectory structure. Unlike the "arm"
>>> architecture, where .dtb files are all placed in a single directory, on
>>> "arm64" there are sub-directories for each soc family:
>>>
>>> allwinner/sun50i-a64-pine64-plus.dtb
>>>
>>> It looks like the linux Makefile supports setting INSTALL_DTBS_PATH
>>> variable, and both "arm" and "arm64" architectures have a "dtbs_install"
>>> target, which may simply do "the right thing".
>
> Attached is a patch which does that. Did test builds of linux-libre on
> x86_64-linux (no dtb files), aarch64-linux (dtb files in subdirs) and
> armhf-linux (dtb files in one big huge directory); all of these variants
> appear to be doing the right thing.
>
> The patch basically follows the previous behavior by checking for the
> presence of .dtb files, but rather than installing them manually,
> invokes "make dtbs_install".
>
> I did try to restrict dtb installation based on architecture (only arm,
> arm64 and mips linux architectures currently implement the dtbs_install
> Makefile target), which would seem a little cleaner to me. My attempt
> was essentially:
>
> (if (string=? (getenv "ARCH") (or "arm" "arm64" "mips"))
> (invoke "make" "dtbs_install" ... )
> )
You could do:
(when (member (getenv "ARCH") '("arm" "arm64" "mips"))
…)
But I think what you did is even nicer (no need to hardwire the list of
architectures.)
> From 4e5ea2e07282b3c3125fc1922e729085a2e2706f Mon Sep 17 00:00:00 2001
> From: Vagrant Cascadian <vagrant@debian.org>
> Date: Sat, 19 May 2018 21:08:41 +0000
> Subject: [PATCH 2/2] gnu: linux-libre: Use "make dtbs_install" to install
> device tree files.
>
> * gnu/packages/linux.scm (make-linux-libre):
> Use "make dtbs_install" to install device tree files.
I adjusted the indentation and committed. Thank you!
Ludo’.
next prev parent reply other threads:[~2018-05-20 22:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 3:40 [bug#31447] [PATCH] linux-libre: Add aarch64-linux Vagrant Cascadian
2018-05-17 8:53 ` Ludovic Courtès
2018-05-17 18:44 ` Mark H Weaver
2018-05-17 22:05 ` Vagrant Cascadian
2018-05-18 4:38 ` Mark H Weaver
2018-05-18 22:31 ` Vagrant Cascadian
2018-05-19 23:33 ` Vagrant Cascadian
2018-05-20 22:11 ` Ludovic Courtès [this message]
2018-05-20 22:26 ` Vagrant Cascadian
2018-05-20 22:12 ` bug#31447: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi0u565h.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31447@debbugs.gnu.org \
--cc=mhw@netris.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).