From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN1xI-0001mv-Fs for guix-patches@gnu.org; Wed, 14 Nov 2018 15:40:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN1xC-0003Wn-Q5 for guix-patches@gnu.org; Wed, 14 Nov 2018 15:40:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gN1xC-0003WW-Mu for guix-patches@gnu.org; Wed, 14 Nov 2018 15:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gN1xC-00046K-JA for guix-patches@gnu.org; Wed, 14 Nov 2018 15:40:02 -0500 Subject: bug#33059: [PATCH v2 0/9] Add the FEniCS Project, v2 patches Resent-To: guix-patches@gnu.org Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87k1m7vvjp.fsf@gnu.org> <1542038441-5738-1-git-send-email-pgarlick@tourbillion-technology.com> Date: Wed, 14 Nov 2018 21:38:48 +0100 In-Reply-To: <1542038441-5738-1-git-send-email-pgarlick@tourbillion-technology.com> (Paul Garlick's message of "Mon, 12 Nov 2018 16:00:32 +0000") Message-ID: <87zhubcs2v.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Paul Garlick Cc: 33059-done@debbugs.gnu.org Hello Paul and all, Paul Garlick skribis: > Hi Efraim, Hi Eric, Hi Ludo, > > Thank you for your comments on the patch series for the FEniCS Project > packages. I have been able to make changes to address all of the > suggestions with one exception, noted below. > > The main differences between the original and v2 patches are: > > i) python-mpi4py is now part of (gnu packages mpi) > ii) python-petsc4py is now part of (gnu packages maths) > iii) python-slepc4py is now part of (gnu packages maths) > iv) temporary directory changes use 'with-directory-excursion' > v) 'substitute*' is used in preference to 'with-atomic-file-replacement' > vi) the Guix 'catch' package is used in preference to the bundled version > vii) the 'python-fenics-dolfin' package has been renamed 'fenics' > viii) the 'fenics' package has an updated home-page and synopsis > > The remaining suggestion was in the 'fenics-dolfin' package: > >> + (string-append >> + "set(CTEST_CUSTOM_TESTS_IGNORE " >> + "demo_bcs_serial " >> + "demo_bcs_mpi " >> + "demo_eigenvalue_serial " >> + "demo_eigenvalue_mpi " >> + "demo_navier-stokes_serial " > >> Could we avoid listing all the files here? > > I tried a few ideas to avoid listing the demos to ignore. These are the = ones > with the 'git-lfs' links. However, this proved to be awkward. > > The source code lists the demos that cmake expects to be present. So, one > may either make a list of demos to ignore (as in the original patch) or d= elete > the same members from a list to include (plus delete the subdirectories > themselves). Simply deleting the subdirectories from the build directory= does > not work. Since they exist as Makefile targets they are re-created by the > 'make demos' step. > > I think the original method is preferable. An advantage is that users may > readily access the demos if they are using Guix on a host system that has > a git-lfs package available. Thanks a lot for taking the time to address the comments we made on this patch series. I=E2=80=99ve applied the whole series on =E2=80=98master=E2= =80=99; everything lints and builds for me on x86_64-linux (there are new versions of the PETSc and SLEPSc bindings available, BTW.) Thank you! Ludo=E2=80=99.