From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gcDB3-0000WU-B8
	for guix-patches@gnu.org; Wed, 26 Dec 2018 12:41:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gcDB0-0003qh-50
	for guix-patches@gnu.org; Wed, 26 Dec 2018 12:41:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42103)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gcDB0-0003qd-1h
	for guix-patches@gnu.org; Wed, 26 Dec 2018 12:41:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gcDAz-0005Rl-Uz
	for guix-patches@gnu.org; Wed, 26 Dec 2018 12:41:01 -0500
Subject: [bug#33875] [PATCH] `guix lint' warn of GitHub autogenerated source
	tarballs
Resent-Message-ID: <handler.33875.B33875.154584602620884@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20181226084712.GQ2581@macbook41>
Date: Wed, 26 Dec 2018 18:40:22 +0100
In-Reply-To: <20181226084712.GQ2581@macbook41> (Efraim Flashner's message of
	"Wed, 26 Dec 2018 10:47:13 +0200")
Message-ID: <87zhssb309.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 33875@debbugs.gnu.org

Hello!

Efraim Flashner <efraim@flashner.co.il> skribis:

> From dcd8b207f932289cb3b35720af45f49f849b7c27 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <efraim@flashner.co.il>
> Date: Tue, 25 Dec 2018 16:29:12 +0200
> Subject: [PATCH] lint: Add checker for unstable tarballs.
>
> * guix/scripts/lint.scm (check-source-unstable-tarball): New procedure.
> (%checkers): Add it.
> * tests/lint.scm ("source-unstable-tarball", "source-unstable-tarball:
> source #f", "source-unstable-tarball: valid", "source-unstable-tarball:
> package named archive", "source-unstable-tarball: not-github",
> "source-unstable-tarball: git-fetch"): New tests.

Could you mention =E2=80=98source-unstable-tarball=E2=80=99 in doc/guix.tex=
i?

Otherwise LGTM!

Please double-check that =E2=80=9Cmake check TESTS=3Dtests/lint.scm=E2=80=
=9D passes and
that =E2=80=98./pre-inst-env guix lint -c source-unstable-tarball=E2=80=99 =
works.

Thanks!

Ludo=E2=80=99.