From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:47171)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMtB6-0002IB-Ux
	for guix-patches@gnu.org; Sat, 04 May 2019 07:50:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMtB5-0008ND-Pt
	for guix-patches@gnu.org; Sat, 04 May 2019 07:50:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:36932)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hMtB4-0008M9-Lh
	for guix-patches@gnu.org; Sat, 04 May 2019 07:50:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hMtB4-0007A6-A2
	for guix-patches@gnu.org; Sat, 04 May 2019 07:50:02 -0400
Subject: [bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.
Resent-Message-ID: <handler.35545.B35545.155697055727459@debbugs.gnu.org>
References: <20190503145820.606f37db@sybil.lepiller.eu>
	<20190503130134.24788-1-julien@lepiller.eu>
	<20190503130134.24788-7-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190503130134.24788-7-julien@lepiller.eu>
Date: Sat, 04 May 2019 13:48:57 +0200
Message-ID: <87zho2fniu.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35545@debbugs.gnu.org


Julien Lepiller <julien@lepiller.eu> writes:

> * gnu/packages/java.scm (java-openjfx-build): New variable.
[=E2=80=A6]
> +    ;; This is a java-8 version
> +    (version "8.202")

What does this imply?  Are there more recent versions?

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://hg.openjdk.java.net/openjfx/8u=
-dev/rt"
> +                                  "/archive/85d09981ae0d.tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

I think it may be better to use hg-fetch here as this doesn=E2=80=99t look =
like
a stable tarball.

> +    (description "OpenJFX is a free, next generation client application
> +platform for desktop, mobile and embedded systems built on Java.  Its go=
al
> +is to produce a modern, efficient, and fully featured toolkit for develo=
ping
> +rich client applications.  This package contains base classes for the
> +OpenJFX distribution and helper classes for building other parts of the
> +distribution.")

I agree with what Nicolas wrote.

> +    (license license:gpl2)));with classpath exception

GPL2 only?  Please add a space before =E2=80=9C;=E2=80=9D.

--=20
Ricardo