From: Marius Bakke <mbakke@fastmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: 36535@debbugs.gnu.org
Subject: [bug#36535] [PATCH] gnu: gobject-introspection: Update absolute-shlib-path.patch.
Date: Fri, 12 Jul 2019 20:44:08 +0200 [thread overview]
Message-ID: <87zhljks93.fsf@devup.no> (raw)
In-Reply-To: <87zhlopjzv.fsf@devup.no>
severity 36535 important
>>>> ++def _get_default_fallback_libpath():
>>>> ++ # Newer multiple-output-optimized stdenv has an environment variable
>>>> ++ # $outputLib which in turn specifies another variable which then is used as
>>>> ++ # the destination for the library contents (${!outputLib}/lib).
>>>> ++ store_path = os.environ.get(os.environ.get("outputLib")) if "outputLib" in os.environ else None
>>>> ++ if store_path is None:
>>>> ++ outputs = os.environ.get("outputs", "out").split()
>>>
>>> gnu-build-system does not currently export an "outputs" variable.
>>> Perhaps it should?
>>
>> Ah, I didn't realise this part of the patch was as Nix specific as it
>> is...
>>
>> At least for the change I was trying to affect, this seems to be
>> probably redundant, or somehow doing the job. Maybe this part of the
>> patch relating to the fallback_libpath should be removed.
>
> I'd keep the "$outputs" logic, it sounds like a useful and easy change
> to do in gnu-build-system, although maybe not for this 'core-updates'
> round. We can use it in package recipes for fun and profit meanwhile.
We now have a user of the $outputs variable:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=7555d539245ff3456848c02d61f9e601ee5af463
Incidentally, the package was broken because of the very same feature :-)
But we can not merge this with the hard-coded /gnu/store paths, as that
is likely to cause strange problems for users with a non-default store
prefix.
Unless someone steps up to fix it within a few days, I think we'll have
to revert it for now.
next prev parent reply other threads:[~2019-07-12 18:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 10:48 [bug#36535] [PATCH] gnu: gobject-introspection: Update absolute-shlib-path.patch Christopher Baines
2019-07-08 7:46 ` bug#36535: " Christopher Baines
2019-07-08 14:21 ` [bug#36535] " Marius Bakke
2019-07-08 15:59 ` Christopher Baines
2019-07-08 16:29 ` Marius Bakke
2019-07-10 17:35 ` Marius Bakke
2019-07-12 18:44 ` Marius Bakke [this message]
2019-07-12 23:22 ` Christopher Baines
2019-07-13 11:09 ` [bug#36535] [PATCH] gnu: gobject-introspection: Remove hardcoded store from patch Christopher Baines
2019-07-13 11:11 ` [bug#36535] [PATCH] gnu: gobject-introspection: Update absolute-shlib-path.patch Christopher Baines
2019-07-13 16:46 ` Marius Bakke
2019-07-13 22:14 ` bug#36535: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhljks93.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=36535@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).