From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:57961) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnQdT-00067v-NV for guix-patches@gnu.org; Tue, 16 Jul 2019 12:49:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnQdS-0006Hv-OV for guix-patches@gnu.org; Tue, 16 Jul 2019 12:49:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hnQdS-0006Ho-La for guix-patches@gnu.org; Tue, 16 Jul 2019 12:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hnQdS-0006Qa-HN for guix-patches@gnu.org; Tue, 16 Jul 2019 12:49:02 -0400 Subject: [bug#36638] [PATCH 1/2] gnu: Add websocketpp. Resent-Message-ID: From: zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) References: <87o91xbz4p.fsf@sdf.lonestar.org> <87k1clbz2i.fsf@sdf.lonestar.org> <8736j7l155.fsf@gnu.org> <87r26rjm3q.fsf@gnu.org> Date: Tue, 16 Jul 2019 12:48:50 -0400 In-Reply-To: <87r26rjm3q.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 15 Jul 2019 18:31:21 +0200") Message-ID: <87zhleylfx.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 36638@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > We should at least remove everything under src/ as well as the > top-level =E2=80=98LICENSE=E2=80=99 file. > > As for the .a files, we should either not install them at all, or > install .so files instead. > > Could you take a look? I'll sit down and take a closer look when I get the chance. It seems to be a funny build system setup; the libi2pd header files are installed to 'src/', and given the CMake flags I'm using, we /should/ be getting .so files instead of .a files. > All of bin/ should be removed I think, because these look like unit > tests, no? Good catch! I need to start looking at the output directories for the packages I write :p I wouldn't have expected 'make install' to install the unit tests as well > Also, there=E2=80=99s no .so or .a file, but that=E2=80=99s because it=E2= =80=99s a header-only > library, right? Yes. Regards, Jakob --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEa1VJLOiXAjQ2BGSm9Qb9Fp2P2VoFAl0t//IACgkQ9Qb9Fp2P 2VoCbhAAoEkMGgypGnkh8Hfk+yy8Ghwj7CEc7sjWRQoLazThJjwrGFy4cwWXMSVa g/tCT0zVsMhmfLJ7HI+NNHwxLe5fz0Xv6EVcwamrslgK+Wn4ELO58lqHykP1KEQc uTiEcMvzperCrN/SnA/HqHHRm5EDvnLQsM3U6W//vkx6Si55Tkr/d+n3zMKYa8SN w6NysBA3+s6Cd6hM8QEZnw8pK3ITACCM4v6rr20P99fyg27bdi4WCQ6UcMz8srK6 6S24ei9JYSRsJ3TXAzQFjjzlndU3U9NSfL1CUTZtZ/JWSQEk66Azqflu6ogKUvgw 7ScUnHKJXQuNRAIm+a+AokvIBSbF/r7WKAcL+VloAFoHXzMbVdTTZI7bp9SbxI0e 7K1OtI26UvUCDmwauFTojqQZpkn7R+QcUiKH2W5+cKoaebSr16kptMo8RlRvClnc aChVJWTbI0WZD+wouyBKTRm8tK0/3fHdl0TDJUatkQktuih6wrHk0CM2zGoova37 07anqzTMXiEqlizN7brcUGXUKBQG/F+NayDqnt0apjfrkQb6xgCQrKx90HBFhEf7 BGjV6CvF4RZubxQ5U5hxGdFPWgiNnMh3Fon1qW8N75UCGFe7VzVZKOkGcG/e9WsM U5x/i6TYNsSnuotK+3IkS2LSTKB3bSJZwHHVwCBOLjVd2L16OjI= =3LnY -----END PGP SIGNATURE----- --=-=-=--