From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44384)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyEt1-0000aS-I8
 for guix-patches@gnu.org; Sun, 02 Feb 2020 08:02:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyEt0-0006Vj-IM
 for guix-patches@gnu.org; Sun, 02 Feb 2020 08:02:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:33605)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iyEt0-0006VM-Eg
 for guix-patches@gnu.org; Sun, 02 Feb 2020 08:02:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyEt0-0000T1-Bt
 for guix-patches@gnu.org; Sun, 02 Feb 2020 08:02:02 -0500
Subject: [bug#39367] [PATCH] gnu: Add anki.
Resent-Message-ID: <handler.39367.B39367.15806485171781@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20200131120112.4532-1-robertsmith@posteo.net>
Date: Sun, 02 Feb 2020 14:01:43 +0100
In-Reply-To: <20200131120112.4532-1-robertsmith@posteo.net> (Robert Smith's
 message of "Fri, 31 Jan 2020 13:01:12 +0100")
Message-ID: <87zhe1b0so.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Smith <robertsmith@posteo.net>
Cc: 39367@debbugs.gnu.org

Hello,

Robert Smith <robertsmith@posteo.net> writes:

> * gnu/packages/education.scm (anki): New variable.

Thank you! Some comments follow.

> +     '(#:make-flags (list (string-append "PREFIX=" %output))

OOC, isn't it automatic in gnu-build-system?

> +    (inputs
> +     `(("python" ,python-wrapper)
> +       ("qtwebengine" ,qtwebengine)
> +       ("mpv" ,mpv)
> +       ("lame" ,lame)))
> +    (propagated-inputs
> +     `(("python-pyqtwebengine" ,python-pyqtwebengine)
> +       ("python-pyqt" ,python-pyqt)
> +       ("python-beautifulsoup4" ,python-beautifulsoup4)
> +       ("python-decorator" ,python-decorator)
> +       ("python-distro" ,python-distro)
> +       ("python-markdown" ,python-markdown)
> +       ("python-jsonschema" ,python-jsonschema)
> +       ("python-pyaudio" ,python-pyaudio)
> +       ("python-requests" ,python-requests)
> +       ("python-send2trash" ,python-send2trash)
> +       ("python-sip" ,python-sip)))

Please order inputs and propagated-inputs alphabetically.

The package builds fine, but when trying to run "anki", I get the
following error:

  ModuleNotFoundError: No module named 'decorator'

It looks like you also need to wrap PYTHONPATH around the executable. WDYT?

Regards,

-- 
Nicolas Goaziou