From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:59095)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jH6ai-0006B3-5C
 for guix-patches@gnu.org; Wed, 25 Mar 2020 10:01:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jH6ac-0001Re-8T
 for guix-patches@gnu.org; Wed, 25 Mar 2020 10:01:08 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:51599)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jH6ac-0001RE-59
 for guix-patches@gnu.org; Wed, 25 Mar 2020 10:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jH6ac-0003B4-38
 for guix-patches@gnu.org; Wed, 25 Mar 2020 10:01:02 -0400
Subject: [bug#40221] Submission of GUI Package Description for 7kaa
Resent-Message-ID: <handler.40221.B40221.158514481612151@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <9b3a381f-3177-b8b2-5924-f8c05137c67b@riseup.net>
Date: Wed, 25 Mar 2020 15:00:01 +0100
In-Reply-To: <9b3a381f-3177-b8b2-5924-f8c05137c67b@riseup.net> (Naga
 Malleswari's message of "Wed, 25 Mar 2020 19:03:34 +0530")
Message-ID: <87zhc4h6vy.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Naga Malleswari <nagamalli@riseup.net>
Cc: Danny Milosavljevic <dannym@scratchpost.org>, =?UTF-8?Q?G=C3=A1bor?= Boskovits <boskovits@gmail.com>, 40221@debbugs.gnu.org

Hello,

Naga Malleswari <nagamalli@riseup.net> writes:

> Hence i added to games.scm(assuming thats the actual location. Please
> correct me) and done with the patch.

Thank you!

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/the3dfxdude/7kaa/archive/v"
> +                           version ".tar.gz"))

This URL is not stable. Home page provides a stable release at:

  https://github.com/the3dfxdude/7kaa/releases/download/v2.15.3/7kaa-2.15.3.tar.xz

I suggest to use this one, replacing 2.5.13 with `version', like you did. 

> +       (sha256
> +        (base32 "0bf90v1bm4zazwalfl9vd5dfbdcxwhi02rmggn5xc0yq0zkxwlqv"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("automake" ,automake)
> +       ("autoconf" ,autoconf)
> +       ("pkg-config" ,pkg-config)))

Could you re-order inputs alphabetically?

> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("enet" ,enet)
> +       ("openal" ,openal)
> +       ("gettext" ,gettext-minimal)
> +       ("curl" ,curl)))

Ditto.

> +    (home-page "https://7kfans.com/")
> +    (synopsis "Seven Kingdoms Ancient Adversaries: real-time strategy game")
> +    (description
> +     "Seven Kingdoms, designed by Trevor Chan, brings a unique blend of
> +Real-Time Strategy with the addition of trade, diplomacy, and espionage.

We try to avoid adding "marketing" words or idioms in descriptions, like
"unique blend". I think "blend" is enough.

> +7kfans project is updating the game and
> +provides a community for fans.  A free Seven Kingdoms will help continue
> +the legacy.")

I suggest to drop this part, which is not informative in the
description. Besides, everything is Free in Guix.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou