unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
@ 2020-03-24  2:18 Michael Rohleder
  2020-03-24 10:47 ` Mathieu Othacehe
  2020-03-26 21:40 ` bug#40204: " Marius Bakke
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Rohleder @ 2020-03-24  2:18 UTC (permalink / raw)
  To: 40204


[-- Attachment #1.1: Type: text/plain, Size: 51 bytes --]

* gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

[-- Attachment #1.2: [PATCH] * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3 --]
[-- Type: text/x-patch, Size: 1486 bytes --]

From 2976e6de897232296d1e16a3a799cd3ab20ea1db Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Tue, 24 Mar 2020 03:13:33 +0100
Subject: [PATCH] * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

---
 gnu/packages/xorg.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index f4c7329e06..cde699bb51 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2019 Yoshinori Arai <kumagusu08@gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2020 Florian Pelz <pelzflorian@pelzflorian.de>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3825,7 +3826,7 @@ alternative implementations like XRandR or TwinView.")
 (define xkbcomp-intermediate ; used as input for xkeyboard-config
   (package
     (name "xkbcomp-intermediate")
-    (version "1.4.2")
+    (version "1.4.3")
     (source
       (origin
         (method url-fetch)
@@ -3835,7 +3836,7 @@ alternative implementations like XRandR or TwinView.")
                ".tar.bz2"))
         (sha256
          (base32
-          "0944rrkkf0dxp07vhh9yr4prslxhqyw63qmbjirbv1bypswvrn3d"))))
+          "0dflr250nlj6rrnv658f6dm8qx37sj0xfimc3ihay761kwb2q906"))))
     (build-system gnu-build-system)
     (inputs
       `(("xorgproto" ,xorgproto)
-- 
2.26.0


[-- Attachment #1.3: Type: text/plain, Size: 109 bytes --]


-- 
GNU Emacs is a LISP operating system disguised as a word processor.
    --Doug Mohney, in comp.arch

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
  2020-03-24  2:18 [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3 Michael Rohleder
@ 2020-03-24 10:47 ` Mathieu Othacehe
  2020-03-24 19:43   ` Leo Famulari
  2020-03-26 21:04   ` Michael Rohleder
  2020-03-26 21:40 ` bug#40204: " Marius Bakke
  1 sibling, 2 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2020-03-24 10:47 UTC (permalink / raw)
  To: 40204


Hello Michael,

While your patch LGTM, running:

--8<---------------cut here---------------start------------->8---
guix refresh -l xkbcomp
--8<---------------cut here---------------end--------------->8---

you'll see that it triggers too much rebuilds to be pushed on
master. Could you rebase it on core-updates and see if it works?

Thanks,

Mathieu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
  2020-03-24 10:47 ` Mathieu Othacehe
@ 2020-03-24 19:43   ` Leo Famulari
  2020-03-26 21:04   ` Michael Rohleder
  1 sibling, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2020-03-24 19:43 UTC (permalink / raw)
  To: Mathieu Othacehe; +Cc: 40204

On Tue, Mar 24, 2020 at 11:47:34AM +0100, Mathieu Othacehe wrote:
> you'll see that it triggers too much rebuilds to be pushed on
> master. Could you rebase it on core-updates and see if it works?

To clarify, the guidelines about how many rebuilds are okay for which
branch are in item 8 of the manual section Submitting Patches [0]:

------
300 dependent packages or less

    master branch (non-disruptive changes).
between 300 and 1,200 dependent packages

    staging branch (non-disruptive changes). This branch is intended to be merged in master every 3 weeks or so. Topical changes (e.g., an update of the GNOME stack) can instead go to a specific branch (say, gnome-updates).
more than 1,200 dependent packages

    core-updates branch (may include major and potentially disruptive changes). This branch is intended to be merged in master every 2.5 months or so. 
------

These are rough heuristics that help us manage big changes effectively.

[0]
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3
  2020-03-24 10:47 ` Mathieu Othacehe
  2020-03-24 19:43   ` Leo Famulari
@ 2020-03-26 21:04   ` Michael Rohleder
  1 sibling, 0 replies; 5+ messages in thread
From: Michael Rohleder @ 2020-03-26 21:04 UTC (permalink / raw)
  To: 40204


[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]

here is the update against core-updates.

I tested building only some of the dependencies and it seems to work in
a "./pre-inst-env guix environment --pure bash --ad-hoc xkbcomp" on
branch core-updates.


[-- Attachment #1.2: * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3 --]
[-- Type: text/x-patch, Size: 1484 bytes --]

From 11cc3b00ed62608a8a56edab4d1306d3a5e5b477 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Thu, 26 Mar 2020 21:23:43 +0100
Subject: [PATCH] * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

---
 gnu/packages/xorg.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 2ec151fd01..5db27fbff0 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2019 Yoshinori Arai <kumagusu08@gmail.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>
+;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3746,7 +3747,7 @@ alternative implementations like XRandR or TwinView.")
 (define xkbcomp-intermediate ; used as input for xkeyboard-config
   (package
     (name "xkbcomp-intermediate")
-    (version "1.4.2")
+    (version "1.4.3")
     (source
       (origin
         (method url-fetch)
@@ -3756,7 +3757,7 @@ alternative implementations like XRandR or TwinView.")
                ".tar.bz2"))
         (sha256
          (base32
-          "0944rrkkf0dxp07vhh9yr4prslxhqyw63qmbjirbv1bypswvrn3d"))))
+          "0dflr250nlj6rrnv658f6dm8qx37sj0xfimc3ihay761kwb2q906"))))
     (build-system gnu-build-system)
     (inputs
       `(("xorgproto" ,xorgproto)
-- 
2.26.0


[-- Attachment #1.3: Type: text/plain, Size: 50 bytes --]


-- 
win-nt from the people who invented edlin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* bug#40204: [PATCH] gnu: xkbcomp: update to 1.4.3
  2020-03-24  2:18 [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3 Michael Rohleder
  2020-03-24 10:47 ` Mathieu Othacehe
@ 2020-03-26 21:40 ` Marius Bakke
  1 sibling, 0 replies; 5+ messages in thread
From: Marius Bakke @ 2020-03-26 21:40 UTC (permalink / raw)
  To: Michael Rohleder, 40204-done

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Michael Rohleder <mike@rohleder.de> writes:

> * gnu/packages/xorg.scm (xkbcomp): update to 1.4.3

Thanks!  Pushed to the 'core-updates' branch as
b12acffbd03c025b1e849f7a93d5edd47682a8ce.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-26 21:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-24  2:18 [bug#40204] [PATCH] gnu: xkbcomp: update to 1.4.3 Michael Rohleder
2020-03-24 10:47 ` Mathieu Othacehe
2020-03-24 19:43   ` Leo Famulari
2020-03-26 21:04   ` Michael Rohleder
2020-03-26 21:40 ` bug#40204: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).