From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QEyaLrOmul5MPQAA0tVLHw (envelope-from ) for ; Tue, 12 May 2020 13:37:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KGKHB8Kmul64fQAA1q6Kng (envelope-from ) for ; Tue, 12 May 2020 13:38:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5A78C94104E for ; Tue, 12 May 2020 13:38:07 +0000 (UTC) Received: from localhost ([::1]:56018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYV6l-0002Ht-0v for larch@yhetil.org; Tue, 12 May 2020 09:38:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYV6g-0002FE-S0 for guix-patches@gnu.org; Tue, 12 May 2020 09:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43059) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYV6g-0000XZ-J0 for guix-patches@gnu.org; Tue, 12 May 2020 09:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYV6g-0001vs-GO for guix-patches@gnu.org; Tue, 12 May 2020 09:38:02 -0400 Subject: bug#41167: V2 Re: [bug#41167] [PATCH 5/5] gnu: Add julia-compat. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 12 May 2020 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41167 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti Cc: 41167-done@debbugs.gnu.org, nixo Mail-Followup-To: 41167@debbugs.gnu.org, ludo@gnu.org, anothersms@gmail.com Received: via spool by 41167-done@debbugs.gnu.org id=D41167.15892906227337 (code D ref 41167); Tue, 12 May 2020 13:38:02 +0000 Received: (at 41167-done) by debbugs.gnu.org; 12 May 2020 13:37:02 +0000 Received: from localhost ([127.0.0.1]:54604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYV5i-0001uB-21 for submit@debbugs.gnu.org; Tue, 12 May 2020 09:37:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYV5g-0001ts-Fa for 41167-done@debbugs.gnu.org; Tue, 12 May 2020 09:37:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40887) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYV5a-0000M9-JH; Tue, 12 May 2020 09:36:54 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41996 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jYV5Z-0006wf-UN; Tue, 12 May 2020 09:36:54 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200510081513.26015-1-nicolo@nixo.xyz> <20200510081513.26015-5-nicolo@nixo.xyz> <87zhaedw9n.fsf@gnu.org> <87imh25g80.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> Date: Tue, 12 May 2020 15:36:51 +0200 In-Reply-To: <87imh25g80.fsf@guixSD.i-did-not-set--mail-host-address--so-tickle-me> ("=?UTF-8?Q?Nicol=C3=B2?= Balzarotti"'s message of "Mon, 11 May 2020 23:11:59 +0200") Message-ID: <87zhad9swc.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.54001031050291]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.06), country: US(-0.00), ip: 209.51.188.17(-0.54)]; DWL_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[209.51.188.17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.51.188.17:from]; RCVD_COUNT_SEVEN(0.00)[9]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: cnSJ8Zg2RzZn Hi Nicol=C3=B2, Nicol=C3=B2 Balzarotti skribis: >> Hello! >> >> nixo skribis: >> >>> * julia-xyz.scm: New file. >>> * local.mk: Add julia-xyz.scm to it. >>> * julia-xyz.scm (julia-compat): New variable. >> >> Please spell out file names; you can also remove the last line, not >> needed here since it=E2=80=99s a new file. >> >>> --- /dev/null >>> +++ b/gnu/packages/julia-xyz.scm >>> @@ -0,0 +1,27 @@ >>> +(define-module (gnu packages julia-xyz) >> >> Could you add the license/copyright header and resend this one? >> >> I=E2=80=99ll see if I can apply the whole series and build it tomorrow. >> > Prepare for a long build time! Running tests takes like 4 hours. Ouch, indeed. It went fine though! I pushed the whole series. Note that I modified the patch-adjusting patch to preserve the comment that was originally there. Nitpick: for future patches, I recommend avoiding =E2=80=9CFix =E2=80=A6=E2= =80=9D in the subject line, unless (1) there=E2=80=99s a bug report and the commit log links to i= t, or (2) the commit log explains what=E2=80=99s being fixed. (It wasn=E2=80=99t= clear to me whether the first two patches were =E2=80=9Cfixing=E2=80=9D something that = didn=E2=80=99t work at all, and to what extent.) Anyway, thumbs up for the upgrade! \o/ Thanks, Ludo=E2=80=99.