From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mHXyGKTi4F4HZQAA0tVLHw (envelope-from ) for ; Wed, 10 Jun 2020 13:39:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eOPBFKTi4F72dwAAbx9fmQ (envelope-from ) for ; Wed, 10 Jun 2020 13:39:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 045E0940997 for ; Wed, 10 Jun 2020 13:39:48 +0000 (UTC) Received: from localhost ([::1]:36058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0xG-00077p-RE for larch@yhetil.org; Wed, 10 Jun 2020 09:39:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj0g6-00089B-BR for guix-patches@gnu.org; Wed, 10 Jun 2020 09:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj0g6-0006h2-13 for guix-patches@gnu.org; Wed, 10 Jun 2020 09:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj0g5-00064K-Th for guix-patches@gnu.org; Wed, 10 Jun 2020 09:22:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41767] [PATCH 9/9] DROP? channels: Add prehistorical authorizations to . Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jun 2020 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41767 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 41767@debbugs.gnu.org Received: via spool by 41767-submit@debbugs.gnu.org id=B41767.159179529823294 (code B ref 41767); Wed, 10 Jun 2020 13:22:01 +0000 Received: (at 41767) by debbugs.gnu.org; 10 Jun 2020 13:21:38 +0000 Received: from localhost ([127.0.0.1]:33562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj0fi-00063e-AY for submit@debbugs.gnu.org; Wed, 10 Jun 2020 09:21:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj0fg-00063S-Vn for 41767@debbugs.gnu.org; Wed, 10 Jun 2020 09:21:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40314) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj0fb-0006bp-LH; Wed, 10 Jun 2020 09:21:31 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36858 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jj0fb-00038c-8n; Wed, 10 Jun 2020 09:21:31 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200608220256.3267-1-ludo@gnu.org> <20200608220256.3267-9-ludo@gnu.org> <87o8pshysy.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 23 Prairial an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 10 Jun 2020 15:21:30 +0200 In-Reply-To: <87o8pshysy.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 09 Jun 2020 14:35:57 -0400") Message-ID: <87zh9bdpk5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: krUQxUxblAOZ Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> This allows users to authenticate commits that were made before >> '.guix-authorizations' was introduced. >> >> * guix/channels.scm ()[prehistorical-authorization= s]: >> New field. >> (%guix-historical-committers): New variable. >> (openpgp-fingerprint->bytevector): New procedure. >> (%guix-channel-introduction): Add 'prehistorical-authorizations' field. >> (authenticate-channel): Honor it. Pass it as #:default-authorizations >> to 'authenticate-commits'. >> * build-aux/git-authenticate.scm (%historical-committers) >> (%historical-authorized-signing-keys, commit-short-id): Remove. >> * build-aux/git-authenticate.scm (git-authenticate): Rewrite to use >> 'authenticate-channel'. >> * tests/channels.scm ("authenticate-channel, wrong first commit signer") >> ("authenticate-channel, .guix-authorizations"): Adjust accordingly. > > I'd be in favor of dropping this commit, to not be burdened by legacy > complexity, which I'm doubtful would see much use anyway. This means > that a channel require all its commits to have a .guix-authorizations > file to be authenticated. I think that's fine. Yeah, makes sense to me. > The series LGTM. I haven't tested it locally, but the tests give me > confidence. Cool. I=E2=80=99ll reply to your other comments soonish. Anyhow, I=E2=80=99ll leave a few more days for people to weigh in before go= ing further. Thanks for reviewing! Ludo=E2=80=99.