unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#41875] [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.
@ 2020-06-15 16:23 Brice Waegeneire
  2020-06-21  3:36 ` bug#41875: " 宋文武
  2020-06-22 21:14 ` [bug#41875] " Marius Bakke
  0 siblings, 2 replies; 3+ messages in thread
From: Brice Waegeneire @ 2020-06-15 16:23 UTC (permalink / raw)
  To: 41875

* gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.
---

Without it 'newgrp' is unusable:

--8<---------------cut here---------------start------------->8---
$ whoami
bricewge
$ cat /etc/group | grep wireshark
wireshark:x:970:bricewge
$ groups
users libvirt adbusers plugdev kvm lp netdev audio video input dialout wheel
$ newgrp wireshark
setgroups: Operation not permitted
setgid: Operation not permitted
--8<---------------cut here---------------end--------------->8---

I also added 'sg' since, in the shadow package, it's a symlink to 'newgrp'.

 gnu/system.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/system.scm b/gnu/system.scm
index 06bbc9e9c8..3e3d1927c2 100644
--- a/gnu/system.scm
+++ b/gnu/system.scm
@@ -932,7 +932,9 @@ use 'plain-file' instead~%")
   ;; Default set of setuid-root programs.
   (let ((shadow (@ (gnu packages admin) shadow)))
     (list (file-append shadow "/bin/passwd")
+          (file-append shadow "/bin/sg")
           (file-append shadow "/bin/su")
+          (file-append shadow "/bin/newgrp")
           (file-append shadow "/bin/newuidmap")
           (file-append shadow "/bin/newgidmap")
           (file-append inetutils "/bin/ping")
-- 
2.26.2





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#41875: [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.
  2020-06-15 16:23 [bug#41875] [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS Brice Waegeneire
@ 2020-06-21  3:36 ` 宋文武
  2020-06-22 21:14 ` [bug#41875] " Marius Bakke
  1 sibling, 0 replies; 3+ messages in thread
From: 宋文武 @ 2020-06-21  3:36 UTC (permalink / raw)
  To: Brice Waegeneire; +Cc: 41875-done

Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.

Pushed, thank you!




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#41875] [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS.
  2020-06-15 16:23 [bug#41875] [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS Brice Waegeneire
  2020-06-21  3:36 ` bug#41875: " 宋文武
@ 2020-06-22 21:14 ` Marius Bakke
  1 sibling, 0 replies; 3+ messages in thread
From: Marius Bakke @ 2020-06-22 21:14 UTC (permalink / raw)
  To: Brice Waegeneire, 41875

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Brice Waegeneire <brice@waegenei.re> writes:

> * gnu/system.scm (%setuid-programs): Add 'sg' and 'newgrp'.

LGTM.  Now I can remove this bit from my system config:

(setuid-programs (append (list #~(string-append #$shadow "/bin/newgrp"))
                         %setuid-programs)))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-22 21:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-15 16:23 [bug#41875] [PATCH] system: Add 'sg' and 'newgrp' to %SETUID-PROGRAMS Brice Waegeneire
2020-06-21  3:36 ` bug#41875: " 宋文武
2020-06-22 21:14 ` [bug#41875] " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).