unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 42000@debbugs.gnu.org
Subject: [bug#42000] [PATCH] gnu: Add drip.
Date: Tue, 23 Jun 2020 16:38:54 +0200	[thread overview]
Message-ID: <87zh8t6e4h.fsf@ambrevar.xyz> (raw)
In-Reply-To: <20200623125149.GG22974@E5400>

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Efraim Flashner <efraim@flashner.co.il> writes:

> Don't forget to return #t and make sure the lines aren't too long.

`guix lint' does not complain :)

>> +                  (lambda (file)
>> +                    (install-file (string-append "bin/" file) bin))
>> +                  '("drip" "drip_daemon" "drip_proxy"))
>> +                 (install-file "drip.jar" out)))))))
>
> Is drip.jar supposed to be at the root of %output?

The `drip' script looks at "..".  Alternatively, I could patch the
script.  I think I'll do that.

> I have nothing to test it with but it looks good with those few changes.

Thanks for you review!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-06-23 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22  9:31 [bug#42000] [PATCH] gnu: Add drip Pierre Neidhardt
2020-06-23 12:51 ` Efraim Flashner
2020-06-23 14:38   ` Pierre Neidhardt [this message]
2020-06-26  9:27     ` Pierre Neidhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zh8t6e4h.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=42000@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).