From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mIPkE6zTVV8rIgAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 06:31:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qObyD6zTVV+hbAAAbx9fmQ (envelope-from ) for ; Mon, 07 Sep 2020 06:31:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C3AF29401D0 for ; Mon, 7 Sep 2020 06:31:07 +0000 (UTC) Received: from localhost ([::1]:59122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFAgE-0006VJ-Mx for larch@yhetil.org; Mon, 07 Sep 2020 02:31:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFAgA-0006V7-B1 for guix-patches@gnu.org; Mon, 07 Sep 2020 02:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36129) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFAgA-0003kf-2R for guix-patches@gnu.org; Mon, 07 Sep 2020 02:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFAg9-0001n6-Va for guix-patches@gnu.org; Mon, 07 Sep 2020 02:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43183] [PATCH v2 3/5] gnu: Add guile-struct-pack. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 06:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43183 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze Cc: 43183@debbugs.gnu.org Received: via spool by 43183-submit@debbugs.gnu.org id=B43183.15994602386854 (code B ref 43183); Mon, 07 Sep 2020 06:31:01 +0000 Received: (at 43183) by debbugs.gnu.org; 7 Sep 2020 06:30:38 +0000 Received: from localhost ([127.0.0.1]:47675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFAfm-0001mU-DJ for submit@debbugs.gnu.org; Mon, 07 Sep 2020 02:30:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFAfk-0001mG-TU for 43183@debbugs.gnu.org; Mon, 07 Sep 2020 02:30:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36225) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFAfe-0003c2-JC; Mon, 07 Sep 2020 02:30:31 -0400 Received: from [2a01:e0a:19b:d9a0:9d9d:97cc:d92a:8ac0] (port=49144 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kFAfS-0006xd-Dk; Mon, 07 Sep 2020 02:30:24 -0400 From: Mathieu Othacehe References: <20200903150243.27796-1-mjbecze@riseup.net> <20200904202517.6131-1-mjbecze@riseup.net> <20200904202517.6131-4-mjbecze@riseup.net> Date: Mon, 07 Sep 2020 08:30:16 +0200 In-Reply-To: <20200904202517.6131-4-mjbecze@riseup.net> (Martin Becze's message of "Fri, 4 Sep 2020 15:25:15 -0500") Message-ID: <87zh62m747.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 9h0w7nJiATSx Hey Martin, Thanks for the v2! > + (define (mv dst) I'm not sure it's useful to define a procedure here, as it will only be called once. > + (define (target file) > + (string-append dst "/" file)) > + (define files (cddr (scandir "."))) We try to avoid car, cdr & friends. You can use: --8<---------------cut here---------------start------------->8--- (scandir dir (negate (cut member <> '("." "..")))) --8<---------------cut here---------------end--------------->8--- instead. > + (description > + "This is an R6RS library for working with packed byte structures. It is > +similar to struct in Python or pack and unpack in Perl.") > + (license license:expat))) Make sure to use the correct indentation, using Emacs or indent-code.el script. Also, the order of the patchset is not correct. The patch adding "loko-scheme" should be the last one, as it depends on the other ones, and won't build without them. Could you send an updated version :) ? Thanks, Mathieu