From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eO2/Gx1/wl+/QwAA0tVLHw (envelope-from ) for ; Sat, 28 Nov 2020 16:47:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YKeQFx1/wl/rQAAA1q6Kng (envelope-from ) for ; Sat, 28 Nov 2020 16:47:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A53FF9404C4 for ; Sat, 28 Nov 2020 16:47:24 +0000 (UTC) Received: from localhost ([::1]:53694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kj3Nb-0001lV-Fx for larch@yhetil.org; Sat, 28 Nov 2020 11:47:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj3NG-0001lK-97 for guix-patches@gnu.org; Sat, 28 Nov 2020 11:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj3NG-00017K-0s for guix-patches@gnu.org; Sat, 28 Nov 2020 11:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kj3NF-0003vz-T2 for guix-patches@gnu.org; Sat, 28 Nov 2020 11:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44789] gnu: Add lemonbar-xft. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Nov 2020 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44789 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: elaexuotee@wilsonb.com Cc: 44789@debbugs.gnu.org Received: via spool by 44789-submit@debbugs.gnu.org id=B44789.160658198215075 (code B ref 44789); Sat, 28 Nov 2020 16:47:01 +0000 Received: (at 44789) by debbugs.gnu.org; 28 Nov 2020 16:46:22 +0000 Received: from localhost ([127.0.0.1]:48946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj3MY-0003v1-An for submit@debbugs.gnu.org; Sat, 28 Nov 2020 11:46:21 -0500 Received: from mira.cbaines.net ([212.71.252.8]:33442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj3MV-0003ur-Bq for 44789@debbugs.gnu.org; Sat, 28 Nov 2020 11:46:17 -0500 Received: from localhost (188.28.112.52.threembb.co.uk [188.28.112.52]) by mira.cbaines.net (Postfix) with ESMTPSA id 704DD27BBF8; Sat, 28 Nov 2020 16:46:14 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id d1cbe478; Sat, 28 Nov 2020 16:46:12 +0000 (UTC) References: <2ZE4C0OKC3A7H.2HN5A6QF4EP7L@wilsonb.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <2ZE4C0OKC3A7H.2HN5A6QF4EP7L@wilsonb.com> Date: Sat, 28 Nov 2020 16:46:09 +0000 Message-ID: <87zh31sa3y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.37 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: lOgHbbTawzOL --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable elaexuotee--- via Guix-patches via writes: > This adds a fork of the `lemonbar' package that supports fontconfig. I don't know anything about lemonbar, but this sounds OK in principle. gnu/packages/wm.scm(lemonbar-xft): New variable. =2D-- gnu/packages/wm.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm index 361cecf26f..7d9b591545 100644 =2D-- a/gnu/packages/wm.scm +++ b/gnu/packages/wm.scm @@ -37,6 +37,7 @@=20 ;;; Copyright =C2=A9 2020 Marcin Karpezo ;;; Copyright =C2=A9 2020 EuAndreh ;;; Copyright =C2=A9 2020 Michael Rohleder +;;; Copyright =C2=A9 2020 B. Wilson ;;; ;;; This file is part of GNU Guix. ;;; @@ -1931,6 +1932,40 @@ formatting, RandR and Xinerama support and EWMH com= pliance without wasting your precious memory.") (license license:x11)))) =20 +(define-public lemonbar-xft + ;; Upstream v2.0 tag is several years behind HEAD + (let ((commit "481e12363e2a0fe0ddd2176a8e003392be90ed02")) + (package + (inherit lemonbar) + (name "lemonbar-xft") + (version (string-append "2.0." (string-take commit 7))) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/drscream/lemonbar-xft") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0588g37h18lv50h7w8vfbwhvc3iajh7sdr53848spaif99nh3mh4"))= )) + (inputs `(("freetype" ,freetype) + ("libxft" ,libxft) + ("libx11" ,libx11) + ,@(package-inputs lemonbar))) + (arguments + `(#:tests? #f ;no test suite + #:make-flags + (list + (string-append "CC=3D" ,(cc-for-target)) + (string-append "PREFIX=3D" %output) + (string-append "CFLAGS=3D" + (string-join + (list (string-append "-I" (assoc-ref %build-inpu= ts "freetype") + "/include/freetype2") + (string-append "-D" "VERSION=3D" + (format #f "'~s'" ,version)= ))))) + #:phases (modify-phases %standard-phases (delete 'configure))))))) So, it would be nice to change the description (and maybe synopsis) to set out how this package is different from lemonbar. Also, regarding the arguments above, I think you can reduce the duplication with the lemonbar package by doing something like: (arguments (substitute-keyword-arguments (package-arguments lemonbar) ((#:make-flags make-flags) (append make-flags (string-append "CFLAGS=3D" (string-join (list (string-append "-I" (assoc-ref %build-inputs "freetyp= e") "/include/freetype2") (string-append "-D" "VERSION=3D" (format #f "'~s'" ,version))))))))) I've only just written this in this email, so I'm not sure if it works, but I think it's close. Would you be able to send an updated patch? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl/CftFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcNwQ//cOD2+2i/6VjF6EFCmn6wxluCMx4+uqvW dHCf1nrJChv58esPLuO4gAJn+vZFdLYZuPkaNcFcwfYVB4OzXoJIyD1W6n3OrFDq oOj64yliEY0GxCNJhvqeROnKDu86gyQ3Uq0BcymrOSjXjnVM3TE7iArGWxiJ8Cgm 5MntizVIHaU2EkOmtQoLP72cdzZkYpPNLEjYOKPwRYwvmOvlZgTPEk7R0LgEMSvR AhOYlb5oXK2rDLeEKGxL92pkNf+Q4fcrgPmpp3REqLoxGDBRVS7+XKFMMn++zbe9 BHWcyiKCm0adFQ7YU/cImywUSVDJgcEJn8xOgCOaz5GOpL4A7vAsXRVHHu0/g96R M2SA8Brygz3Sm7mgC0iakYmrKZee2OyqaOKETqt772Ot4mvycCrx246uV6ewq5oj uXWYYWM2imOuSiJ4jZJ6RfZhxuO01/5G6YgaoaI7GBRi6DUgDxkiUPSWaO2sbzl4 j/NTCn6nNYFSY5x4XXk7zZJ1Yvd+KlNYcMYp8txnIlcmgpKgdJgyTc1zAXYoIzPl KIib3Z1vvWyHUcI8SoS2Vbm3agN68wIN290d2mrIn1oze08qPK3C93+gtBBNyg5m 16ICNLBaDVtKYOKu5nVRFhORNPmUKCV6t0B2ROQgbMnsaxH1A/bweBFepjB9dUYg STMGiwmL+CI= =NzkV -----END PGP SIGNATURE----- --=-=-=--