From: Carlo Zancanaro <carlo@zancanaro.id.au>
To: Christopher Baines <mail@cbaines.net>
Cc: 38769@debbugs.gnu.org
Subject: [bug#38769] [PATCH] import: Add importer for MELPA packages.
Date: Fri, 18 Dec 2020 22:16:13 +1100 [thread overview]
Message-ID: <87zh2b2wle.fsf@zancanaro.id.au> (raw)
In-Reply-To: <87a6ub2ymu.fsf@cbaines.net>
Hi Chris!
On Fri, Dec 18 2020, Christopher Baines wrote:
> Looking at the code, elpa-package->sexp is a little awkward, the
> code would probably be clearer if the (or ...) bits in the
> package sexp were moved out in to functions that deal with
> generating that part of the package.
I agree with you. The "quasiquote, unquote, quasiquote, unquote"
is a bit awkward, but I don't think it's unreasonable. I'm not
that interested in revising the patch right now, but feel free to
extract that logic before merging if you think it's necessary.
> It seems to work though, so I'm happy to push this. Is this
> patch still relevant?
Yep, as far as I know this is still relevant.
Carlo
next prev parent reply other threads:[~2020-12-18 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 1:59 [bug#38769] [PATCH] import: Add importer for MELPA packages Carlo Zancanaro
2020-01-07 19:39 ` Brett Gilio
2020-03-18 2:54 ` Carlo Zancanaro
2020-05-30 14:26 ` Carlo Zancanaro
2020-07-25 1:49 ` Brett Gilio
2020-12-18 10:32 ` Christopher Baines
2020-12-18 11:16 ` Carlo Zancanaro [this message]
2020-12-18 12:40 ` bug#38769: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh2b2wle.fsf@zancanaro.id.au \
--to=carlo@zancanaro.id.au \
--cc=38769@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).