From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id fsddIAa131+FSAAA0tVLHw (envelope-from ) for ; Sun, 20 Dec 2020 20:33:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cOjHGwa1318sZgAA1q6Kng (envelope-from ) for ; Sun, 20 Dec 2020 20:33:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 14D489402A2 for ; Sun, 20 Dec 2020 20:33:10 +0000 (UTC) Received: from localhost ([::1]:43124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr5O8-0005wY-Ss for larch@yhetil.org; Sun, 20 Dec 2020 15:33:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr5O2-0005wB-Pi for guix-patches@gnu.org; Sun, 20 Dec 2020 15:33:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kr5O2-0006sa-Id for guix-patches@gnu.org; Sun, 20 Dec 2020 15:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kr5O2-0004BG-GJ for guix-patches@gnu.org; Sun, 20 Dec 2020 15:33:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le. Resent-From: Chris Marusich Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Dec 2020 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45252 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dftxbs3e Received: via spool by 45252-submit@debbugs.gnu.org id=B45252.160849637616057 (code B ref 45252); Sun, 20 Dec 2020 20:33:02 +0000 Received: (at 45252) by debbugs.gnu.org; 20 Dec 2020 20:32:56 +0000 Received: from localhost ([127.0.0.1]:45691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5Nw-0004Au-G3 for submit@debbugs.gnu.org; Sun, 20 Dec 2020 15:32:56 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:44515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kr5Nu-0004Ah-3e for 45252@debbugs.gnu.org; Sun, 20 Dec 2020 15:32:54 -0500 Received: by mail-pl1-f176.google.com with SMTP id r4so4522903pls.11 for <45252@debbugs.gnu.org>; Sun, 20 Dec 2020 12:32:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lf++sMBuFSBJVsoYahU5KITS7QjeZbDK857tlRO4gxI=; b=uqN7YHrdFtfYAvFMHZhAWFapXUiZxGxBec3p9SToLfK5elv645wsVcI/IkxCDhI9ye SbEEXmhDyiuReACDAYKGIUmnnjI9MIMsD3qBXriZd2gTRFI5oKN6c6s/JL2TSKQRV5mF SjzDnuSFjnR+BHgKFEwOR7ibkA6Sx5rutKu+XmVBOyKUYNEdkPEOHwDZXRc1ywrH6o/2 CpX0788XCDpcoH5OdqjkAYP49TAP3+lk2O9SdVf94JmoMxEhsYBaSgXOfUzrbp4eC9AT 5uHvyna/lmuip8rL7ng3kyvDDfEw0tM4VzmO3CU5YhPR9qGzHWShJpQwtq7pJJUrJB4Y lbHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lf++sMBuFSBJVsoYahU5KITS7QjeZbDK857tlRO4gxI=; b=p1SQiZF+8kdoAVWiFN9CdIMfzVHWFqV5sNHXAw8OY6OXsKpoz5bfKy74Q6Ez0awp2t fT/e+xLCpY2YF15hFYicFlwyMdISijf7/OEGw9RLg9/Bkbr1cFWoq5l90/E+WXQPrn+C PWKankgpLrMrQ5mAG7Bzqurd/nUVnHclwY9ctZ1E1YVDLMs5NWjQYsW7Yg4h5JkeL6zZ lgn1vgGEXlscxwdRFLoksZTU6PTji3iJCeJRTzsmZr54zCj+oOk8zeXuln0Hyn/9n+aO aOx9gWRFACZaff+hUCs5cFYnDylXR7IP2ibbJ8ilperXbFbDAGHGF5WbeOBE7KumCsuR AHcQ== X-Gm-Message-State: AOAM530a5+nbIXjSgg0nDKzOmk0Ts9g3J+WlY2+/Q184i5SO52L0a9lb C9JFA5qxPdSorjjI6BWY5XgfqkEDOBRMUQ== X-Google-Smtp-Source: ABdhPJwx3eGWHnoWoJmAilTatB/UPBVFzRGlf/9XhPDgYMNEfDFNCosTVeAs+9HtNNDv0siAAP+vnw== X-Received: by 2002:a17:90b:1886:: with SMTP id mn6mr14178120pjb.31.1608496367495; Sun, 20 Dec 2020 12:32:47 -0800 (PST) Received: from garuda-lan ([2601:601:9d00:688::c9a]) by smtp.gmail.com with ESMTPSA id fs12sm13335310pjb.49.2020.12.20.12.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Dec 2020 12:32:46 -0800 (PST) From: Chris Marusich References: <8fc771beb3f0f1e2886a238e0ef9087908c98fc1.camel@free.fr> Date: Sun, 20 Dec 2020 12:32:42 -0800 In-Reply-To: <8fc771beb3f0f1e2886a238e0ef9087908c98fc1.camel@free.fr> (dftxbs3e@free.fr's message of "Tue, 15 Dec 2020 10:32:42 +0100") Message-ID: <87zh289q1h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45252@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -0.82 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=uqN7YHrd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 14D489402A2 X-Spam-Score: -0.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZbbROpgHPuIk --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, dftxbs3e writes: > Based on previous discussions to apply < > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44778> on the master > branch instead I submit this new patch (attached) so that it does not > cause a world rebuild by not altering the package definition hash on > other platforms. My understanding is as follows: =2D Patch 44778, linked above, was committed on core-updates branch in 4fff5ab24126a152b50c036b9bf8dc6f2740f094. =2D The libffi patch in this patch (45252) is the same as it was in 44778, but the scheme code has been changed so that we can apply this patch to the master branch without causing a rebuild of many packages. Is that right? > + '()) > + ,@(if (string-prefix? "powerpc64le-" (or (%current-target-system) > + (%current-system))) > + '(#:phases (modify-phases %standard-phases > + (add-after 'unpack 'apply-patch2 > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((patch (assoc-ref inputs > + "powerpc64le-patch= "))) > + (invoke "patch" "--batch" "-p1" > + "-i" patch)))))) > '()))) > (inputs > - (if (string-prefix? "powerpc-" (or (%current-target-system) > + (cond > + ((string-prefix? "powerpc-" (or (%current-target-system) > (%current-system))) > - `(("powerpc-patch" ,@(search-patches > - "libffi-3.3-powerpc-fixes.patch"))) > - '())) > + `(("powerpc-patch" ,@(search-patches > + "libffi-3.3-powerpc-fixes.patch")))) > + ((string-prefix? "powerpc64le-" (or (%current-target-system) > + (%current-system))) > + `(("powerpc64le-patch" ,@(search-patches > + "libffi-float128-powerpc64le.patch")))) > + (else '()))) Looks good to me. I'll test it locally and update here once I've confirmed that it doesn't cause a full rebuild when applied to master. Assuming all goes well, I intend to revert 4fff5ab24126a152b50c036b9bf8dc6f2740f094 on core-updates and apply this patch to master. > +++ b/gnu/packages/patches/libffi-float128-powerpc64le.patch Based on... https://patchwork.ozlabs.org/project/buildroot/patch/20191124090305.1015485= -1-fontaine.fabrice@gmail.com/ ...it sounds like upstream libffi maintainers may not have merged this patch yet. We should probably check with them to see when they plan to merge it into upstream, but in the meantime there's no reason not to use the patch if it works. Based on what Fabrice said in that thread, it sounds like the libffi maintainers may be a bit slow in responding to power-related bugs. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl/ftOsACgkQ3UCaFdgi Rp2WxxAAg2V8isAwAIRoASg5C6Gu3d2P/isgegSNDosAt1OBIpiW6lVNvjfG1HY0 U6M7A142y7K4Gsc+68xnjWJ4kdepws7xQVX8S7Ae6Zba5KXma287gacrd9fLr8GS 2xd26wUxLjkz6vcjnaPsxjA38dTrxXjuc1Xi2icnlbkotLO4RyaBa9S2UW/na0Qa txDrEXIz0U+dKm4kFI09cETKIX6bciyO15V/DslFaEdEe3cWGefVCp86bCzRpYqV piyfxftADaX/IZ9ysG2LdcJ6bfyhpD/71tx6Fpgm73Rq+ldwv6DsCFQrKsT7JBOg 6+L8ujO/3ccTMKDUuQ48S/aDdft+7it/LU6qhcZk5Q4JdY9GZhrEeC/JA12RM/mP pbrFcCC+255IB4L3tNWlKQoUYLxtam8YLVzSX2DZ45T+eaicEKeuZlqIYXFxFEMw 3TULzBhSk5dNv9FjdBc1MUrfhGeQmO9z1t9J9STh8vO/g7ZuxhQFGFemYbRLpDMv DOLDKnVEeYl7P6aKujkKpsQvx3uIcSI6Plf3Jg+5o+Vaeliu6s0EXaNGFoXlmduY +HyOEsNo4i2d8cohjEM4jp2eCr5wK/BHDyCO9seX0dcm9Rnm4A5V9wAtY1phb0TO 3Q524lkPXUBGrJia0lf2tX7O2nCepklCQ4v5X6qLi5cB3y+xU1c= =TQRQ -----END PGP SIGNATURE----- --=-=-=--