From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yEOOFYoAJGD8HwAA0tVLHw (envelope-from ) for ; Wed, 10 Feb 2021 15:49:30 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0Dh3EYoAJGAVDgAAB5/wlQ (envelope-from ) for ; Wed, 10 Feb 2021 15:49:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DEAE940276 for ; Wed, 10 Feb 2021 15:49:29 +0000 (UTC) Received: from localhost ([::1]:44086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9rk8-00088b-E8 for larch@yhetil.org; Wed, 10 Feb 2021 10:49:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9rgo-0006HN-OU for guix-patches@gnu.org; Wed, 10 Feb 2021 10:46:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9rgn-00073V-M6 for guix-patches@gnu.org; Wed, 10 Feb 2021 10:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9rgn-0005fQ-JP for guix-patches@gnu.org; Wed, 10 Feb 2021 10:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45692] [PATCH 0/4] Even Better ZFS Support on Guix Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Feb 2021 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: raid5atemyhomework Cc: Danny Milosavljevic , "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> Received: via spool by 45692-submit@debbugs.gnu.org id=B45692.161297190221691 (code B ref 45692); Wed, 10 Feb 2021 15:46:01 +0000 Received: (at 45692) by debbugs.gnu.org; 10 Feb 2021 15:45:02 +0000 Received: from localhost ([127.0.0.1]:56937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9rfp-0005db-U3 for submit@debbugs.gnu.org; Wed, 10 Feb 2021 10:45:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9rfm-0005d4-Cz for 45692@debbugs.gnu.org; Wed, 10 Feb 2021 10:45:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45623) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9rff-0006Xc-DM; Wed, 10 Feb 2021 10:44:51 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43354 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l9rfe-0000YD-SJ; Wed, 10 Feb 2021 10:44:51 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <2yOs7mxigs8_Vx_yi858pxAkoyXmU8IidizK5grcmX4M92O5QK-_Ywo9nrHMHvzLGj4U7B9ysl26eNbiPmzmeOQsuFvp5VjouVptRfwxKng=@protonmail.com> Date: Wed, 10 Feb 2021 16:44:49 +0100 In-Reply-To: <2yOs7mxigs8_Vx_yi858pxAkoyXmU8IidizK5grcmX4M92O5QK-_Ywo9nrHMHvzLGj4U7B9ysl26eNbiPmzmeOQsuFvp5VjouVptRfwxKng=@protonmail.com> (raid5atemyhomework@protonmail.com's message of "Wed, 06 Jan 2021 15:54:33 +0000") Message-ID: <87zh0c53m6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9DEAE940276 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: tLIzKwa+VhyJ Hi, raid5atemyhomework skribis: >>>From 4beb73c62995cf236b402dad8e1c36016027c781 Mon Sep 17 00:00:00 2001 > From: raid5atemyhomework > Date: Tue, 5 Jan 2021 22:27:56 +0800 > Subject: [PATCH 1/4] gnu: Allow services to install kernel-loadable modul= es. > > * gnu/system.scm (operating-system-directory-base-entries): Remove code > to handle generation of "kernel" and "hurd". > (operating-system-default-essential-services): Instantiate > kernel-loadable-module-service. > (hurd-default-essential-services): Instantiate > kernel-loadable-module-service. > (package-for-kernel): Move ... > * gnu/services.scm: ... to here. > (kernel-loadable-module-service-type): New variable. > (kernel-loadable-module-service): New procedure. > * gnu/tests/linux-modules.scm (run-loadable-kernel-modules-test): Move > code to ... > (run-loadable-kernel-modules-test-base): ... new procedure here. > (run-loadable-kernel-modules-service-test): New procedure. > (%test-loadable-kernel-modules-service-0): New variable. > (%test-loadable-kernel-modules-service-1): New variable. > (%test-loadable-kernel-modules-service-2): New variable. > * doc/guix.texi: Document kernel-loadable-module-service-type. [=E2=80=A6] > +@defvr {Scheme Variable} kernel-loadable-module-service-type > +Type of the service that collects lists of packages containing > +kernel-loadable modules, and adds them to the set of kernel-loadable > +modules. > +@end defvr Would be nice to expound a bit here, in particular by adding an example (along the lines of those used in system tests maybe?). Otherwise it can be hard to fathom how this is meant to be used. > +;; Configuration for the kernel builder. > +(define-record-type* kernel-builder-confi= guration > + make-kernel-builder-configuration > + kernel-builder-configuration? > + this-kernel-builder-configuration > + > + (kernel kernel-builder-configuration-kernel (default #f)) > + (hurd kernel-builder-configuration-hurd (default #f)) > + (modules kernel-builder-configuration-modules (default '()))) How about instead? In general, throughout the project, we do not use =E2=80=9Ckernel=E2=80=9D = and =E2=80=9CLinux=E2=80=9D interchangeably. Since this is a Linux-only feature, let=E2=80=99s call it= that way and remove the =E2=80=98hurd=E2=80=99 field (the Hurd has no notion of = in-kernel modules since pretty much everything happens in user-space.) > +(define kernel-loadable-module-service-type > + (service-type (name 'kernel-loadable-modules) Same here: =E2=80=98linux-loadable-module-service-type=E2=80=99. But=E2=80=A6 it=E2=80=99s not clear at first sight how this differs from th= e existing =E2=80=98kernel-module-loader=E2=80=99. Perhaps =E2=80=98linux-build-servi= ce-type=E2=80=99 would be more accurate? Or am I missing something? Thanks, Ludo=E2=80=99.