From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id rqgiFsDaJ2DFbgAA0tVLHw (envelope-from ) for ; Sat, 13 Feb 2021 13:57:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ILZZEcDaJ2ANSgAA1q6Kng (envelope-from ) for ; Sat, 13 Feb 2021 13:57:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A7E32844E for ; Sat, 13 Feb 2021 14:57:19 +0100 (CET) Received: from localhost ([::1]:53360 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAvQE-0006eZ-M5 for larch@yhetil.org; Sat, 13 Feb 2021 08:57:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAvPy-0006eS-DQ for guix-patches@gnu.org; Sat, 13 Feb 2021 08:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAvPy-0002so-6D for guix-patches@gnu.org; Sat, 13 Feb 2021 08:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAvPy-0003Br-4z for guix-patches@gnu.org; Sat, 13 Feb 2021 08:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45409] [PATCH v3 3/3] guix: Split (guix substitutes) from (guix scripts substitute). Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Feb 2021 13:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45409 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 45409@debbugs.gnu.org Received: via spool by 45409-submit@debbugs.gnu.org id=B45409.161322459812229 (code B ref 45409); Sat, 13 Feb 2021 13:57:02 +0000 Received: (at 45409) by debbugs.gnu.org; 13 Feb 2021 13:56:38 +0000 Received: from localhost ([127.0.0.1]:33851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAvPa-0003BB-BK for submit@debbugs.gnu.org; Sat, 13 Feb 2021 08:56:38 -0500 Received: from mira.cbaines.net ([212.71.252.8]:48306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAvPY-0003B3-7a for 45409@debbugs.gnu.org; Sat, 13 Feb 2021 08:56:36 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 4165A27BC27; Sat, 13 Feb 2021 13:56:35 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 06625f0e; Sat, 13 Feb 2021 13:56:35 +0000 (UTC) References: <20210104211927.14959-1-mail@cbaines.net> <20210104211927.14959-3-mail@cbaines.net> <87r1mzrqgk.fsf@gnu.org> <87zh1kidoc.fsf@cbaines.net> <87im83eha5.fsf@gnu.org> <87sg717yny.fsf@cbaines.net> User-agent: mu4e 1.4.14; emacs 27.1 From: Christopher Baines In-reply-to: <87sg717yny.fsf@cbaines.net> Date: Sat, 13 Feb 2021 13:56:31 +0000 Message-ID: <87zh08jckw.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.46 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7A7E32844E X-Spam-Score: -4.46 X-Migadu-Scanner: scn0.migadu.com X-TUID: AAIqv9KbuDcQ --=-=-= Content-Type: text/plain Christopher Baines writes: > I've rebased on master, tweaked the commit messages, and send a set of > v4 patches and while they don't create the (guix substitutes) module, I > think they unpick the bits I'd like to move out from the code doing the > connection caching. I did some more testing today, and while it turns out the tests passed when run with network access, one test failed when building the guix package. I've now rebased, and added an addition patch to address this, and sent a v5 series. My testing locally seems to suggest this works, so I'd like to merge it soon so I can push on with moving code out of the script module. One other thing, while trying to debug the test failure, I was hitting the rather topical substituter "Backtrace:" issue [1][2], and of course, this is more an issue with error handling than anything else. I hacked something in to send backtraces to (current-error-port), which is specifically handled in the substituter script, and I think that would be a good thing to do properly? 1: https://issues.guix.gnu.org/45828 2: https://issues.guix.gnu.org/46362 Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmAn2o9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfAnQ//TuDZuYYtQWGGFBt0N5MJn071Xaygo054 2bJJSQfW5/70BRUcbD69zDsn/B4pE3j6dzK8sN+UFNG81QEyjTo7bAP7iCftvuYi Sir0aZOqyEZSam0R05ja5pUTkA9R5Dv8oxOML5B2vik+R0F2KBWrNdU10z81gaEW +2KE1hFYP+xBdvoloJ8BQJdhepBoeOXJKVaqIxdxDT8ZPU33wyoGop0dofoMiJdU J8OkUl5E4Ov2T312W5my800wnUsIbilx3Yk5VPaXRI/0RI3KwBqHCNgy+cY4X11V bYD1emxqbVYcgyockiR6D6WTk2R7/ARoqhIsnWZ1PuRJHFZeSFNSqQc+efk66JVB W5eajHXQnx/JVpnDQ4/hjtqAy+JXZlz3fHONw1/gwgG+OxJD7VKPTLiKPOsc/IIT QT7ijoC2HsXoL0n86OWcqWG7yVk+2rLsqhykwUTx/otNY5CEZ+BrUw6Zf39tHdcr R6yU/loUcgCxfmxXtqwdOnV97uHKctPA5e9FCb3pg33qnTXXNoAcBEL5zwxKDQA+ iNkXJ5WWk6pwrkNZ9ZRXA/OesyEDwTpePRTXT917nUFekfTzPQZ7/5PmSUZOgS6o GK2Ml1qJQuEUvj9Pcb82a+cqms6NEshjaxJsfGNUjyD54/JcWNjqkv9Pr1xp7inL 47eNS89jXAU= =NA07 -----END PGP SIGNATURE----- --=-=-=--