From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJg1DOVmlmCSagAAgWs5BA (envelope-from ) for ; Sat, 08 May 2021 12:24:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MI3MB+VmlmBuQwAAbx9fmQ (envelope-from ) for ; Sat, 08 May 2021 10:24:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B082D93AE for ; Sat, 8 May 2021 12:24:36 +0200 (CEST) Received: from localhost ([::1]:39354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfK8R-0003aX-S5 for larch@yhetil.org; Sat, 08 May 2021 06:24:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfK7u-0003ZB-PZ for guix-patches@gnu.org; Sat, 08 May 2021 06:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfK7u-0004m3-Hh for guix-patches@gnu.org; Sat, 08 May 2021 06:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lfK7u-0002zA-Eh for guix-patches@gnu.org; Sat, 08 May 2021 06:24:02 -0400 Subject: bug#48220: [PATCH] gnu: xfce4-session: Add xset to propagated-inputs. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 08 May 2021 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 48220 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brendan Tildesley Cc: 48220-done@debbugs.gnu.org Mail-Followup-To: 48220@debbugs.gnu.org, ludo@gnu.org, mail@brendan.scot Received: via spool by 48220-done@debbugs.gnu.org id=D48220.162046942211460 (code D ref 48220); Sat, 08 May 2021 10:24:02 +0000 Received: (at 48220-done) by debbugs.gnu.org; 8 May 2021 10:23:42 +0000 Received: from localhost ([127.0.0.1]:49344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfK7Z-0002ym-Vt for submit@debbugs.gnu.org; Sat, 08 May 2021 06:23:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfK7X-0002yd-FP for 48220-done@debbugs.gnu.org; Sat, 08 May 2021 06:23:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56446) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfK7J-0004Se-Bz; Sat, 08 May 2021 06:23:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60474 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfK7H-00011V-B8; Sat, 08 May 2021 06:23:25 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210504092051.24383-1-mail@brendan.scot> <87v97xjoux.fsf@gnu.org> <615974577.179836.1620268738791@office.mailbox.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 19 =?UTF-8?Q?Flor=C3=A9al?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 08 May 2021 12:23:21 +0200 In-Reply-To: <615974577.179836.1620268738791@office.mailbox.org> (Brendan Tildesley's message of "Thu, 6 May 2021 04:38:58 +0200 (CEST)") Message-ID: <87zgx58qxy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620469476; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=O2ecG7dlN5GLaamV2ftAxT21wop8H+dy4NmwhAzS5T4=; b=TzjLUiZBFKNVfOxJgt+a5Rk3Tas5lhE270adwNFEEYojsivUx1SgKA26p7kjIXPZhzCVV3 4YIlAPLMxLMhL0W3TkEcPIikdcv4CKYVq8coiztJ1tPECfXNWTmhijVicc7O1ogV9DbDdU sZ4NNEEqwB+gt/6Uhsa/uXC1Y+O7AJGf2rryfbjFZ4YZ2eGBUIbF2uWMaYKYl2b152/5dY QTeORXb86PtukJkmK2MTgGpsc3BsfyUa5rFTwaMVCxMudjxs3bkohlgJfnFWhuylE/bbdB wxZ/w/7q/YMkDSYNtin82yTj2hlRBFt22T6hMIYDk9++9ipwebYtj4nmhd2aRQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620469476; a=rsa-sha256; cv=none; b=MZtGWWR4LBOx/jB4mCAC/TiExq5AvZaflSonCTI8AYFWim2sinmAceeYYD1W0JY1pbLRpX 0CY6PrGUKnz5c8UvO+iMG4qPdM/kfmy2QG9ALZxN14WDOwmPt3oyU3nV74PS2zIya0FKoV AjDHIZemJgb0pM3aKju+dkhBSN3a3yjOH8MDTxBx7yWclUPHU0++KHbeQlfAZF6z+wyRYX 9bEDEJ08RAeaGlgJtaXjau9mKe+5ja4bKPT92pV28cToojoMrnnv8mH8MrgZBuiD/Sh+UH lYM4pioDxkHHl25VvBg4KsxVm10GpA0EEcg7xGTuLuuVx0p/C0t4w7oxQIVJNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: B082D93AE X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: A9+pQO8fMvd+ Hi! Brendan Tildesley skribis: [...] >> However, my understanding is that the xset code is already a fallback: > >>=20 >> --8<---------------cut here---------------start------------->8--- >> # else run another access locking utility, if installed >> for lock_cmd in \ >> "xlock -mode blank" \ >> "slock" >> do >> set -- $lock_cmd >> if command -v -- $1 >/dev/null 2>&1; then >> $lock_cmd >/dev/null 2>&1 & >> # turn off display backlight: >> xset dpms force off >> exit >> fi >> done >> --8<---------------cut here---------------end--------------->8--- >>=20 >> Probably we should ensure the first =E2=80=98for=E2=80=99 loop works as = expected. >> Perhaps we need to replace =E2=80=98xfce4-screensaver-command=E2=80=99 b= y its absolute >> file name there. >>=20 > > Currently xfce4-screensaver is not installed in the xfce package at all b= y default, > so it isn't used. I could add it, but for me it was glitchy/flickering an= d I would keep=20 > clearing the password as I was entering it so I couldn't log back in. It = even does it > in a VM. I do have a recent amd graphics card with proprietary linux thou= gh, my computer > can't boot otherwise :(. Hmm OK. We should address this in a separate issue. > If you run guix environment --ad-hoc xfce4-screensaver > then > xfce4-screensaver &; xfce4-screensaver-command --lock > does it work for you? I get: --8<---------------cut here---------------start------------->8--- $ xfce4-screensaver & xfce4-screensaver-command --lock [1] 19108 ** Message: 12:20:44.361: Screensaver is not running! Start xfce4-screensav= er first --8<---------------cut here---------------end--------------->8--- =E2=80=A6 but I=E2=80=99m not running Xfce. I should prolly try in a VM. > I'm not sure what is best, should we be maximal and include xfce4-screens= aver in the xfce > package, or be minimal and make people have to install it manually? I=E2=80=99d lean towards including xfce4-screensaver, since that=E2=80=99s = the intended use of Xfce, but only once it actually works. > From ed66cf50a3b9294effc8bbae04b0f2564bd55c10 Mon Sep 17 00:00:00 2001 > From: Brendan Tildesley > Date: Thu, 6 May 2021 12:34:55 +1000 > Subject: [PATCH] gnu: xfce4-session: Allow xflock4 to use xset. > > * gnu/packages/xfce.scm (xfce4-session): > [inputs]: Add xset. > [arguments]: Add a phase to use exact store path to xset in xflock4. [...] > + (add-after 'unpack 'patch-xflock > + (lambda _ > + (substitute* "scripts/xflock4" > + (("xset") (which "xset")))))))) Applied after changing =E2=80=98which=E2=80=99 to refer to the =E2=80=9Cxse= t=E2=80=9D input so that it works correctly when cross-compiling. Closing, and let=E2=80=99s discuss xfce4-screensaver separately! Thanks, Ludo=E2=80=99.