From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gDG9DqZNmmCZGAAAgWs5BA (envelope-from ) for ; Tue, 11 May 2021 11:25:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uCx6CqZNmmC1CQAAB5/wlQ (envelope-from ) for ; Tue, 11 May 2021 09:25:58 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF11B252FC for ; Tue, 11 May 2021 11:25:57 +0200 (CEST) Received: from localhost ([::1]:33604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgOeK-0008QI-UI for larch@yhetil.org; Tue, 11 May 2021 05:25:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgO8U-0002A8-Pr for guix-patches@gnu.org; Tue, 11 May 2021 04:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgO8U-0005Vb-Gd for guix-patches@gnu.org; Tue, 11 May 2021 04:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgO8U-0002W2-F8 for guix-patches@gnu.org; Tue, 11 May 2021 04:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47989] [PATCH] channels: Add a #:system argument to channel-instances->manifest. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 11 May 2021 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47989 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 47989@debbugs.gnu.org Received: via spool by 47989-submit@debbugs.gnu.org id=B47989.16207231359584 (code B ref 47989); Tue, 11 May 2021 08:53:02 +0000 Received: (at 47989) by debbugs.gnu.org; 11 May 2021 08:52:15 +0000 Received: from localhost ([127.0.0.1]:34902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgO7j-0002UV-8h for submit@debbugs.gnu.org; Tue, 11 May 2021 04:52:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgO7h-0002UF-TY for 47989@debbugs.gnu.org; Tue, 11 May 2021 04:52:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42414) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgO7c-00051E-Hs; Tue, 11 May 2021 04:52:08 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=40056 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgO7X-0005PL-U5; Tue, 11 May 2021 04:52:08 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210424081402.26742-1-mail@cbaines.net> <20210505112419.14893-1-mail@cbaines.net> Date: Tue, 11 May 2021 10:52:02 +0200 In-Reply-To: <20210505112419.14893-1-mail@cbaines.net> (Christopher Baines's message of "Wed, 5 May 2021 12:24:19 +0100") Message-ID: <87zgx13b65.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620725157; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=h7uS5uF0XMux0lNrvaDURNaX8PdKi13vAFJ3aUd1zwM=; b=bJvBSOxkELr7XY8FphPYQvLO312FrDzIB3/0NQZ9bYHR4cR6nFqkvW34Bmioh78lGujMp6 J7h4Yeid5+4oz+hzhwtL28y+LExI7tacDULapkqYl4mOsjW0FCvZpaluuYFCaHI0pcMv4o iDbZ2nj3q2NBbE3PfGqvl8iRIR3vPjMjTfdjgx//dbL8Ul0ytGjMzgocwTbWcxFBKMNl3g 6x3tqFNgg5yns5YdpGmaa1MmFY1smdwbvo9wJMhV05/U7Hc3Z2Q4kbS2WUrxerfrrx1kux asCprClJbWdmb2lvy+YVCMpM+g1MqB/Go780edw5S/65ONGHgRCCriNx/pcryg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620725157; a=rsa-sha256; cv=none; b=NQmRO6oJG5Lo7BRltBvCisHL07KtL8sALlYXBRDPWe/81phhEkaxuFFUQHpGGnPDZSlHNS JePgGNQNst2FkxVjWyPfUo/8RWX+bFB6v6X8ArKXv0hfav4xkBqdVR91eNza59bjbyFh63 r6Osh1NOAFXX4t70gj7uFihXjgzBolKe0KZfriOZPqb9ZXYTgSJ13T3idPgG07kRz0ZUxk Qq1jQ6gC7yWatZ6XNIMKjKMUPEEARSaeC+tQ6QIb5NN1KXG0Ta04V5kN4B+QS6Pn9lLBid nYSmjW+4Loz3QCr2dVlqdF9SXBlFSxwGBk7zb05iqfxWCBW8bP5ZJjeiIvolYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CF11B252FC X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: mU0KIGBys17h Christopher Baines skribis: > This allows computing a manifest for a specific system. Previously this w= as > possible, but only through changing %current-system, which caused the > derivation to be computed using that system as well (so computing a deriv= ation > for aarch64-linux on x86_64-linux would require running aarch64-linux cod= e). > > This new argument adds the possibility of computing derivations for non-n= ative > systems, without having to run non-native code. > > I'm looking at this as it will enable the Guix Data Service to compute ch= annel > instance derivations without relying on QEMU emulation for non-native > systems (it should be faster as well). > > * guix/channels.scm (build-from-source): Add #:system argument and pass to > build. > (build-channel-instance): Add system argument and pass to build-from-sour= ce. > (channel-instance-derivations): Add #:system argument and pass to > build-channel-instance, also rename system to current-system-value. > (channel-instances->manifest): Add #:system argument and pass to > channel-instance-derivations. LGTM! (Please double-check that =E2=80=98make as-derivation=E2=80=99 or =E2=80=98= guix pull --url=3D$PWD =E2=80=A6=E2=80=99 work, in case we overlooked something.) Thank you, Ludo=E2=80=99.