From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GHnbGnfMvGDeYwAAgWs5BA (envelope-from ) for ; Sun, 06 Jun 2021 15:24:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wmARFnfMvGBmYAAAbx9fmQ (envelope-from ) for ; Sun, 06 Jun 2021 13:24:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 19AF511891 for ; Sun, 6 Jun 2021 15:24:07 +0200 (CEST) Received: from localhost ([::1]:36154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpsl3-0007R9-Qs for larch@yhetil.org; Sun, 06 Jun 2021 09:24:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38946) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpsl0-0007R0-JD for guix-patches@gnu.org; Sun, 06 Jun 2021 09:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39473) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpsl0-0003Ng-Cz for guix-patches@gnu.org; Sun, 06 Jun 2021 09:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lpsl0-00066k-9F for guix-patches@gnu.org; Sun, 06 Jun 2021 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47670] [PATCH 0/2] Add updater for packages hosted as SourceHut Git repositories Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Jun 2021 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47670 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 47670@debbugs.gnu.org Received: via spool by 47670-submit@debbugs.gnu.org id=B47670.162298582223452 (code B ref 47670); Sun, 06 Jun 2021 13:24:02 +0000 Received: (at 47670) by debbugs.gnu.org; 6 Jun 2021 13:23:42 +0000 Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpskc-000668-Ju for submit@debbugs.gnu.org; Sun, 06 Jun 2021 09:23:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lpskX-00065p-CN for 47670@debbugs.gnu.org; Sun, 06 Jun 2021 09:23:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50832) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpskP-00033o-O0; Sun, 06 Jun 2021 09:23:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=56634 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpskN-0002cO-W3; Sun, 06 Jun 2021 09:23:25 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <6b8ddedae2addf01efa57dcf3a6723bed81bf076.camel@zaclys.net> <87im4vwtyd.fsf@yoctocell.xyz> <2513bc7a1e52872be1cd1b8ecde11e21a6f613e0.camel@zaclys.net> <87fszzwryv.fsf@yoctocell.xyz> <87czv3wrnj.fsf@yoctocell.xyz> Date: Sun, 06 Jun 2021 15:23:22 +0200 In-Reply-To: <87czv3wrnj.fsf@yoctocell.xyz> (Xinglu Chen's message of "Fri, 09 Apr 2021 14:48:00 +0200") Message-ID: <87zgw3jfed.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622985847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=GNukp4SXmYUjof9Sc1I++EC5/oGoFI8mVkw6ILrYdDg=; b=nlclwfKYndT/ibh9axYr/SNHYEo3NXU60jQmwD0h7MUDLrcDpuuuPX2TkYsu9qufX8dLaO 13VBNHm06c49UlAnMvituw4ss5aGKmDmO88JUUqSXqz+ujIF4pcqefrkixcMb9ASeFKcck 2h7kK5SPrUCZUOkwkbJtrHuLtZt8yFdd2qm7AXwZaHpFZnPITSYMTCnyvX4aByhLFjQIyk msUjFBIFjESTdllrnXI1IbK0UOLawAJmajW6cD1KRqFtP/bGN/21Dpi5WqwJQvzbQTAIvb PJNYAXu6PS8Ki0NEsKmdWbMj792VVj7Ckze18kkoFWMQtVCSezoauTvb78oPGQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622985847; a=rsa-sha256; cv=none; b=uwqLhRf4MDyU4e1cI7rYaqZDQHpYN/XdHXipFVs289OGw5/jk7HRGr1eZMNXYC4R/ZL3my twY7SM/EOHpcEGQA3woFfjulQ2QQhC/sJLUmFNhELQsErxNN6vdaS9jkXRXi9R7BOLP9kn BNrcZUQ547qiiCzvf7Kh87NVvbSuadW9udACcTnTzv94ZjITigXt2bSVDpPd1ta0tLIXkK zBUpac1mroswc43Q8DVW2nydxnXsJ/TeItMlTp6r8G+0EGj2U0NjOqmmHjjaCqm40q90tB Rdbp0EuDiBDaQIN98f/v8D+2QwIuAqcu2VxVOzqHCIHSadXVz+VfNKlPF8x+fg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 19AF511891 X-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: Pi30jcZkcIcM Hi! Xinglu Chen skribis: > On Fri, Apr 09 2021, Xinglu Chen wrote: > >> On Fri, Apr 09 2021, L=C3=A9o Le Bouter via Guix-patches via wrote: >> >>> Is that an autogenerated tarball? I am under the impression that usage >>> of those is banned in GNU Guix, and that there's a lint pass for it. >>> What do you use these autogenerated tarballs for? Is the 'ls-remote' >>> command not enough to replace the version and hash? >> >> The GitHub updater fetches the autogenerated tarball so that's what I >> did as well. I wasn't aware about the fact that we would like to avoid >> them. >> >>> GNU Guix uses shallow clones (AIUI) to save bandwidth, do you need >>> this to generate the hash? I encourage you use the same shallow clone >>> mechanism here, so it's more generic and not specific to Sourcehut. >> >> Ok, I will use shallow clones to make it more generic. > > Umm, the 'upstream-source-compiler' uses 'url-fetch' to fetch the url, I > guess we would have to make it support Git repositories first. Yes, that=E2=80=99s a limitation of (guix upstream) right now. =E2=80=98%method-updates=E2=80=99 was a first step in the direction of supp= orting Git repos. Now, I agree with L=C3=A9o that (1) this is not SourceHut-specific, and (2) it should not download generated archives. Also, I=E2=80=99d prefer to have the code rely on Guile-Git to list tags ra= ther than invoking =E2=80=98git=E2=80=99, if possible. Perhaps that code could = leave in its own (guix import git) module or similar, rather than in (guix gnu-maintenance), which already has little to do with GNU maintenance at this point. :-) Thoughts? Ludo=E2=80=99.