From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aNv0HBfiv2BSIQAAgWs5BA (envelope-from ) for ; Tue, 08 Jun 2021 23:33:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0Ko6GBfiv2D5fgAA1q6Kng (envelope-from ) for ; Tue, 08 Jun 2021 21:33:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E527213F2 for ; Tue, 8 Jun 2021 23:33:10 +0200 (CEST) Received: from localhost ([::1]:43100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqjLR-0003Dq-89 for larch@yhetil.org; Tue, 08 Jun 2021 17:33:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqjLK-0003DN-Cf for guix-patches@gnu.org; Tue, 08 Jun 2021 17:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqjLK-0000Lf-5Y for guix-patches@gnu.org; Tue, 08 Jun 2021 17:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqjLJ-0007Om-UB for guix-patches@gnu.org; Tue, 08 Jun 2021 17:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48915] [PATCH] gnu: polkit: Graft a replacement for CVE-2021-3560. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jun 2021 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48915 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: security patch To: Leo Famulari Cc: 48915@debbugs.gnu.org Received: via spool by 48915-submit@debbugs.gnu.org id=B48915.162318796428400 (code B ref 48915); Tue, 08 Jun 2021 21:33:01 +0000 Received: (at 48915) by debbugs.gnu.org; 8 Jun 2021 21:32:44 +0000 Received: from localhost ([127.0.0.1]:59919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqjL1-0007Ny-UF for submit@debbugs.gnu.org; Tue, 08 Jun 2021 17:32:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqjL0-0007Nk-9b for 48915@debbugs.gnu.org; Tue, 08 Jun 2021 17:32:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47360) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqjKu-00008B-RM; Tue, 08 Jun 2021 17:32:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=36242 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqjKu-0003bq-Jv; Tue, 08 Jun 2021 17:32:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210608084512.29608-1-ludo@gnu.org> Date: Tue, 08 Jun 2021 23:32:35 +0200 In-Reply-To: (Leo Famulari's message of "Tue, 8 Jun 2021 13:52:41 -0400") Message-ID: <87zgw0caa4.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623187991; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=tb27OOCXv7iDchsu0ki821ypcyeEyKrNp6KEq+NbxtA=; b=TC5HivHReVMU2W4FK4qdjuc/ba+Sn+a20Eezr1h7jTnHds6SG8zE8dss6lIt6nLQFNBwEk eOEAhzEIyscDIa3Hpe8zmDQa3ygGdtTdff8K7KYLpPymI+EA4B0cXnqfTwnqK5t2erUDsb vyAr6tKUnMptM4SNM0YRvAXZwKZKT37fXvdFJlIKAg+DuRe+yQrjUi9v4Jw9h6ucSWVBN7 6pG8vBb+2AITZ5c7E8w0NEigotiHCHWN55GxvunWucv+nqhL77S2Wox3ZtyFV0x1WcB2IY nUcwgIpOcbS1UWhEYe7l1c+Zo9uxkkKRMIeZwbya9stVONW7fN21z+nK0tp4wQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623187991; a=rsa-sha256; cv=none; b=P41PgXLmIW3yBG23QWTp1ELH2NQm1iW3wfYVar7LJucr9eo6g1xbcuF/eGVIeegG0JuH7M OEHe81sYzwEQdkBuPnVbwha9F+HxFF0eP/i8nKBhykWqDgYVwxTESkwfqw3NQ7WOMnDWpL BLfrF4OB2UIhjOthNn/Qk3OZtaIDLah3x8slsi1G+mAKq8AV0/OOu7pX49F2iWtCsOSuKO /uIbQYP3eOoT0LTtJuyBtZ5x6xh6Sj6z9ZC06O79QA2xCVbFDE+FuTlxUlQGCe1JLXjjCQ O2GqxLP+ArsPGvmhyFCtyrKuZZA+Qn2aLvaoOMuCrc9lvToCICJmFJpY663hPw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9E527213F2 X-Spam-Score: -2.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: BKoy3hjOobmG Leo Famulari skribis: > On Tue, Jun 08, 2021 at 10:45:12AM +0200, Ludovic Court=C3=A8s wrote: >> +(define-public polkit/fixed >> + (package >> + (inherit polkit) >> + (version "0.11A") ;0.116 + patch >> + (source (origin >> + (inherit (package-source polkit)) >> + (patches (search-patches "polkit-CVE-2021-3560.patch"))))= )) > > Typically, we don't change the version when creating replacement > packages that apply a patch. We only change the version when the > replacement package actually updates to a new version. Pushed as 9178566954cc7f34d2d991d31df4565adad93508! As discussed on IRC, I ended up making =E2=80=98polkit/fixed=E2=80=99 priva= te, with the version string unchanged (inherited from =E2=80=98polkit=E2=80=99). We wondered whether Cuirass would build =E2=80=98polkit/fixed=E2=80=99 if i= t=E2=80=99s private. Turns out it does, but this comment in (gnu ci) is still valid: --8<---------------cut here---------------start------------->8--- (define (all-packages) "Return the list of packages to build." (define (adjust package result) (cond ((package-replacement package) ;; XXX: If PACKAGE and its replacement have the same name/versio= n, ;; then both Cuirass jobs will have the same name, which ;; effectively means that the second one will be ignored. Thus, ;; return the replacement first. (cons* (package-replacement package) ;build both package result)) --8<---------------cut here---------------end--------------->8--- IOW, the replacement, and only the replacement, gets built. The current =E2=80=98zstd=E2=80=99 replacement is private only shows derivations for the replacement, not for the original one. That=E2=80=99s okay though because the original one necessarily got built earlier. Thanks, Ludo=E2=80=99.