From: "Ludovic Courtès" <ludo@gnu.org>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: 49880@debbugs.gnu.org
Subject: [bug#49880] [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux
Date: Wed, 11 Aug 2021 23:34:31 +0200 [thread overview]
Message-ID: <87zgtnis2g.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210804184128.153984-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Wed, 4 Aug 2021 15:41:28 -0300")
Thiago Jung Bauermann <bauermann@kolabnow.com> skribis:
> GMP 4.3 was released with a bug in the t-scan test which causes it to crash
> with a segmentation fault. Backport fix from upstream.
>
> * gnu/packages/commencement.scm (gmp-boot): Apply
> gmp-4.3-fix-t-scan-test.patch.
> * gnu/packages/patches/gmp-4.3-fix-t-scan-test.patch: New file.
Please add the file to gnu/local.mk as well.
> + ;; See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60933#c11
> + (patches (search-patches "gmp-4.3-fix-t-scan-test.patch"))))
Comments about the patch should go at the top of the patch, preferably.
So, we could avoid a world rebuild by applying the patch in a
powerpc64le-specific build phase instead of adding it to ‘patches’.
Now, I suppose we’re just lucky that this test hasn’t crashed on other
platforms, aren’t we? In that case, that would call for applying the
patch (or skipping tests, even) unconditionally, thus triggering a world
rebuild on all arches.
Thoughts?
Ludo’.
next prev parent reply other threads:[~2021-08-11 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 18:34 [bug#49880] [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux Thiago Jung Bauermann via Guix-patches via
2021-08-04 18:41 ` [bug#49880] [PATCH 2/2] gnu: gmp-boot: Fix t-scan test crash Thiago Jung Bauermann via Guix-patches via
2021-08-04 18:51 ` Thiago Jung Bauermann via Guix-patches via
2021-08-11 21:34 ` Ludovic Courtès [this message]
2021-08-11 21:29 ` [bug#49880] [PATCH 1/2] gnu: gmp-boot: Fix build on powerpc64le-linux Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgtnis2g.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=49880@debbugs.gnu.org \
--cc=bauermann@kolabnow.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).