From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MHTvL1CmN2G5SwAAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 19:50:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kBCYK1CmN2GDMgAAB5/wlQ (envelope-from ) for ; Tue, 07 Sep 2021 17:50:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A9E0AE15 for ; Tue, 7 Sep 2021 19:50:08 +0200 (CEST) Received: from localhost ([::1]:54266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfEV-0005PQ-0A for larch@yhetil.org; Tue, 07 Sep 2021 13:50:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfEQ-0005Na-2f for guix-patches@gnu.org; Tue, 07 Sep 2021 13:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNfEP-00074l-RB for guix-patches@gnu.org; Tue, 07 Sep 2021 13:50:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNfEP-0004zn-PR for guix-patches@gnu.org; Tue, 07 Sep 2021 13:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48237] [PATCH] gnu: emacs-consult: Add =?UTF-8?Q?=E2=80=98emacs-ve?= Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Sep 2021 17:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48237 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Maxim Cournoyer Cc: Arun Isaac , 48237@debbugs.gnu.org Received: via spool by 48237-submit@debbugs.gnu.org id=B48237.163103696119138 (code B ref 48237); Tue, 07 Sep 2021 17:50:01 +0000 Received: (at 48237) by debbugs.gnu.org; 7 Sep 2021 17:49:21 +0000 Received: from localhost ([127.0.0.1]:57615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfDk-0004yb-Mn for submit@debbugs.gnu.org; Tue, 07 Sep 2021 13:49:20 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:49576 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNfDh-0004yE-K7 for 48237@debbugs.gnu.org; Tue, 07 Sep 2021 13:49:18 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631036949; bh=+MNYMtk1QS/oaU4x0nuX/3H6Mai9dm4fbI0gSqMTVQM=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=SHslbv+NIlQu1W/dZCOwzZTKrP8HP8ReFew0W83ubsDRs33m2FI8f1YoVkOaqn4Hm JUs15KOkbNjOtrSyzzSaoP3+3SZdQR/b8GzJJDawbNZrOYXoQQSBaQS5WW7LYnhfi9 k3VIPCzNTAf20qb6J5cKgLbx9h30CoMEqpy2QsvY= In-Reply-To: References: <87k0oa4o7h.fsf@yoctocell.xyz> <871r9kl1tr.fsf@yoctocell.xyz> <87pmukuhsf.fsf@systemreboot.net> <87v93d24tx.fsf@yoctocell.xyz> <8735qhbnj7.fsf@gmail.com> Date: Tue, 07 Sep 2021 19:49:07 +0200 Message-ID: <87zgsoz370.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631037008; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8YS6ScX/XLoigcq7KGeiFXeqNL5ZCloe2RDbeUTMxbM=; b=GnyBy2W2EsBHDEO8V/ep4u2GHvxDxTNFFA4Je45JeFtkCf9DMhglUd1zkR6tN/PSgJXw2f vcuRY51haF5XkmNlelPrRl+9xtdCCW6U5vtzrTppNgnFGNOvSEnnsWdWoQvmIr9KXzKbXc zSWPRm2uVUnDpEdrdgZW+h0zaIKUlJje5V7u3mad3xB2MNCdxKx+qE6BQ8Z7o8XBpx81QO YmVJSf5jqPdMJdjJUSbCDdKjkN3QyCVnJufetiV9LVjKDFSq957KBB6Ar4wS0pZ73i3gy7 BmIfvkKBxNDMgabztoXvrbXxgER3oPnXft6hrIxM3AX0BAt+8Gez7glFJRgE1g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631037008; a=rsa-sha256; cv=none; b=cZrMMLy6GOr/Z92cR6XvHi3ebYlZ+mmy83oe05XmOTaCjPqYnlkl2kZHMnulw7JwopKB/p mQ+PPMZKPVp6Cdq3xxFqvqz1Qbrm1lZj+UN5HW87buCsyRVAl671EXZ33RDUBp/cGXC2Vr xodfLVANqiA3wiGMBdAyvQSXPEsBEEQZlqDAO0ibyqu3FhjgqG66EB/Fp0y1RtuzWm7Alk SSZ34tC1hXYV6DdP1FWDszG/olb1M03lbjFhdPtG85qQ8b0a8oblrtty/WUToX4Q7RRwcw 9POnErWQN8lV02vzs6BH91hLx1i7pxM1DPrWPLNXs6qYXjd/8dmxmORCcNjYOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=SHslbv+N; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=SHslbv+N; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 0A9E0AE15 X-Spam-Score: -0.41 X-Migadu-Scanner: scn1.migadu.com X-TUID: Ughvma3mXVmA --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 06 2021, Liliana Marie Prikler wrote: > Am Montag, den 06.09.2021, 13:51 -0400 schrieb Maxim Cournoyer: >> Hello Arun, >>=20 >> Xinglu Chen writes: >>=20 >> > On Wed, Aug 11 2021, Arun Isaac wrote: >> >=20 >> > > Hi all, >> > >=20 >> > > I actually think we should not add emacs-vertico to the >> > > propagated-inputs, and remove emacs-flycheck and emacs-selectrum >> > > as well. All these are optional dependencies, and we should leave >> > > it to the user to install the ones they want. At least in this >> > > specific case, the three packages (flycheck, selectrum and >> > > vertico) are the kind the user would want to explicitly install. >> > > They aren't backend libraries that ought to remain invisible to >> > > the user. >> > >=20 >> > > In fact, this is the version of emacs-consult I have installed in >> > > my profile. >>=20 >> Guix packages typically come as featureful as possible unless there >> are good reasons not too (to minimize the closure size, for >> example). In this case, the added optional dependencies seem to have >> negligible effect on the closure size, according to `guix size`; I'd >> be in favor to keep the optional dependencies specified for that >> reason, unless there are other considerations that I'm missing. > While closure size is normally a good metric, with interpreted > languages like Emacs Lisp you have the added baggage of *propagating* > inputs, thereby installing stuff at user (or system) level, that the > user did not actually ask for. My personal take on those is to provide > them as inputs where necessary to compile, but not actually propagate > them where not necessary to run. > > For example, an Emacs package might require emacs-dash to function at > all and might install some autocompletion stuff with emacs-autocomplete=20 > or emacs-company (perhaps even both). emacs-dash absolutely must be > propagated, but unless you're already using autocomplete or company and > thus have them in your manifest, you probably don't want them to be > installed by emacs-foo. Does this make sense? I just noticed that the =E2=80=9C16.4.6 Emacs Packages=E2=80=9D section of = the manual has the following paragraph. The Elisp dependencies of Emacs packages are typically provided as =E2=80=98propagated-inputs=E2=80=99 when required at run time. As for ot= her packages, build or test dependencies should be specified as =E2=80=98native-inputs= =E2=80=99. =20=20 Since these optional dependencies (=E2=80=98emacs-autocomplete=E2=80=99 and =E2=80=98emacs-company=E2=80=99 in your case) are not needed at runtime, wo= uld it make sense to make them =E2=80=98native-inputs=E2=80=99 instead of =E2=80=98inpu= ts=E2=80=99? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmE3phMVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5wS4P/i4QywAz1KTYiJm6Ev2/re08c1Jc 6V0EcTlwWQR7uYk3+D+4LmmARrPykStEx1dXdZqU+y0LWpfvsuxyaKr4xArRGStS gr5J1B4AI8uMlCT5k/xiiXI2W1qkd5M/ztNEf2U91+eOtpDfRTxV0dU7GtktAYv2 ZEG7P/EP44lPDtUzxTCTMQ1Tu6J9oHXzrwmFa04xuU53HZGs2G3ia6bkJKcFjAka GZklmXTmDzrba2OUatDnuTiJkTudH226fhGhqPLxgeQNoZuGDe5c1ltjR+NRDals 5lVgvskway8DlPHnjH5VKIt8c3CI8ZdpsVWKMjf0/oHoBt2GmT8I3PjYUrLB3n1u PFgr5BAYKWMFvP3Db/scVei+LHrG4qzmgZVTY32APzQiiiQrFx4njZrXZ8Df1V8p sGRO5O1JBSZsnZoF6E2cjchei1gO+tPZlEjaz9PjVrNfP0Z6efT7YdaEYORWAyVj 2ph/awSGienrBNRN2BHC/tqLObHGjwnjMdtL+wXYHKpfVlVBjUf0pvfLY1fjWPy2 EijKBPtN617joK55ZvrQk710C/6YA9F9qMsxbngPDVK9wDLjUaEuRwXFYEssXH3I bScEtGPFLT9tfQ3hDdVV/bTExHwJqE/ppSOU0ylfFaCPAoVTGmngF2Eik2YJDZ+K RyrRpXv04o4cw2gh =Hz1L -----END PGP SIGNATURE----- --=-=-=--