From: "Ludovic Courtès" <ludo@gnu.org>
To: Sarah Morgensen <iskarian@mgsn.dev>
Cc: Attila Lendvai <attila@lendvai.name>, 50289-done@debbugs.gnu.org
Subject: bug#50289: [PATCH] import: go: Fix import when import path redirects.
Date: Tue, 07 Sep 2021 15:55:16 +0200 [thread overview]
Message-ID: <87zgso4hiz.fsf@gnu.org> (raw)
In-Reply-To: <c9ee1efc228bc7ba2287d464734e995502ef46a8.1630374913.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Mon, 30 Aug 2021 19:05:19 -0700")
Hi,
Sarah Morgensen <iskarian@mgsn.dev> skribis:
> * guix/import/go.scm (fetch-module-meta-data): If no meta entries
> have a matching import prefix, return the first entry instead of #f.
> ---
> X-Debbugs-CC: Attila Lendvai <attila@lendvai.name>
>
> Hello Guix,
>
> As reported by Attila on IRC, the Go importer currently chokes when the
> import path URL redirects, for example with "github.com/prometheus/tsdb".
>
> This is due to my modification to 'fetch-module-meta-data' to handle multiple
> package's meta tags on one page [0]. It selects the meta based on whether its
> import prefix matches the URL we requested. This breaks when the URL
> redirects but the import path is not changed (I did not realize that this
> was valid... go figure). This patch fixes that by falling back to the first
> meta if none match.
>
> [0] https://issues.guix.gnu.org/49591
Applied, thank you!
Ludo’.
prev parent reply other threads:[~2021-09-07 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 2:05 [bug#50289] [PATCH] import: go: Fix import when import path redirects Sarah Morgensen
2021-09-07 13:55 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgso4hiz.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=50289-done@debbugs.gnu.org \
--cc=attila@lendvai.name \
--cc=iskarian@mgsn.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).