From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WMNVAll+P2GnhwAAgWs5BA (envelope-from ) for ; Mon, 13 Sep 2021 18:37:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KGqnOVh+P2HoMwAA1q6Kng (envelope-from ) for ; Mon, 13 Sep 2021 16:37:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D57B2BA84 for ; Mon, 13 Sep 2021 18:37:44 +0200 (CEST) Received: from localhost ([::1]:59870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPoxj-0001Db-LN for larch@yhetil.org; Mon, 13 Sep 2021 12:37:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPodi-0000gI-Mp for guix-patches@gnu.org; Mon, 13 Sep 2021 12:17:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPodi-0003Ow-8s for guix-patches@gnu.org; Mon, 13 Sep 2021 12:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPodi-000313-59 for guix-patches@gnu.org; Mon, 13 Sep 2021 12:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50504] [PATCH] home-services: Add Mcron. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 13 Sep 2021 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50504 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , 50504@debbugs.gnu.org Cc: Oleg Pykhalov , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 50504-submit@debbugs.gnu.org id=B50504.163154980611565 (code B ref 50504); Mon, 13 Sep 2021 16:17:02 +0000 Received: (at 50504) by debbugs.gnu.org; 13 Sep 2021 16:16:46 +0000 Received: from localhost ([127.0.0.1]:46724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPodR-00030S-M2 for submit@debbugs.gnu.org; Mon, 13 Sep 2021 12:16:45 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:52506 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPodP-00030C-6q for 50504@debbugs.gnu.org; Mon, 13 Sep 2021 12:16:43 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631549794; bh=9bwKF9gulfZ0szF2PoNt5e/z1tzjDk2zvbnengYO63E=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=YoUL3Luony+LO6oLQ7qmE3eRP1qcfb5N2S7wuPUjyADJ0ig58oN7MdgRCJYbvqyVv ujEX4cGKfehnze0xnv8DJDQ+rwIlN1Od2bsUEskavsWp3r5j3yKcLb74NBYWrEBOQW txk1EOi9SQG4Avs6GRstB04M3AiLJv98MdybtVcA= In-Reply-To: <87a6khrn3x.fsf@trop.in> References: <8735qc66mt.fsf@trop.in> <87a6kkxpcp.fsf@yoctocell.xyz> <87a6khrn3x.fsf@trop.in> Date: Mon, 13 Sep 2021 18:16:31 +0200 Message-ID: <87zgsgtpr4.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631551064; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=4u/n9W7sjJXjzs9fRyhs1wVuxyPF/pQu2VbdGqu+GoQ=; b=K913tyBgnp/C6Was8VfvRbWr763nfAeZVhrkaSKQizHJuorgHuBV7B5lboLWR4wd3xSV+s wulk/z5JY9TX80jkvOBvvHjLMYc1OC14Ls5JnG0vf5Dh8yvsh/dLQLqWDUXsDAlaTuPI6E JydRPNK7gTuJVYJYgH++qtYNE6NXRcU1BlTI4LZyyM/k6X5XVFYDNlYHiY2JVSsh6sDhk2 48z9DAGdxYiGlxqUPj/Z1QltsA/8haD+Gb9U6G8X/+XckzQzOfv6rhY6mFFmOU/ausgxJK i17j4nqtFUQRhT2BFDgeARycLVyw5tKSMRGwU0noioEeS8Tshz9xjfTTd5Hqvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631551064; a=rsa-sha256; cv=none; b=dfPzdHUpaDZcbF3ITthsANmoaE/LI+c3q+br1IiA/55oYM3ruABvmLbEuY9IYCuSJrFqIj tqS4/YKUW6e+Hd+S3+3U6JUtsvYaUL/lSCa4CLaX80kJezWlA4JZfivNTEjX42DMgjy1Te ZuGPn5IiQdHWvk+kKXc+VMrfMx/MIJFGsfV1kIDFNHUjJDyrLWyxYlqqOT+AIONoqE3xgw +LrShJCLWELw4H/azjyZ8qFEH34MIP/JUxQsT5Cb63096xs+cpQEbWMNbqyejH15s7dTQ6 cqfy+ospGA/MkbVj7U9tsIHFcOmkF3yEdB0mlVoLA1v3EYXcokTrUNN61UAFGg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=YoUL3Luo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.90 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=YoUL3Luo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9D57B2BA84 X-Spam-Score: -1.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: J7RMa5ITnufY --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 13 2021, Andrew Tropin wrote: > On 2021-09-10 20:22, Xinglu Chen wrote: > >> On Fri, Sep 10 2021, Andrew Tropin wrote: >> >>> * gnu/home-services/mcron.scm: New file. >>> * gnu/local.mk: Add this. >>> * doc/guix.texi: Add documentation about Mcron Home Service. >>> --- >>> >>> This is the last of home services I consider "must-have" for wip-guix-h= ome. >>> >>> It reuses two functions from (gnu services mcron) via @@, which can be >>> considered as a hack, the alternative solution is to expose those funct= ions >>> via #:export, I can do it if it's a preffered way or suggest other idea= s, >>> please. The discussion on this topic: https://issues.guix.gnu.org/47238 >>> Included Ludovic and Xinglu in CC. >> >> An alternative would be put it the (gnu service mcron) to share more >> code between system service and home service. This was discussed >> briefly on rde-devel[1]. It might be worth discussing this issue on >> guix-devel before we add too many home service. >> > > I'll make a thread on possible modules naming for home services later > this week and will discuss this thing too. Cool! >>> I took a brief look at the testing approach, seems the most relevant is >>> guix-system.sh and it is just a shell script, which runs a few guix sys= tem >>> subcommand and check if they fail or succeed. Please let me know, what= is a >>> preferred way for writing tests and I'll try to provide some tests for = Guix >>> Home in the separate patch. >> >> The =E2=80=98guix-system.sh=E2=80=99 script seems to only test the =E2= =80=98guix system=E2=80=99 >> command, which doesn=E2=80=99t seem that related to the home services. = I guess >> we could check the contents of the generated config files. There is >> (gnu build marionette) which creates a VM; we could then check that the >> relevant process is running. Maybe there is a better approach, though. >> > > It was a general question about tests for Guix Home, not Mcron home > service, sorry for the confusion. No worries! To clarify, you were referring to the =E2=80=98guix home=E2=80= =99 command line utilities when you wrote =E2=80=9CGuix Home=E2=80=9D, right? If so, t= hey could probably be based on the =E2=80=98guix-system.sh=E2=80=99 test. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmE/eV8VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5M2MP/jbcyweHCaPOqEjLxDOPGQr/nRsH 9A9Af6CD1ftq4Sar12dhKs6OuECvw3hx0b1ulYutQwl6w9nT/sll7qUpeoyIv0pt U98FYQ284wYxgA31h2tSzgSA91nEZO3NyxZ4W+x2mpBiNuvOARB0zQxmJXUT/Db0 1RMepxmgQ8NwCjIgC5XOAKNFIS1j897b4iKkUQ8aUP5Lt6Azwyu4NoUd87LtobTe Cns5PY/bG7Esu2uNCsWB1BL3ZWMwFTFDqL6vBjaLbBkIKNJnHCDTdNviiIQzekEz ZDPmunSs2WG1IfYNh57P8qBNGxH6gnUZUL0TX3H4gSvtebKyY71R/O066us7TcF1 MmAnFWsJSLnQOj1owD4bg3Ai3uL2nDaku0SAwnJjvZljsPyOyzhyz64Nc86B1G2G yofrhD/Yfw2Dv+xLXAK9Av3F7QvmtO0+CWMl4tRFHLtGSOxpSiGBmI/Me4HCuDsE TxUCAwtvWmPIDorJrZVisvNGwJ5fU0tG/MH0EqghzCltfJ6lQ+JIpbwvb0RV3mGb WH+IwgbOJoivFKAZSilaxPF/Fq5TdClob2fC7qePaIFylu4sHURJIwxvKBrfJVpe 2KlYiidbin0t5RNJhN7CiIMhFrhnB2m9RshEAHkjCxk940FmS96IFtyHqt7Md8Do WHvDc+AYafVIx9Wo =nru6 -----END PGP SIGNATURE----- --=-=-=--