unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Andrew Tropin <andrew@trop.in>, 50504@debbugs.gnu.org
Cc: "Oleg Pykhalov" <go.wigust@gmail.com>, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#50504] [PATCH] home-services: Add Mcron.
Date: Mon, 13 Sep 2021 18:16:31 +0200	[thread overview]
Message-ID: <87zgsgtpr4.fsf@yoctocell.xyz> (raw)
In-Reply-To: <87a6khrn3x.fsf@trop.in>

[-- Attachment #1: Type: text/plain, Size: 2204 bytes --]

On Mon, Sep 13 2021, Andrew Tropin wrote:

> On 2021-09-10 20:22, Xinglu Chen wrote:
>
>> On Fri, Sep 10 2021, Andrew Tropin wrote:
>>
>>> * gnu/home-services/mcron.scm: New file.
>>> * gnu/local.mk: Add this.
>>> * doc/guix.texi: Add documentation about Mcron Home Service.
>>> ---
>>>
>>> This is the last of home services I consider "must-have" for wip-guix-home.
>>>
>>> It reuses two functions from (gnu services mcron) via @@, which can be
>>> considered as a hack, the alternative solution is to expose those functions
>>> via #:export, I can do it if it's a preffered way or suggest other ideas,
>>> please.  The discussion on this topic: https://issues.guix.gnu.org/47238
>>> Included Ludovic and Xinglu in CC.
>>
>> An alternative would be put it the (gnu service mcron) to share more
>> code between system service and home service.  This was discussed
>> briefly on rde-devel[1].  It might be worth discussing this issue on
>> guix-devel before we add too many home service.
>>
>
> I'll make a thread on possible modules naming for home services later
> this week and will discuss this thing too.

Cool!

>>> I took a brief look at the testing approach, seems the most relevant is
>>> guix-system.sh and it is just a shell script, which runs a few guix system
>>> subcommand and check if they fail or succeed.  Please let me know, what is a
>>> preferred way for writing tests and I'll try to provide some tests for Guix
>>> Home in the separate patch.
>>
>> The ‘guix-system.sh’ script seems to only test the ‘guix system’
>> command, which doesn’t seem that related to the home services.  I guess
>> we could check the contents of the generated config files.  There is
>> (gnu build marionette) which creates a VM; we could then check that the
>> relevant process is running.  Maybe there is a better approach, though.
>>
>
> It was a general question about tests for Guix Home, not Mcron home
> service, sorry for the confusion.

No worries!  To clarify, you were referring to the ‘guix home’ command
line utilities when you wrote “Guix Home”, right?  If so, they could
probably be based on the ‘guix-system.sh’ test.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-09-13 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  6:26 [bug#50504] [PATCH] home-services: Add Mcron Andrew Tropin
2021-09-10 18:22 ` Xinglu Chen
2021-09-13  6:44   ` Andrew Tropin
2021-09-13 16:16     ` Xinglu Chen [this message]
2021-09-14  6:34       ` Andrew Tropin
2021-09-13  6:48   ` [bug#50504] [PATCH] fixup! " Andrew Tropin
2021-09-13 16:17     ` Xinglu Chen
2021-09-13 20:02     ` bug#50504: [PATCH] " Oleg Pykhalov
2021-09-14  6:35       ` [bug#50504] " Andrew Tropin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgsgtpr4.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=50504@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=go.wigust@gmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).