From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sLWOCxhSamE81AAAgWs5BA (envelope-from ) for ; Sat, 16 Oct 2021 06:16:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UHBMBxhSamFtUAAAB5/wlQ (envelope-from ) for ; Sat, 16 Oct 2021 04:16:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B18DE128 for ; Sat, 16 Oct 2021 06:16:23 +0200 (CEST) Received: from localhost ([::1]:36106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbb7O-0007nf-1w for larch@yhetil.org; Sat, 16 Oct 2021 00:16:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbb75-0007df-2t for guix-patches@gnu.org; Sat, 16 Oct 2021 00:16:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbb74-0000t5-QA for guix-patches@gnu.org; Sat, 16 Oct 2021 00:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mbb74-0007in-H7 for guix-patches@gnu.org; Sat, 16 Oct 2021 00:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42338] [PATCH] Add composer build system (PHP) Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Oct 2021 04:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42338 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Julien Lepiller , 42338@debbugs.gnu.org Received: via spool by 42338-submit@debbugs.gnu.org id=B42338.163435772329628 (code B ref 42338); Sat, 16 Oct 2021 04:16:02 +0000 Received: (at 42338) by debbugs.gnu.org; 16 Oct 2021 04:15:23 +0000 Received: from localhost ([127.0.0.1]:40735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbb6Q-0007ho-Fb for submit@debbugs.gnu.org; Sat, 16 Oct 2021 00:15:22 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:35421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbb6I-0007hQ-Lz for 42338@debbugs.gnu.org; Sat, 16 Oct 2021 00:15:21 -0400 Received: by mail-qk1-f172.google.com with SMTP id bj31so7651876qkb.2 for <42338@debbugs.gnu.org>; Fri, 15 Oct 2021 21:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=eM8VFJ5qe9H68IA252j4Axt08bs4NuuYHisw9ELph/M=; b=QVpQ2gwp24CLcPkSt3U9B4JvCVOYEh9VFGN+0Kxn2SJv09Cwr7jx4fhXtlC73Z3ucW NqpUhhWMvEMAmoeVgMEu0Hrt00Rutg75/6IZ8NmpFslJIv9+j2j6ArTCfM5i2j4eyHq/ TB0qsVEws1YkOUtxM/xzNHhpZ31SXjQKRxVopDRSB6KyPYgqAg0yA/Lqn4/cZ43iEH/u 1n8r5dPWBjl656kCaD4bFoX0gdCQy2cQVPg47W4O+Q0xeI1pcOa9ok97GIk3vgeNbRrG 400aYnX2GJBklTbovc4DwHqJfYaEwyVbQGJEtQZZ/lyvSyfkg11xnO7nJEMg6NGXheYV ksNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=eM8VFJ5qe9H68IA252j4Axt08bs4NuuYHisw9ELph/M=; b=AL3y9SgFMgCr4wqkJmhOazMgTgyIED9lT/+IYcIboPR59/YrShBuBV1cLWJnfoFcXT ep5s3IVXAwkGa+9D7T1hRdMtcLBxLgwMXhrbFEsIgzyZnODPgNvNsMFb5iH1AcKCgL8E BQVj3/pavbbww10w9FjlbxXKjcYcHJ7TdqTeNXH6ohyRZNbHkqhR0hwW0vQlE1l5wvcL 4VohToVOhP22Bmgtn6E5aEoG0GAsXzaoddcHAat79GScsxirjtTpQiiRgaQZoBVr9EKj rlCej88+Abd4IdBZXXek9dbIvD4aXfm5JLqmLI2awlQKq38sfno3eK5x70xxsZcus60Q qP0A== X-Gm-Message-State: AOAM532ilkKH+vHPLCyqpgGrx7PrKQhT6mObODu+JsLZD443x1VdNucs uZw+TjkFeIY7MgJJ1v+UIrhL7FKSxKBmkw== X-Google-Smtp-Source: ABdhPJyzk+/QotSmJrUhCaM75wQSj2ELGVQpJ/qY13QfRUqcfxX59vXKIVeN5XfpTNBSE5K/Ckd1yw== X-Received: by 2002:a37:684a:: with SMTP id d71mr12987466qkc.382.1634357708994; Fri, 15 Oct 2021 21:15:08 -0700 (PDT) Received: from hurd (dsl-10-146-97.b2b2c.ca. [72.10.146.97]) by smtp.gmail.com with ESMTPSA id 6sm3947450qtz.13.2021.10.15.21.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 21:15:08 -0700 (PDT) From: Maxim Cournoyer References: <20200713002055.1553f136@tachikoma.lepiller.eu> <20200712222538.18092-1-julien@lepiller.eu> <87mu21heay.fsf@gnu.org> <20200918004333.127aa5da@tachikoma.lepiller.eu> <87sgbf1o5w.fsf@gnu.org> <20200919012055.1b2e686f@tachikoma.lepiller.eu> <87lfgy179m.fsf@gnu.org> Date: Sat, 16 Oct 2021 00:15:07 -0400 In-Reply-To: <87lfgy179m.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Fri, 25 Sep 2020 12:27:01 +0200") Message-ID: <87zgr9k3lg.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634357783; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eM8VFJ5qe9H68IA252j4Axt08bs4NuuYHisw9ELph/M=; b=aLf0H308626muuqRz54E4Bd7C2f/4dDnpcf4iIQ18XL1c5NeUqhFoXcArfzMuBtNu0opAp Y29GNtJkNFVMcgzEKuccL5hPcqrvO958LuIKLiqgs6R5EPBAmIETFcAG3NGnK2NnqG4nsG VEYh8N4byvPezdZBno7kEJ3RnjT6cmyspSy9fylnknfnOIkwG7grcj453mZPspUCcm00rA +ZdSxxZfsiPOhSeGaDFgM4hy5YKGMdRF5Z1gcF4baG5ijLpCaZnmHVYMrO2Ot1gPczeB/r 4+isGVHt64UeVreGRqNQkqsTyfHkE1rK5+fkWDDWSFPfb5oSALKFeNeCX2xoOQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634357783; a=rsa-sha256; cv=none; b=sEd+TbMd43IVrTQ74HNQqCMJtsFSMNh+iiCQ3rHTrDwfU2pIuYyc7vM0S+tgcnpIF/21tG Bdx5oGzYaRa5pDEjKnAxPHl6byN8yd6vNyRULLXHCkkJqF/cPzQU7fPe0l94C0qfh2LOf8 L42x6r5KpN4AttSqraW4Ilhs2pa/3UOaJkO61kku3J223aYIhD2ZZmRgAt/L2jcyGrYPdD NVSaQs79l9g1ibEQMw65C629ifYSfHyyws2WpHhj45sXE3xtO4SCEG+YoLQpJUIMi+DV4k 1r3jG7dq8zGIM85cVRlA9URpvhDPO27GqKRETFkCdra4DQOEhkCusuhxrRLUGA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QVpQ2gwp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QVpQ2gwp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6B18DE128 X-Spam-Score: -1.32 X-Migadu-Scanner: scn0.migadu.com X-TUID: ACTSpHvl9l5O Hey Julien, That's a pretty interesting series you have there. Ludovic Court=C3=A8s writes: > Hi Julien, > > Julien Lepiller skribis: > >> From 70b9cb2bb389f3e5f9dcc75a44d7d60c28f997bc Mon Sep 17 00:00:00 2001 >> From: Julien Lepiller >> Date: Tue, 29 Oct 2019 08:07:38 +0100 >> Subject: [PATCH 01/34] guix: import: Add composer importer. >> >> * guix/import/composer.scm: New file. >> * guix/scripts/import/composer.scm: New file. >> * guix/tests/composer.scm: New file. >> * Makefile.am: Add them. >> * guix/scripts/import.scm: Add composer importer. >> * doc/guix.texi (Invoking guix import): Mention it. > > [...] > >> +@cindex PHP >> +Import metadat from the @uref{https://getcomposer.org/, Composer} packa= ge > ^ > Typo. > >> +(define* (composer-fetch name #:optional version) >> + "Return an alist representation of the Composer metadata for the pack= age NAME, >> +or #f on failure." >> + (let ((package (json-fetch >> + (string-append (%composer-base-url) "/p/" name ".jso= n")))) >> + (if package >> + (let* ((packages (assoc-ref package "packages")) >> + (package (or (assoc-ref packages name) package)) >> + (versions (filter >> + (lambda (version) >> + (and (not (string-contains version "dev")) >> + (not (string-contains version "beta")= ))) >> + (map car package))) >> + (version (or (if (null? version) #f version) >> + (latest-version versions)))) >> + (assoc-ref package version)) >> + #f))) > > I think this should directly return a since the all > the callers pass the alist through =E2=80=98json->composer-package=E2=80= =99. The idea > is that alists should be converted to records as soon as they enter the > process. > > Also it=E2=80=99s weird that =E2=80=98package=E2=80=99 above has a =E2=80= =9Cpackages=E2=80=9D (plural) entry. > Perhaps we=E2=80=99re missing another JSON mapping? > > [...] > >> +++ b/guix/scripts/import/composer.scm >> @@ -0,0 +1,107 @@ >> +;;; GNU Guix --- Functional package management for GNU >> +;;; Copyright =C2=A9 2015 David Thompson >> +;;; Copyright =C2=A9 2018 Oleg Pykhalov > > You can preserve these two lines if you think it=E2=80=99s relevant, but = I=E2=80=99d > suggest adding one for yourself. > > OK to push with changes along these lines. Seems you were almost ready to roll. Consider this a very gentle ping :-). Maxim