[bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.

unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed

* [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
@ 2022-01-17 14:45 路辉
  2022-01-17 19:13 ` Maxime Devos
  2022-01-18  3:06 ` [bug#53318] [PATCH v2] " jgart via Guix-patches via
  0 siblings, 2 replies; 6+ messages in thread
From: 路辉 @ 2022-01-17 14:45 UTC (permalink / raw)
  To: 53318

From 30907bd26956ab6e0983eeca6b69aee935ebe155 Mon Sep 17 00:00:00 2001
From: Lu Hui <luhux76@gmail.com>
Date: Mon, 17 Jan 2022 22:40:51 +0800
Subject: [PATCH] gnu: Add go-github-com-go-chi-chi-v5.

* gnu/packages/golang.scm (go-github-com-go-chi-chi-v5): New variable.
---
 gnu/packages/golang.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index db95ef1309..587357f6ba 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9370,3 +9370,27 @@ (define-public go-github-com-dreamacro-go-shadowsocks2
 @item TCP tunneling (e.g. benchmark with iperf3)
 @end itemize")
     (license license:asl2.0)))
+
+(define-public go-github-com-go-chi-chi-v5
+  (package
+    (name "go-github-com-go-chi-chi-v5")
+    (version "5.0.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/go-chi/chi")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0rzrsxz4xj0973c6nxklvq2vmg2m795snhk25836i0gnd1jnx79k"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/go-chi/chi/v5"))
+    (home-page "https://github.com/go-chi/chi")
+    (synopsis "Lightweight, idiomatic and composable router for building
+Go HTTP services")
+    (description
+     "@code{go-github-com-go-chi-chi-v5} is just a http router that
+lets you decompose request handling into many smaller layers.")
+    (license license:expat)))
-- 
2.34.0




^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
  2022-01-17 14:45 [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5 路辉
@ 2022-01-17 19:13 ` Maxime Devos
       [not found]   ` <CAGNyvegjVYJcR7_MCdHyfSVzkJqhWTdrT7B4guk4Jh-kkGT8JQ@mail.gmail.com>
  2022-01-18  3:06 ` [bug#53318] [PATCH v2] " jgart via Guix-patches via
  1 sibling, 1 reply; 6+ messages in thread
From: Maxime Devos @ 2022-01-17 19:13 UTC (permalink / raw)
  To: 路辉, 53318

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Hi,

路辉 schreef op ma 17-01-2022 om 14:45 [+0000]:
> +    (synopsis "Lightweight, idiomatic and composable router for building
> +Go HTTP services")

Everything tries to be lightweight, idiomatic, etc. nowadays, so these
descriptions aren't helpful to the user.  From ‘17.4.4 Synopses and
Descriptions’:

  Please avoid marketing phrases such as “world-leading”,
  “industrial-strength”, and “next-generation”, and avoid superlatives
  like “the most advanced”—they are not helpful to users looking for a
  package and may even sound suspicious.  Instead, try to be factual,
  mentioning use cases and features.

How about:

  ‘Composable router for HTTP services written in Go’

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <CAGNyvegjVYJcR7_MCdHyfSVzkJqhWTdrT7B4guk4Jh-kkGT8JQ@mail.gmail.com>]

* [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
       [not found]   ` <CAGNyvegjVYJcR7_MCdHyfSVzkJqhWTdrT7B4guk4Jh-kkGT8JQ@mail.gmail.com>
@ 2022-01-18 17:51     ` Maxime Devos
  2022-01-19 11:04       ` Efraim Flashner
  0 siblings, 1 reply; 6+ messages in thread
From: Maxime Devos @ 2022-01-18 17:51 UTC (permalink / raw)
  To: 路辉; +Cc: 53318


[-- Attachment #1.1: Type: text/plain, Size: 922 bytes --]

Hi,

Please keep debbugs in CC: or To: so other people know how the patch is
progressing.

路辉 schreef op di 18-01-2022 om 15:26 [+0000]:
> OK, new patch: [...]

I did the following checks:

  1. [x] it builds
  2. [x] "guix lint" shows no problems
  3. [x] there doesn't appear to be any malware in the source code

While doing (3), I noticed that the test code has a certificate
‘certs.pem’ and ‘key.pem’, which will expire eventually, which isn't
good for long-term reproducibility
(cf. https://issues.guix.gnu.org/44559).

So in the adjusted package definition, I deleted the affected test
‘middleware/middleware_test.go’, 'testdata/cert.pem' and
'testdata/key.pem', see attachement.

I also capitalised 'http' to 'HTTP' in the description.
The description is a bit short but I don't have much of an idea
how to improve it.

Aside from that, it LGTM.

Greetings,
Maxime.

[-- Attachment #1.2: chi.scm --]
[-- Type: text/x-scheme, Size: 1376 bytes --]

(use-modules (guix packages)
	     (guix git-download)
	     (guix build-system go)
	     ((guix licenses) #:prefix license:)
	     (guix gexp))

(define-public go-github-com-go-chi-chi-v5
  (package
   (name "go-github-com-go-chi-chi-v5")
   (version "5.0.7")
   (source (origin
            (method git-fetch)
            (uri (git-reference
                  (url "https://github.com/go-chi/chi")
                  (commit (string-append "v" version))))
            (file-name (git-file-name name version))
            (sha256
             (base32
              "0rzrsxz4xj0973c6nxklvq2vmg2m795snhk25836i0gnd1jnx79k"))
            ;; This certificate used by tests will eventually expire,
            ;; so remove it and the test that uses this certificate
            ;; to avoid future build failures.
            (snippet
             #~(begin
                 (for-each delete-file '("testdata/cert.pem" "testdata/key.pem" "middleware/middleware_test.go"))))))
   (build-system go-build-system)
   (arguments
    '(#:import-path "github.com/go-chi/chi/v5"))
   (home-page "https://github.com/go-chi/chi")
   (synopsis "Composable router for HTTP services written in Go")
   (description
    "@code{go-github-com-go-chi-chi-v5} is a HTTP router that
lets you decompose request handling into many smaller layers.")
   (license license:expat)))
go-github-com-go-chi-chi-v5

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
  2022-01-18 17:51     ` Maxime Devos
@ 2022-01-19 11:04       ` Efraim Flashner
  0 siblings, 0 replies; 6+ messages in thread
From: Efraim Flashner @ 2022-01-19 11:04 UTC (permalink / raw)
  To: Maxime Devos; +Cc: 路辉, 53318

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Tue, Jan 18, 2022 at 06:51:29PM +0100, Maxime Devos wrote:
> Hi,
> 
> Please keep debbugs in CC: or To: so other people know how the patch is
> progressing.
> 
> 路辉 schreef op di 18-01-2022 om 15:26 [+0000]:
> > OK, new patch: [...]
> 
> I did the following checks:
> 
>   1. [x] it builds
>   2. [x] "guix lint" shows no problems
>   3. [x] there doesn't appear to be any malware in the source code
> 
> While doing (3), I noticed that the test code has a certificate
> ‘certs.pem’ and ‘key.pem’, which will expire eventually, which isn't
> good for long-term reproducibility
> (cf. https://issues.guix.gnu.org/44559).
> 
> So in the adjusted package definition, I deleted the affected test
> ‘middleware/middleware_test.go’, 'testdata/cert.pem' and
> 'testdata/key.pem', see attachement.
> 
> I also capitalised 'http' to 'HTTP' in the description.
> The description is a bit short but I don't have much of an idea
> how to improve it.
> 
> Aside from that, it LGTM.

FWIW when I imported this package I got the following description:

Package chi is a small, idiomatic and composable router for building HTTP services.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#53318] [PATCH v2] gnu: Add go-github-com-go-chi-chi-v5.
  2022-01-17 14:45 [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5 路辉
  2022-01-17 19:13 ` Maxime Devos
@ 2022-01-18  3:06 ` jgart via Guix-patches via
  2022-01-28  9:53   ` Nicolas Goaziou
  1 sibling, 1 reply; 6+ messages in thread
From: jgart via Guix-patches via @ 2022-01-18  3:06 UTC (permalink / raw)
  To: 53318; +Cc: Lu Hui, jgart, Maxime Devos

* gnu/packages/golang.scm (go-github-com-go-chi-chi-v5): New variable.

---

Hi Lu and Maxime,

Here's a version two with Maxime's suggestion and a few nitpick fixes in the
description.

all best,

jgart

 gnu/packages/golang.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e808d8ebf6..f7a1e16c8c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9341,3 +9341,26 @@ (define-public go-github-com-dreamacro-go-shadowsocks2
 @item TCP tunneling (e.g. benchmark with iperf3)
 @end itemize")
     (license license:asl2.0)))
+
+(define-public go-github-com-go-chi-chi-v5
+  (package
+    (name "go-github-com-go-chi-chi-v5")
+    (version "5.0.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/go-chi/chi")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0rzrsxz4xj0973c6nxklvq2vmg2m795snhk25836i0gnd1jnx79k"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/go-chi/chi/v5"))
+    (home-page "https://github.com/go-chi/chi")
+    (synopsis "Composable router for HTTP services written in Go")
+    (description
+     "@code{go-github-com-go-chi-chi-v5} is an http router that
+lets the user decompose request handling into many smaller layers.")
+    (license license:expat)))
-- 
2.34.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#53318] [PATCH v2] gnu: Add go-github-com-go-chi-chi-v5.
  2022-01-18  3:06 ` [bug#53318] [PATCH v2] " jgart via Guix-patches via
@ 2022-01-28  9:53   ` Nicolas Goaziou
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Goaziou @ 2022-01-28  9:53 UTC (permalink / raw)
  To: 53318; +Cc: Lu Hui, jgart, 53318-done, Maxime Devos

Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/golang.scm (go-github-com-go-chi-chi-v5): New variable.
>
> ---
>
> Hi Lu and Maxime,
>
> Here's a version two with Maxime's suggestion and a few nitpick fixes in the
> description.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-01-28  9:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-17 14:45 [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5 路辉
2022-01-17 19:13 ` Maxime Devos
     [not found]   ` <CAGNyvegjVYJcR7_MCdHyfSVzkJqhWTdrT7B4guk4Jh-kkGT8JQ@mail.gmail.com>
2022-01-18 17:51     ` Maxime Devos
2022-01-19 11:04       ` Efraim Flashner
2022-01-18  3:06 ` [bug#53318] [PATCH v2] " jgart via Guix-patches via
2022-01-28  9:53   ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).