From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yDC9Jr3G9WEsRQAAgWs5BA (envelope-from ) for ; Sat, 29 Jan 2022 23:59:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uNNyH73G9WFKUwEAG6o9tA (envelope-from ) for ; Sat, 29 Jan 2022 23:59:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 146783CF77 for ; Sat, 29 Jan 2022 23:59:09 +0100 (CET) Received: from localhost ([::1]:35204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDwgW-0002ia-9v for larch@yhetil.org; Sat, 29 Jan 2022 17:59:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDwgQ-0002hW-MB for guix-patches@gnu.org; Sat, 29 Jan 2022 17:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDwgQ-0001ns-4r for guix-patches@gnu.org; Sat, 29 Jan 2022 17:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDwgP-0007Y2-T4 for guix-patches@gnu.org; Sat, 29 Jan 2022 17:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53584] guix: Use 'gexp->derivation' instead of 'build-expression->derivation'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 29 Jan 2022 22:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53584 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina Cc: 53584@debbugs.gnu.org Received: via spool by 53584-submit@debbugs.gnu.org id=B53584.164349711628966 (code B ref 53584); Sat, 29 Jan 2022 22:59:01 +0000 Received: (at 53584) by debbugs.gnu.org; 29 Jan 2022 22:58:36 +0000 Received: from localhost ([127.0.0.1]:35125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDwg0-0007X8-3x for submit@debbugs.gnu.org; Sat, 29 Jan 2022 17:58:36 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:37146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDwfx-0007Wo-RF for 53584@debbugs.gnu.org; Sat, 29 Jan 2022 17:58:34 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 373A6485; Sat, 29 Jan 2022 23:58:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lA8XuVhovdof; Sat, 29 Jan 2022 23:58:26 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C0658375; Sat, 29 Jan 2022 23:58:25 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 29 Jan 2022 23:58:25 +0100 In-Reply-To: (phodina@protonmail.com's message of "Thu, 27 Jan 2022 14:38:13 +0000") Message-ID: <87zgne9mjy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 373A6485 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[protonmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[protonmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643497149; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=uravweyL0UV3mBWz73QlSFcZ9INsjxOLoKUgcOiJqBc=; b=aWmxMm/g1qYe965xkeKfVl09YETLet3//BwBdhmxgnvnRFs68JGswiZWDG6iB1QBT5M5Ko O35FXRe3l7uvwNwJIU5059tKAOxtqI+jWTsfBAtOxHMRc4mmtV3yFg7EZ/jJwnMdbY3or9 6UwlwW4d4p9XK/z7F2WzogQ8gdBy3SRlDFnC1juNz9D9hYzXc6a+RO/MQUmry/34kxx0Vf aM4ArpkfkUxBQVFWjsmCbHX+cUwlZCnWMNjmVz8Oa6J5DDSsHeDvAr08YcHFtbVlBRSZF6 KJlvm7n35JI3EfRQl1Z2xKVU72K5WfpdMulYE9J+ZVYtVkLLZinpPaC07OWXgg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643497149; a=rsa-sha256; cv=none; b=As+6GL6LTgTtIdqn1uWnsTSYQPGCK296nAfUOjBFHjEGEnSrSEPcBI5G1yqF2N0Y7+VPz4 0HunNJHDyILD1xUe6IM7BM+c3qUByHcYtCDazteLc/ur2Vi6YNgtpyTqUTmEYd7Uc+A1rL HDTublCKrEuO9gQPmhKzGFcMGyBvaYIdJZ1a6IJYZwXEe6Q6ys71cAFlh8MOPrW+hQ3cCV 9dlK0aS7OLDx/xVuK6jE24+3ZCGNkHygPsP5WDjihh8ScgiJUTyODaw9si8DpKbc2dWUP7 jyzGPRLQotSrQLz6uQqLVQqPAGo7q7KPokmK8uMuce52pfvo7MoJec8LehtVrg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 146783CF77 X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6wztvR+t5DfK Hi, phodina skribis: > From e128b9d35060187b04ebd36cabd152f0e968dc87 Mon Sep 17 00:00:00 2001 > From: Petr Hodina > Date: Thu, 27 Jan 2022 15:32:35 +0100 > Subject: [PATCH] guix: Use 'gexp->derivation' instead of > 'build-expression->derivation'. > > * guix/derivations.scm: Update deprecated expression. > * guix/grafts.scm: Same as above. > > diff --git a/guix/derivations.scm b/guix/derivations.scm > index f77ea179f4..615bb161d1 100644 > --- a/guix/derivations.scm > +++ b/guix/derivations.scm > @@ -1218,7 +1218,7 @@ (define builder > #:opts %auto-compilation-options))))) > files))) >=20=20 > - (build-expression->derivation store name builder > + (gexp->derivation store name builder > #:inputs `(("modules" ,module-dir)) > #:system system > #:guile-for-build guile > diff --git a/guix/grafts.scm b/guix/grafts.scm > index 0ffda8f9aa..e0a97e895b 100644 > --- a/guix/grafts.scm > +++ b/guix/grafts.scm > @@ -134,7 +134,7 @@ (define properties > ((($ sources source-outputs targets target-outputs) ...) > (let ((sources (zip sources source-outputs)) > (targets (zip targets target-outputs))) > - (build-expression->derivation store name build > + (gexp->derivation store name build > #:system system > #:guile-for-build guile > #:modules '((guix build graft) It=E2=80=99s unfortunately not that simple: the above code doesn=E2=80=99t = work, notably because =E2=80=98gexp->derivation=E2=80=99 is a monadic procedure, unlike =E2=80=98build-expression->derivation=E2=80=99. Also, the first hunk is unnecessary since it=E2=80=99s in an internal proce= dure that=E2=80=99s used by =E2=80=98build-expression->derivation=E2=80=99 itsel= f. I=E2=80=99m closing it for now but this is something we should address eventually! Thanks, Ludo=E2=80=99.