unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#53738] [PATCH] gnu: nyxt: Add missing input.
@ 2022-02-02 22:05 jgart via Guix-patches via
  2022-02-03  9:49 ` Guillaume Le Vaillant
  0 siblings, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2022-02-02 22:05 UTC (permalink / raw)
  To: 53738; +Cc: jgart

* gnu/packages/web-browsers.scm (nyxt)[inputs]: Add sbcl-cl-gopher.
---
 gnu/packages/web-browsers.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index c49e3ceac5..1aec6d6adc 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -639,6 +639,7 @@ (define-public nyxt
        ("cl-containers" ,sbcl-cl-containers)
        ("cl-css" ,sbcl-cl-css)
        ("cl-custom-hash-table" ,sbcl-custom-hash-table)
+       ("cl-gopher" ,sbcl-cl-gopher)
        ("cl-html-diff" ,sbcl-cl-html-diff)
        ("cl-json" ,sbcl-cl-json)
        ("cl-ppcre" ,sbcl-cl-ppcre)
-- 
2.35.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#53738] [PATCH] gnu: nyxt: Add missing input.
  2022-02-02 22:05 [bug#53738] [PATCH] gnu: nyxt: Add missing input jgart via Guix-patches via
@ 2022-02-03  9:49 ` Guillaume Le Vaillant
  2022-02-03 21:37   ` jgart via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Guillaume Le Vaillant @ 2022-02-03  9:49 UTC (permalink / raw)
  To: jgart; +Cc: 53738

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

jgart via Guix-patches via <guix-patches@gnu.org> skribis:

> * gnu/packages/web-browsers.scm (nyxt)[inputs]: Add sbcl-cl-gopher.
> ---
>  gnu/packages/web-browsers.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> index c49e3ceac5..1aec6d6adc 100644
> --- a/gnu/packages/web-browsers.scm
> +++ b/gnu/packages/web-browsers.scm
> @@ -639,6 +639,7 @@ (define-public nyxt
>         ("cl-containers" ,sbcl-cl-containers)
>         ("cl-css" ,sbcl-cl-css)
>         ("cl-custom-hash-table" ,sbcl-custom-hash-table)
> +       ("cl-gopher" ,sbcl-cl-gopher)
>         ("cl-html-diff" ,sbcl-cl-html-diff)
>         ("cl-json" ,sbcl-cl-json)
>         ("cl-ppcre" ,sbcl-cl-ppcre)

Hi,

What issue is solved by adding cl-gopher to inputs?

As far as I can see the source code for Nyxt 2.2.4 doesn't contain any
reference to cl-gopher, so just adding it to inputs will not change the
produced nyxt program.

According to the upstream repository, support for Gopher and Gemini will
be in Nyxt 3.0.0, which has not been released yet.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#53738] [PATCH] gnu: nyxt: Add missing input.
  2022-02-03  9:49 ` Guillaume Le Vaillant
@ 2022-02-03 21:37   ` jgart via Guix-patches via
  2022-02-03 22:20     ` bug#53738: " Guillaume Le Vaillant
  0 siblings, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2022-02-03 21:37 UTC (permalink / raw)
  To: Guillaume Le Vaillant; +Cc: 53738

On Thu, 03 Feb 2022 09:49:26 +0000 Guillaume Le Vaillant <glv@posteo.net> wrote:
> jgart via Guix-patches via <guix-patches@gnu.org> skribis:
> 
> > * gnu/packages/web-browsers.scm (nyxt)[inputs]: Add sbcl-cl-gopher.
> > ---
> >  gnu/packages/web-browsers.scm | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
> > index c49e3ceac5..1aec6d6adc 100644
> > --- a/gnu/packages/web-browsers.scm
> > +++ b/gnu/packages/web-browsers.scm
> > @@ -639,6 +639,7 @@ (define-public nyxt
> >         ("cl-containers" ,sbcl-cl-containers)
> >         ("cl-css" ,sbcl-cl-css)
> >         ("cl-custom-hash-table" ,sbcl-custom-hash-table)
> > +       ("cl-gopher" ,sbcl-cl-gopher)
> >         ("cl-html-diff" ,sbcl-cl-html-diff)
> >         ("cl-json" ,sbcl-cl-json)
> >         ("cl-ppcre" ,sbcl-cl-ppcre)
> 
> Hi,
> 
> What issue is solved by adding cl-gopher to inputs?
> 
> As far as I can see the source code for Nyxt 2.2.4 doesn't contain any
> reference to cl-gopher, so just adding it to inputs will not change the
> produced nyxt program.
> 
> According to the upstream repository, support for Gopher and Gemini will
> be in Nyxt 3.0.0, which has not been released yet.

Ah ok. I was accidently reading the master branch latest commit instead
of version 2.2.4.

https://github.com/atlas-engineer/nyxt/blob/16a89132fdbf56c713033edcc2d4611f06199f3c/source/mode/small-web.lisp#L18

Sorry, yes, let's wait.

all best,

jgart




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#53738: [PATCH] gnu: nyxt: Add missing input.
  2022-02-03 21:37   ` jgart via Guix-patches via
@ 2022-02-03 22:20     ` Guillaume Le Vaillant
  0 siblings, 0 replies; 4+ messages in thread
From: Guillaume Le Vaillant @ 2022-02-03 22:20 UTC (permalink / raw)
  To: jgart; +Cc: 53738-done

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

jgart <jgart@dismail.de> skribis:

> Ah ok. I was accidently reading the master branch latest commit instead
> of version 2.2.4.
>
> https://github.com/atlas-engineer/nyxt/blob/16a89132fdbf56c713033edcc2d4611f06199f3c/source/mode/small-web.lisp#L18
>
> Sorry, yes, let's wait.
>
> all best,
>
> jgart

Thanks for confirming.
Closing for now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-03 22:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-02 22:05 [bug#53738] [PATCH] gnu: nyxt: Add missing input jgart via Guix-patches via
2022-02-03  9:49 ` Guillaume Le Vaillant
2022-02-03 21:37   ` jgart via Guix-patches via
2022-02-03 22:20     ` bug#53738: " Guillaume Le Vaillant

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).