From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2Hs/OkE47WIhEgEAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 17:33:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0P5gOUE47WJYWwAAG6o9tA (envelope-from ) for ; Fri, 05 Aug 2022 17:33:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D60B230E4D for ; Fri, 5 Aug 2022 17:33:20 +0200 (CEST) Received: from localhost ([::1]:46214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJzKC-0001F9-0I for larch@yhetil.org; Fri, 05 Aug 2022 11:33:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJzJu-0001DV-Al for guix-patches@gnu.org; Fri, 05 Aug 2022 11:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJzJu-0001Vl-1v for guix-patches@gnu.org; Fri, 05 Aug 2022 11:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJzJt-0005xS-U3 for guix-patches@gnu.org; Fri, 05 Aug 2022 11:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package. Resent-From: Christopher Rodriguez Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Aug 2022 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56989 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Christopher Rodriguez , 56989@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 56989-submit@debbugs.gnu.org id=B56989.165971353722837 (code B ref 56989); Fri, 05 Aug 2022 15:33:01 +0000 Received: (at 56989) by debbugs.gnu.org; 5 Aug 2022 15:32:17 +0000 Received: from localhost ([127.0.0.1]:60276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJzJA-0005wF-Kb for submit@debbugs.gnu.org; Fri, 05 Aug 2022 11:32:17 -0400 Received: from mail-qv1-f50.google.com ([209.85.219.50]:40538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJzJ8-0005vz-EY; Fri, 05 Aug 2022 11:32:15 -0400 Received: by mail-qv1-f50.google.com with SMTP id i4so1977566qvv.7; Fri, 05 Aug 2022 08:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc; bh=pgl3hOklyfhczKHJcStWV7AB+IeBLAv+6G55936RSp4=; b=hUZJmDQpPrhVWvc5LRnjTyV+Lpx8pBoSD9M8tl/cVluVebECGAdOJy2W3vGC6/W62L 0+DnGZ5zX3RVRgd/gn7W002nqsab4BwgZkDkw0D6QxKlOrHFhZ/2XmpaVa1FwWAIkMzc AOcwkrLmV6mholhIHBkpChp01aS+oeIkf1UMPdi+6mxkjNBpOGYf9d2mYTFjj/12rP1g FhLyJENREx1jKlJHQ8lJZcJtAiaeMpBJdLMA9eEbp7Xfg/Gj7IYUZes9ZA0cKhkUd9Hm A80tBKIe4gLtdGRfvOlniFhTMpkOPp7JZSyWbqGJvArJ73eO45VlANsCGNRHvpWrWtOq C5Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc; bh=pgl3hOklyfhczKHJcStWV7AB+IeBLAv+6G55936RSp4=; b=qxhJopWdXmoDouNGFbM5krVOqbHAM1JUJJXAFZJbqpp/2o1tbu6hqCftlQXgRvyTn8 HqfAiwmtT0TAeoG3LQgFyi7XuOcjuYwZLpBvDOfRGtaSY9SIc4mDnX4lpQTLGz3bejMs sEk2R6ZjjHpsFEM+M8y3tSZYvbqy2vFQNYnn1/QqlhASqYwDGxzIXz/7+Ki8XbntU7uC d0bZyG6onOnobFGiG5dR1+FyPfM3SA8dVhNcr5Z4QisTewStHqhaxtQEfqd2PpqgmaV0 b6BToCRrUyogGpglAOIopcHPQSKqUHD4B/Ud8QyYBGmO8b46vZ2WcnR5YW6IEWyelhC2 Xp3A== X-Gm-Message-State: ACgBeo35i7Rpbap9kUoikvAE0ayS1gm0oZgArVDwQaKLT6EcBuH9tLl0 vJ8n2yC8P+eU2gW7GJRxA58O8i8GMl6Ykw== X-Google-Smtp-Source: AA6agR7eg0bdhlA8+F6k1O6TrxzEOy9Xcw4GeHTxP5P2pvMLJGGmmp5nUoC+AEuB/81qqnCAqErMdQ== X-Received: by 2002:ad4:5be8:0:b0:479:6ba3:f08c with SMTP id k8-20020ad45be8000000b004796ba3f08cmr1431011qvc.85.1659713528837; Fri, 05 Aug 2022 08:32:08 -0700 (PDT) Received: from gmail.com ([2601:547:a00:7720::7bb0]) by smtp.gmail.com with ESMTPSA id w4-20020a05620a424400b006b8d1914504sm3338053qko.22.2022.08.05.08.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 08:32:08 -0700 (PDT) References: <20220805054616.30620-1-yewscion@gmail.com> <7742c07ce28494af40c74262277417e60fe6f500.camel@ist.tugraz.at> User-agent: mu4e 1.8.7; emacs 28.1 From: Christopher Rodriguez Date: Fri, 05 Aug 2022 11:12:53 -0400 In-reply-to: <7742c07ce28494af40c74262277417e60fe6f500.camel@ist.tugraz.at> Message-ID: <87zggin1u0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659713601; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pgl3hOklyfhczKHJcStWV7AB+IeBLAv+6G55936RSp4=; b=LlBG+1SY16h/XpRZfsACeHFxZLIdIRB+dkRQew+9Wgyw3965IDiyLDXVhpB2D8QXFKLKKg UK3tPrCHS2y6DoyEMwRLb3LyVdyCf9uc/gAYG/6DtFR0u+IyWfq6imuC+6LHbwYl5hPbMZ Ure+vQiMX7dS8P4FJ7VtV1fk71wk6m+6T8OOTuVGyRfV9CQM2oDtEr3jt8CKc75mVqGdFx XTxixvMj83wimI3VKCSyRwyrAjtv2DjJBeMqDaqx33ima31V91pXQwH4QZt3MKWkzc7K/N Jsmi5ee/AXO7V9hfGq4ACAEFoTI+1M1mHn85nZ18pTlGB5J2fCnHbfO7UjYJyw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659713601; a=rsa-sha256; cv=none; b=IWgB3Z92k7eyWuGSHyfuuAV3r9+S29zuJEof5oboYNbiyHfGY6VCiaXAkTi/Nu0nylSGdJ 1u1xTjmTf1NIJzIMb39jE1792zOxEOp7iY462fEiiqjNiAjNgEZzxBVI2nBp8mVZmdRZfH hRfDNMz7KlcK+7+btq8Cpk2GfcdfsQaWrqZzaS/gkqLxoe+TMfgWgCKVetr9xdk4qboC0T IFflYuZO145mz3o4YkJC/nlxLP/JHbaCBptI5L/PdoGJ2ysOvISRMF64FxksLty3TbqQw1 gcSP3d7nW3MwktMLCbOkWqSX4FBXIVggMu7FJF4kX+1NNlya/+XMushWddrOXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hUZJmDQp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.60 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hUZJmDQp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D60B230E4D X-Spam-Score: 7.60 X-Migadu-Scanner: scn1.migadu.com X-TUID: EzXA+lIo9DAg Liliana Marie Prikler writes: > merge 56989 56990 56991 56992 56993 > thanks Is this notation something anyone can do? I would very much like to be able to fix my own mistakes in the future. > Regarding the patch title, just one level of grouping is enough. > That is, use "gnu: Add dbqn." > > Also, you're missing a ChangeLog, i.e. > > * gnu/packages/bqn.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Register it here. I have amended the commit message to reflect the above. Thanks for the tips! I've also added `%D%/packages/bqn.scm` to `gnu/local.mk`, as requested. > Don't let-bind tag, version and hash, use them inline. ... > Note that version will be bound here even if you use the version field > to do so. This makes sense, and I've removed the let binding entirely. My only uncertainty is where "revision" should go; I've currently attached it to the upstream version tag (version "0.2.1-1"), where "0.2.1" is the tag and "1" is the revision. Is this correct? > You could do > (replace 'check > (lambda* (#:key tests? #:allow-other-keys) > (when tests? > (for-each (lambda (known-good-test) > (invoke my-glorious-bin known-good-test)) > known-good-tests)))) > FSVO my-glorious-bin and known-good-tests. I plan to do this once I've been able to look at each test and the entire source and see if I can get it working. I've added an issue upstream[1] where the author of the package has confirmed it is on "just enough life support" to build the recommended implementation from source. As it stands, I would have to test each test individually anyway, and only add it to the package if it arbitrarily passes on my machine for some reason. I don't think there is value there, as tests are meant to ensure consistency and I cannot do that using such a workflow. And though this *is* and *should be* a public package, it is *not* the recommended interpreter for the language. It is primarily included here to build the recommended one (CBQN) from source, along with some other tools I've yet to package that require it during build. > Could this be done in/before install? It could, in fact. I've moved it to the above step, and deleted subjars entirely. > You can use #:rest args to bind args for apply. Also use assoc-ref > rather than cdr + assoc. I had, for some reason, flipped the arguments on assoc-ref (which obviously didn't work) and when that failed fell back to cdr + assoc. I woke up this morning and noticed my mistake; It is fixed now. As for the #:rest args recommendation: I cannot figure out how to explicitly bind (list options) to #:options in the apply call using #:rest. This is probably ignorance on my part; I am still learning the some of the mechanisms in scheme, and have not used #:rest (or the dot notation for it) much at all. Is there an example You could point me to so I can educate myself? > Is OpenJDK 17 required? Really, only a JDK 7+ is required. openjdk17 carries the "openjdk" label currently, and so I defaulted to that one. Is there another I should use in my packages instead? > Cheers Thank You for the speedy response! -- Christopher Rodriguez