From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uLtrDBLVCGPqDwEAbAwnHQ (envelope-from ) for ; Fri, 26 Aug 2022 16:13:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KCM1DBLVCGOGNgEAauVa8A (envelope-from ) for ; Fri, 26 Aug 2022 16:13:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E4059CCCE for ; Fri, 26 Aug 2022 16:13:37 +0200 (CEST) Received: from localhost ([::1]:41640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRa5Y-00014f-6O for larch@yhetil.org; Fri, 26 Aug 2022 10:13:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRa0C-0002Lv-Ee for guix-patches@gnu.org; Fri, 26 Aug 2022 10:08:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRa09-0002t4-Np for guix-patches@gnu.org; Fri, 26 Aug 2022 10:08:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRa09-0004g7-He for guix-patches@gnu.org; Fri, 26 Aug 2022 10:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57375] [PATCH] gnu: fix cups 'install-cups-filters-symlinks phase Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 26 Aug 2022 14:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57375 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Grigory Shepelev Cc: 57375@debbugs.gnu.org Received: via spool by 57375-submit@debbugs.gnu.org id=B57375.166152284017930 (code B ref 57375); Fri, 26 Aug 2022 14:08:01 +0000 Received: (at 57375) by debbugs.gnu.org; 26 Aug 2022 14:07:20 +0000 Received: from localhost ([127.0.0.1]:54198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRZzT-0004f8-Tc for submit@debbugs.gnu.org; Fri, 26 Aug 2022 10:07:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRZzR-0004et-Nv for 57375@debbugs.gnu.org; Fri, 26 Aug 2022 10:07:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZzM-0002pF-FC; Fri, 26 Aug 2022 10:07:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=tR3q6jKpxYCyuLL8GyBfu3ktE/dmdg3eR+f4Y6ULoWM=; b=fp4Yqv1WR14AvIZkvTTo dnPeT1UQP84RSyiRd3RDc4TX0rz/Y4d2rcuAXeRR7L6zH/6eiaSgflVcFQULXfAeUu2cpyOmNNcsF R3n3BdEZ9d4n2k2Vg0ns5CiVZGTuqiKGutiZ+lOo5bMRlqKJe8r7/qRhd0fvur+I4ccmcZu38biX/ h2GhBUVWTXBi4lwwBXBGss42N3UalO82f9dhyDJYOpG9X0XbQh2oVCcReGxB9vLg/EpAQqy2SbU8s P/V/uzNyhW1XtS9t8VgqlmMQpddb2Mv2INEgteNU92/za+jkyu81gZG1dpGbcLutYrZ55uBlMaJ+c d7Zwy4AAboBmrA==; Received: from [2001:b07:6473:5604:6777:3eba:ebea:f1b1] (port=37276 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZzL-0000su-IY; Fri, 26 Aug 2022 10:07:12 -0400 From: Mathieu Othacehe References: <99c00ae2-d938-1b56-ef67-2bbfb4d38797@gmail.com> Date: Fri, 26 Aug 2022 16:07:07 +0200 In-Reply-To: <99c00ae2-d938-1b56-ef67-2bbfb4d38797@gmail.com> (Grigory Shepelev's message of "Wed, 24 Aug 2022 10:46:39 +0300") Message-ID: <87zgfrxfn8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1661523217; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=tR3q6jKpxYCyuLL8GyBfu3ktE/dmdg3eR+f4Y6ULoWM=; b=cgHJ+1xaEXAS6CcvbIGeokRQTMwYn26mwsJcFdSTX0se66v0VMWW+7q16Ucwtgo9o6C/ZJ nNmHfPopdRycciC0JbGIclf17XkHihxkc0o4ncwbi5BkZJUvmEiFPUxxYneuXb7Ql03CMN Jpr8ylJWg7E5z3e53kVqZXAMe08wrvg1JenG6PRpmcwzpLk74Qs6XTj/1l7xrGvPS2mNsz fyWfbLOlY29jkr3NighmpQ2X2lmzBz0QwTm8yNChzHj8vkz5NCDLmh/SGH3Xeqc3+/THOF VBeMtDG4JiyCC5bFCCt4SApTD3v+7UILBzORxPDqxLjUD1SUXyfxBn0gASaTpQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1661523217; a=rsa-sha256; cv=none; b=SfrXgKc0xSSrIohfCl1pIu49h3PbAFgZDD8sSQTBPJTAI7uOgZJ3lXcRsVRd2Ulb3bbvzJ xwJ1d7O32PLtnbbEypdROfOzKF11d2p2f4rb9nqwOWB8Zq5L/dR+Xj8ewlRLVYNGm+mstP 45w5Z+dIGQ8IdNVnYRQbhNMPM3QJdHR3yTolq9L5LyUYKsOcmD8EvpJGLa7MwCZkUlJrFH a0/yZyYBbJji3LQWU1455LTYa2YY2sokrqNLpGbyjDK/3coR1FuJI+oW2OA67YxoKJJ6Kh rsb3IVpbsC68rrlarz7ZxNWT4TOW45GlM1cwpUceM3vMc06ayY1jP7Bl5r7d0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fp4Yqv1W; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=fp4Yqv1W; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E4059CCCE X-Spam-Score: -4.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4IcKOydf5i+9 Hey Grigory, > (symlink f > - (string-append out "/lib/cups/filter" > + (string-append out "/lib/cups/filter/" > (basename f)))) > (find-files (string-append cups-filters "/lib/cups/filter"))) Thanks for this first contribution! This fix looks fine. However, the cups package has a lot of dependants (as shown by guix refresh -l cups). This patch should target core-updates. On that branch, the package definition has been a bit reworked. Do you think you could rebase your patch on top of that branch and check that it still works fine? Another point, you should write a commit message using the ChangeLog format. You can find more information here: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html. You should also use the "git format-patch" command to preserve the commit data such as author, commit message and so on. Don't hesitate to ask for help if needed. Mathieu