From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YF8ZGHYGxGMHmAAAbAwnHQ (envelope-from ) for ; Sun, 15 Jan 2023 14:58:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ML80GHYGxGOoJAAA9RJhRA (envelope-from ) for ; Sun, 15 Jan 2023 14:58:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2410B2934E for ; Sun, 15 Jan 2023 14:58:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pH3WO-0005l5-9c; Sun, 15 Jan 2023 08:58:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH3WN-0005fW-3G for guix-patches@gnu.org; Sun, 15 Jan 2023 08:58:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pH3WM-0005CE-RJ for guix-patches@gnu.org; Sun, 15 Jan 2023 08:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pH3WM-000142-Hc for guix-patches@gnu.org; Sun, 15 Jan 2023 08:58:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60802] [PATCH v3 1/2] platforms: Raise an exception when no suitable platform is found. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 Jan 2023 13:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60802 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , 60802@debbugs.gnu.org Cc: Tobias Geerinckx-Rice , Maxim Cournoyer , Simon Tournier , Mathieu Othacehe , ludo@gnu.org, Christopher Baines , Ricardo Wurmus Received: via spool by 60802-submit@debbugs.gnu.org id=B60802.16737910364023 (code B ref 60802); Sun, 15 Jan 2023 13:58:02 +0000 Received: (at 60802) by debbugs.gnu.org; 15 Jan 2023 13:57:16 +0000 Received: from localhost ([127.0.0.1]:56402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH3Vc-00012p-3k for submit@debbugs.gnu.org; Sun, 15 Jan 2023 08:57:16 -0500 Received: from jpoiret.xyz ([206.189.101.64]:58518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH3VZ-00012g-8b for 60802@debbugs.gnu.org; Sun, 15 Jan 2023 08:57:14 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id D625C185300; Sun, 15 Jan 2023 13:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1673791030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sih8710/yvaKkbMA++vK88ykCoxo4VWvlfaZFOTgG9k=; b=W3ptqUNqiiqlaj+l8uxR2Fzr4xn1oY1jw03zg9Ae1Pp07SmZKL8ja9FtKy+wheLqryZ6eb Ql8bRwvOjtyCYVtE1ImWid2VR9CKAa9LwQD4IRkDDc++4IWehuKIaaaY1IzBpgM8vxZg4F e/f4w8VFHkPVvc2tS4W2r/Ej9og+7T7vDiryoRodvQkUNofbidhmq/WNSRx4tsKH2/IXA+ nnvsAZNW+9ZvmNOSnxyAYXfdcb18TDIUhDLxLlgwptZrSWkhpEZPjRxhrXv93lamt/LaXH 4cvq1cg3RmkGrf8/cV0QtN5tVFfv/y9+TzXYwE/F6mAg9YCOilsHuZ/KwKLAPg== In-Reply-To: <20230114151457.1903-2-maxim.cournoyer@gmail.com> References: <20230114151457.1903-2-maxim.cournoyer@gmail.com> Date: Sun, 15 Jan 2023 14:57:09 +0100 Message-ID: <87zgajkiiy.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: + X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=W3ptqUNq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673791094; a=rsa-sha256; cv=none; b=Pk0DDlG2f6vHB333s3sDlOT/ib85p1QV0Z/RQ4R7oYMiJlB/H8gHrSCE9BSqCTSff9LvzO jdNBBx7TcPYXpvLG7yv3hqhIi7uSjsNs5yRmaEDIDREfZjgBN4LdPVrSq1KlT9pANcpZ0X 2pwauEjIHcWGmDhwGTS54a0gSxp9ITVen1ldP1HB1Q3Rl2sqPRjYMMrPLcRQZsaPXMOmK/ lSG349LDqngrzXPiRTwhE5BqhJfBtPYlXX1aYQpQ4vnQZB/7Wh3ybfWQvWV/rjPmlZ5Osb A+Ps9u6HbxX7m3dKYSX8xc/HwcDjetmEoyQHrrMtPpJURPUKo175QMAHdPT0/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673791094; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=sih8710/yvaKkbMA++vK88ykCoxo4VWvlfaZFOTgG9k=; b=HiWxZ8KMdtnnXTnDX3iU9rKK6TKhrNVslcU42ZdwVF6pEfyv41lDB13DwgMFewBQqMv0Xj XlF+BitlikOCeAPgQH0AXI0IOXvxeprVzx32pM3sYW0WeLzWGPf48v2q2+GQIfuAdW8YrY gvu3nCnRa2IZFM2/kFJWHGQnWdY/HiZOuv+r/asXORW7pSqPzr5j8vZyDqL8KqGd8YTG5g Kl679K77uhockxEM9xDU59MM3ELf2IQASQNt+X0pae7ORMo+AyJ317eClHqG2eCLjVzVaj zXjsg+bfc1jXjx6v5rMoCn1Lc+YHZfELfnDRlBt4usQYqKDurUGhY4YogH7jiQ== X-Migadu-Queue-Id: 2410B2934E X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=W3ptqUNq; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -0.92 X-Spam-Score: -0.92 X-TUID: Ip8cjHU+JZ4d Hi Maxim, This looks good to me, although in the grand scheme of things I wonder if that change is a step forward: for those kinds of procedures, we could expect consumers to instead always properly handle the #f case themselves, rather than baby-sitting them and systematically relying on exceptions in the parent procedure, no? As a caricatural example: the SRFI-1 `find` could raise an exception instead of returning #f, but I don't think anyone would consider that proper behaviour. I don't have a particularly strong opinion towards either option, which probably means that there's some discussion to be had here. Best, -- Josselin Poiret