From: "Ludovic Courtès" <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: John Kehayias <john.kehayias@protonmail.com>, 60934@debbugs.gnu.org
Subject: [bug#60934] [PATCH v2 1/2] gnu: Add llvm-for-mesa.
Date: Mon, 23 Jan 2023 11:35:44 +0100 [thread overview]
Message-ID: <87zga935dr.fsf@gnu.org> (raw)
In-Reply-To: <37a43bcd770f26694343af3ae0534208dc052055.1674136307.git.efraim@flashner.co.il> (Efraim Flashner's message of "Thu, 19 Jan 2023 15:56:03 +0200")
Hello!
Efraim Flashner <efraim@flashner.co.il> skribis:
> * gnu/packages/llvm.scm (llvm-for-mesa): New variable.
Yay for reduced closures!!
> +(define-public llvm-for-mesa
Maybe add a line saying that this is a slim variant specifically
tailored for Mesa, that takes X% of the size of the default LLVM.
> + ;; Note: update the 'clang' input of mesa-opencl when bumping this.
> + (let ((base-llvm llvm-15))
> + (package
> + (inherit base-llvm)
Add (name "llvm-for-mesa") ?
> + (arguments
> + (substitute-keyword-arguments (package-arguments base-llvm)
> + ((#:modules modules '((guix build cmake-build-system)
> + (guix build utils)))
> + `((ice-9 regex)
> + (srfi srfi-1)
> + (srfi srfi-26)
> + ,@modules))
> + ((#:configure-flags cf ''())
> + #~(cons*
> + ;; AMDGPU is needed by the vulkan drivers.
> + #$(string-append "-DLLVM_TARGETS_TO_BUILD="
> + (system->llvm-target) ";AMDGPU")
So the result is two build only two backends, for example x86_64 and
AMDGPU, right?
> + ((#:phases phases '%standard-phases)
> + #~(modify-phases #$phases
> + (add-after 'install 'delete-static-libraries
> + ;; If these are just relocated then llvm-config can't find them.
> + (lambda* (#:key outputs #:allow-other-keys)
> + (for-each delete-file
> + (find-files (string-append
> + (assoc-ref outputs "out") "/lib")
> + "\\.a$"))))
Should we pass -DDISABLE_STATIC=ON or whatever it’s called instead?
> + (add-after 'install 'build-and-install-llvm-config
> + (lambda* (#:key outputs #:allow-other-keys)
Why do we need this extra phase compared to ‘llvm’? Please add a
comment. :-)
> + (let ((out (assoc-ref outputs "out")))
> + (substitute*
> + "tools/llvm-config/CMakeFiles/llvm-config.dir/link.txt"
> + (((string-append "/tmp/guix-build-llvm-"
> + #$(package-version base-llvm)
> + ".drv-0/build/lib"))
> + (string-append out "/lib")))
The non-literal pattern here, and that it explicitly refers to the build
directory, is not great.
I believe you can use (string-append (getcwd) "/lib") as the pattern,
fixing the second problem. Not sure about the first one.
Thank you!
Ludo’.
next prev parent reply other threads:[~2023-01-23 10:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 14:49 [bug#60934] [CORE-UPDATES PATCH] gnu: mesa: Use smaller llvm backend Efraim Flashner
2023-01-19 3:14 ` John Kehayias via Guix-patches via
2023-01-19 7:23 ` Efraim Flashner
2023-01-19 13:56 ` [bug#60934] [PATCH v2 0/2] llvm-for-mesa patch Efraim Flashner
2023-01-19 13:56 ` [bug#60934] [PATCH v2 1/2] gnu: Add llvm-for-mesa Efraim Flashner
2023-01-23 10:35 ` Ludovic Courtès [this message]
2023-01-23 11:57 ` Efraim Flashner
2023-01-30 18:12 ` bug#60934: " Efraim Flashner
2023-01-19 13:56 ` [bug#60934] [PATCH v2 2/2] HELPER PATCH Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zga935dr.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=60934@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=john.kehayias@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).