From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id INHbBTHVVmSDiAAASxT56A (envelope-from ) for ; Sun, 07 May 2023 00:31:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iP8OBTHVVmTxrwAAG6o9tA (envelope-from ) for ; Sun, 07 May 2023 00:31:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 27C1114F2F for ; Sun, 7 May 2023 00:31:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvQQj-0003Dp-Ox; Sat, 06 May 2023 18:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvQQg-0003Dc-H5 for guix-patches@gnu.org; Sat, 06 May 2023 18:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvQQg-00035U-8v for guix-patches@gnu.org; Sat, 06 May 2023 18:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvQQf-0001xO-Ul for guix-patches@gnu.org; Sat, 06 May 2023 18:31:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63215] [PATCH mumi 0/2] Cc all issue participants when sending email Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 May 2023 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 63215@debbugs.gnu.org Received: via spool by 63215-submit@debbugs.gnu.org id=B63215.16834122387484 (code B ref 63215); Sat, 06 May 2023 22:31:01 +0000 Received: (at 63215) by debbugs.gnu.org; 6 May 2023 22:30:38 +0000 Received: from localhost ([127.0.0.1]:35924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQQF-0001wb-EW for submit@debbugs.gnu.org; Sat, 06 May 2023 18:30:38 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:51068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvQQ8-0001wH-Ol for 63215@debbugs.gnu.org; Sat, 06 May 2023 18:30:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h54Sj8OYZ1oMyUTxu95DtkzIi6EbtmqPZA97eZHH55E=; b=SMJTPA3U9GTOAicrs8sMLYdTUG T+SIiyu+bDZfhUhcLvmBqtfBmkTLeeRjmN26ltj9DWN8sPRvqdM0kyahEuD0lpvgO0ZEZHGvhHzPh 538D3AVBXQsVCBtBnN9vrp24Q9mwauwiQyjXRNE4k8CrQctth2lRJPKGoyERVfzdPgrrwAui8+E6k X8yWDsLBLExCkYID7I0KmH3vZO3AP7LO3KlU2du5/yHRxzUP2hpS5QtM/bmNtekJ/R3j3Bj3o2sDK ewW7gsIsmxOFJIVFgcha9ASpV4ycA/LBEGzotjRroE0vWQA6j9h8SYZl9FylALDfIcYMrgEWK2hL2 Fc3zoQ7w==; Received: from [192.168.2.1] (port=45284 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1pvQQ2-0005Or-2B; Sat, 06 May 2023 23:30:23 +0100 From: Arun Isaac In-Reply-To: <871qju4urk.fsf@gmail.com> References: <20230501225158.18612-1-arunisaac@systemreboot.net> <20230501225158.18612-3-arunisaac@systemreboot.net> <87y1m6yw80.fsf_-_@gmail.com> <87jzxnbkqt.fsf@systemreboot.net> <87a5yic3mw.fsf@systemreboot.net> <871qju4urk.fsf@gmail.com> Date: Sat, 06 May 2023 23:30:18 +0100 Message-ID: <87zg6h9jph.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683412272; a=rsa-sha256; cv=none; b=DyGQkbiN5QD4gHF+3jZbyXM+IyJuI8pkY9aF9+zX5bLtHjQrUv1UKnZSIBMm9zyQRp7e5Q Dy6qQCPf1y0Lf0cHHhJdqoT4kK/p2Nkn3yQREd9JmCRgKrBIrKkzUlHEIytJ7e3N8QZKwW 0TrBEWnJa8LplRRpBFrjCXrMthMa9cCVymcJf7zT1I5kjvxJy4FnCzW0YWpXTzQablQtH4 sjlpXX2l3iqg6P+WpVf0gpYjrmdJumaIVbKbyjYh8qKJiy+yx1+uVaoIv5/yD0aPLbCE3n 9ZwKB5FG0XHJ8MB9QzmeZs0abeoTtwkDn8yQezPD/CHKvAJaTc5imhsaDXjEEg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=SMJTPA3U; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683412272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=h54Sj8OYZ1oMyUTxu95DtkzIi6EbtmqPZA97eZHH55E=; b=R3GnOLRkvNzoP/piSwNiR1Kgq6vejkClWovbSJvVTh4VZrO43ZobtDua/jSiXprAJnK9+Q SDQzvjEDA6vXS9cAbvDfz5WFwCWQQtR9JlgXlh75N3SPajyUzoxzGNoKAmjDJ2TGmrqpsy UF4g53GQu+1docmYvjY64zAMZDKHhiq5KErlGni7j5d7s3MqHbdpuY8kXd1jxSoyIovnKI DwGWEZUoIPyoOQzxc29NpNirUeWhsQ6R27L1TsirN4JcLXqMFlaJ09u+cs+cdIRr2k7BvV wVUPf2jEtvAlatTvPSXTtr2RbeGTrT1drZlEoiw9fyXyQpOatUAtVVUFX7JJug== X-Migadu-Spam-Score: -1.20 X-Spam-Score: -1.20 X-Migadu-Queue-Id: 27C1114F2F X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=SMJTPA3U; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: QkKY3IkmqoDx Hi Maxim, > If you meant that it's mumi instead of git that should call > etc/teams.scm, it makes sense. I'm not sure the functionality of > teams.scm proper should be moved wholesale into mumi, as it's useful > outside of mumi (for plain git users, say). I see your point about keeping things working for plain git users. Makes sense. > Mumi could invoke etc/teams.scm to produce the list of team members for > the changes involved, add any missing collaborators retrieved from the > message data to the set (avoiding duplicates), then format the > 'X-Debbugs-CC' header with comma-separated values. It should then > invoke git with the '--no-header-cmd' option to avoid teams.scm being > called again. mumi invoking etc/teams.scm is not so nice since that means coupling mumi to the specific repository layout of guix. This reduces its generality to other projects, say skribilo. Maybe, let's just keep multiple X-Debbugs-Cc headers for now. Let mumi and teams.scm be unaware of each other for now. We can revisit the question of coupling them later. > Note that our teams.scm script currently generate distinct X-Debbugs-CC > header for each participant. The Debbugs copy used by GNU is the one > hosted at [0], which doesn't mention the comma-separated > requirement/suggestion, so I think that's currently OK, although I'm not > too confident in my reading of the 'process' Perl script [1]. At any > rate it'd be easy to adjust in teams.scm. > > The email specification mentions that some special fields such as To and > Cc should be separated by commas, but says nothing about custom fields [2], > so in my opinion both forms should be supported by Debbugs (and probably > are, although it's hard to say without trying). Fair enough. Let's keep multiple X-Debbugs-Cc headers and hope for the best! :-) A new patchset follows. The only difference between this patchset and the previous one is that we set X-Debbugs-Cc headers instead of Cc headers. Regards, Arun