From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EKUxHjH1jGQ2+AAASxT56A (envelope-from ) for ; Sat, 17 Jun 2023 01:50:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2L1fHjH1jGQZNAAA9RJhRA (envelope-from ) for ; Sat, 17 Jun 2023 01:50:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D110A387E3 for ; Sat, 17 Jun 2023 01:50:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qAJCf-0004jb-Ch; Fri, 16 Jun 2023 19:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qAJCd-0004jL-0P for guix-patches@gnu.org; Fri, 16 Jun 2023 19:50:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qAJCc-0000mM-L8 for guix-patches@gnu.org; Fri, 16 Jun 2023 19:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qAJCc-0000Pk-E0 for guix-patches@gnu.org; Fri, 16 Jun 2023 19:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63645] [PATCH] gnu: swaynotificationcenter: Update to 0.8.0 Resent-From: Brian Cully Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Jun 2023 23:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63645 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Brian Cully Cc: Christopher Baines , 63645@debbugs.gnu.org Received: via spool by 63645-submit@debbugs.gnu.org id=B63645.16869593981576 (code B ref 63645); Fri, 16 Jun 2023 23:50:02 +0000 Received: (at 63645) by debbugs.gnu.org; 16 Jun 2023 23:49:58 +0000 Received: from localhost ([127.0.0.1]:50557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAJCY-0000PM-2E for submit@debbugs.gnu.org; Fri, 16 Jun 2023 19:49:58 -0400 Received: from coleridge.kublai.com ([166.84.7.167]:62602 helo=mail.spork.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qAJCV-0000PE-TP for 63645@debbugs.gnu.org; Fri, 16 Jun 2023 19:49:56 -0400 Received: from psyduck (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id 82E1EEA58; Fri, 16 Jun 2023 19:49:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1686959395; bh=G6E8KhCFY0dqsrMINvn9LJnHeqJm09XuXEHCS6Bz9ac=; h=References:From:To:Cc:Subject:Date:In-reply-to; b=RULAOcGN6ZnBSVrpEmEWENwPRgii/OupmC6z+odFatVKNHR6L+6cSdSPP9mRiZcfB YTDiaTPA/Cke8amyFIT39aXe5CsoMtqA2fgA5stm//APUQ4xJZKYjBlG70JimWA9rA jHiPLJSH8dBcW6bGbTKfWNhtCMS2Qiwx9HI2V7js= References: <875y7sy17p.fsf@cbaines.net> <871qigpk63.fsf@psyduck.jhoto.kublai.com> User-agent: mu4e 1.10.2; emacs 29.0.91 Date: Fri, 16 Jun 2023 19:12:25 -0400 In-reply-to: <871qigpk63.fsf@psyduck.jhoto.kublai.com> Message-ID: <87zg4zc6ht.fsf@psyduck.jhoto.kublai.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Brian Cully X-ACL-Warn: , Brian Cully via Guix-patches From: Brian Cully via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1686959409; a=rsa-sha256; cv=none; b=c/oaVUK4Jnzu2G4ebPpiM/dDN6bwP1hgEQqbHUSXNGJGrf2wFvj+nr3cdlTRMWPEV/a+4G OqhhHhSSxTH1TWZUEr1ZiQMFrxoFT8b0wu3YkPHFjYnxpEG1SQvEgWzALWIkQmav03kL89 f9cgUOXysBOSzsK3+4QCdDRex8X/cVP+4gwKsSjRaD1ct/K2aBLHW+offU/fr40jkjxp1o lI3V5Kb3x0EBERrD85ChtCgbAAMQy46gHY7XijkO+ZnyY1Th+/4MlvmHlJDBqUyUcZRXsq HBX1Vn1psRpETwmg4Of77+mjL1OlH+XmCpdvYN9uudV5Uk7VlW577Z3SbjkJwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=RULAOcGN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1686959409; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Vyv1NEjai7KAXwHd5RZml4tnfuyFGnFm2SfCRyHlzQA=; b=Ax4DV0whJEOp2IC8n+J74vOFVggp5qT9DW3iS/Fmg9xuQBEq6mO0H+5Uflm8ZMi3NbcKMh Tz3davLykFtnCu9ND2OQHnYPahOJWRk2vLqGkn3geI94eA0ebdif0jpIelM5vhAXyWcWym XrXPFI731NKL+ho9GshSq9YICOvboAHBOV/QNQnw0ZYx061V44DuyS/gBZyfpPjLVlmi+k 7JcK7Wa2VpQe4TDkZP0bfOVos94rgcpJM9+Cu8kHhUK1LYJ3VJaGWiHv4rZjj8Wm4e4mCJ cvTJnoqHHwNy0M/bfjj2JV856+gLKPk1rpKEyh55yTHBllgUjZrrldfgau7yLg== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=RULAOcGN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.83 X-Spam-Score: -2.83 X-Migadu-Queue-Id: D110A387E3 X-TUID: ne2F9ZB/cYtt Brian Cully writes: > Christopher Baines writes: > >>> (inputs >>> - (list json-glib >>> + (list bash-completion >>> + fish >>> + json-glib >>> glib >>> gtk+ >>> gtk-layer-shell >>> libhandy >>> + libgee >>> + pulseaudio >>> wayland-protocols)) >> >> Regarding these new inputs, what's you're reasoning for adding=20 >> them? > > In general: so that configure would find everything it was=20 > looking > for. I believe the only new hard requirement is libgee and=20 > json-glib > (I can test a build without them and see how far I get, but=20 > it'll have > to wait until I have a bit more time). I re-ran the build today, and the output from the configure phase=20 does specify that =E2=80=98libgee=E2=80=99, =E2=80=98json-glib=E2=80=99, an= d =E2=80=98pulseaudio=E2=80=99 are=20 runtime dependencies: --8<---------------cut here---------------start------------->8--- Run-time dependency json-glib-1.0 found: YES 1.6.2 [=E2=80=A6] Run-time dependency gee-0.8 found: YES 0.20.5 Run-time dependency libpulse found: YES 16.1 Run-time dependency libpulse-mainloop-glib found: YES 16.1 --8<---------------cut here---------------end--------------->8--- > The others =E2=80=94 bash-completion and fish =E2=80=94 are for command=20 > completion, I > believe. Do those better belong in native-inputs just so the can=20 > be > detected during configure-time? But maybe =E2=80=98Run-time dependency=E2=80=99 is a mis-labelling. Compili= ng=20 without the =E2=80=98bash-completion=E2=80=99 or =E2=80=98fish=E2=80=99 inp= uts generates the=20 complaints: --8<---------------cut here---------------start------------->8--- Run-time dependency bash-completion found: NO (tried pkgconfig and=20 cmake) Run-time dependency fish found: NO (tried pkgconfig and cmake) --8<---------------cut here---------------end--------------->8--- But it still installs the completion files: --8<---------------cut here---------------start------------->8--- Installing=20 /tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/zsh/_= swaync=20 to=20 /gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/sh= are/zsh/site-functions Installing=20 /tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/zsh/_= swaync-client=20 to=20 /gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/sh= are/zsh/site-functions Installing=20 /tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/bash/= swaync=20 to=20 /gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/sh= are/bash-completion/completions Installing=20 /tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/bash/= swaync-client=20 to=20 /gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/sh= are/bash-completion/completions Installing=20 /tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/fish/= swaync.fish=20 to=20 /gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/sh= are/fish/vendor_completions.d Installing=20 /tmp/guix-build-swaynotificationcenter-0.8.0.drv-0/source/completions/fish/= swaync-client.fish=20 to=20 /gnu/store/5v2p9n53ivj7cmq7m442gy6yvzqn9vbz-swaynotificationcenter-0.8.0/sh= are/fish/vendor_completions.d --8<---------------cut here---------------end--------------->8--- Note also that =E2=80=98zsh=E2=80=99 gets completions as well, even though = it's=20 not being checked for in the configuration phase. Starting a shell with fish: --8<---------------cut here---------------start------------->8--- /pre-inst-env guix shell -CP coreutils fish bash=20 swaynotificationcenter -- fish --8<---------------cut here---------------end--------------->8--- Yields completion candidates for =E2=80=98swaync=E2=80=99 and =E2=80=98sway= nc-client=E2=80=99,=20 even though I've removed those inputs, so it seems they're not=20 necessary. I'll submit a v2 without the =E2=80=98fish=E2=80=99 and =E2=80=98bash=E2=80= =99 inputs shortly. --=20 -bjc