From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KI/CMEw7oGRxrQAASxT56A (envelope-from ) for ; Sat, 01 Jul 2023 16:42:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CGanMEw7oGTKBQEA9RJhRA (envelope-from ) for ; Sat, 01 Jul 2023 16:42:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C8D7BC3F for ; Sat, 1 Jul 2023 16:42:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFbnY-0004QS-42; Sat, 01 Jul 2023 10:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbnW-0004QD-7e for guix-patches@gnu.org; Sat, 01 Jul 2023 10:42:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFbnV-0004DB-V2 for guix-patches@gnu.org; Sat, 01 Jul 2023 10:42:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFbnV-000497-RE for guix-patches@gnu.org; Sat, 01 Jul 2023 10:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63877] [PATCH] gnu: services: web: Set SSL_CERT_DIR in php-fpm environment. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Jul 2023 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63877 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 63877@debbugs.gnu.org, Timo Wilken Received: via spool by 63877-submit@debbugs.gnu.org id=B63877.168822246915870 (code B ref 63877); Sat, 01 Jul 2023 14:42:01 +0000 Received: (at 63877) by debbugs.gnu.org; 1 Jul 2023 14:41:09 +0000 Received: from localhost ([127.0.0.1]:58468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFbme-00047t-Pe for submit@debbugs.gnu.org; Sat, 01 Jul 2023 10:41:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFbmc-00047X-P5 for 63877@debbugs.gnu.org; Sat, 01 Jul 2023 10:41:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbmW-0003zt-Og; Sat, 01 Jul 2023 10:41:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=a6YhyTeXqE4/KdzY0EWuyx7MySd6Z2HM+omvacVHGgk=; b=Ehegan8DbaDYpEepmRDb AE6XiCUEwTiQtQDG9kIvDv4LQYf3Q3vzM4rRurahxIIMdVCSWEQk7x5jRlKpT0W+ye2HSf3b13FZ5 aaBmOoUKlf3Vk4vCsigFsR8gbGMlN3rj2fBpNjO24gbqRPjfqUmW9hjF5kELFO+Uba7fZ0d/TNKaD 4BWxc41h5MNJASzA+/0KSOhhPtsJl3R0qqTDVdvb1iwCznnnYkUrYNaAwHncH613LXpYcjWa1tBmE WOn6JW+UeCcQR2YSSQBXIIY6ZwlptBBpPfW/CWEKJo+KSDY9OPXcwTZ8CwvC6Y0XYRdI9F2Ch+x+J HJkvRNTe6q987g==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFbmW-0000WZ-CK; Sat, 01 Jul 2023 10:41:00 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sat, 01 Jul 2023 16:40:59 +0200 In-Reply-To: (Bruno Victal's message of "Mon, 5 Jun 2023 04:44:37 +0100") Message-ID: <87zg4fy9s4.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688222540; a=rsa-sha256; cv=none; b=iV5dDyHxJhAqDx0deRub4DE4bh/1NDh/ugcGFA9AQ9AcUpc5al8+mbX6xUiYuuwsu1WX8h vMbI2TWy2ae4TCTf795sDi5aURC3gzw0WGry34iLFyniqDaOvpro7nn5s117z7Wof0A2PL KZiaSdZLn/lIjmpfqh0qxEqAWitYYZSCnqp55uvrfio3aF5VkmTxwpfnKGZ74QAlEFrWl1 3RuxsKSb4RtchmhwqNSU+jRpI8gelVxG+dpu1/1sTtEakWS+p/vKP8VRB3EIgY8FxPOhmA WcZ6REg/YIea+C9ZcaDWLVYfiHMafZ5OIJyiaX/B8foTjFY7fRxCShsw+fz7wA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ehegan8D; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688222540; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=a6YhyTeXqE4/KdzY0EWuyx7MySd6Z2HM+omvacVHGgk=; b=N/ld1Ua1h2eGsa+FnGg+yJjz0/YpJhhbFgTkaoZNwLxCoVbTA3KDNiVPg22S1Ut4PptBk7 MsXBBRWryLrbcdV8043aFrxqlYr2xsZhtIJiqdg4ZmZ4x4HEteY4T1xRjUjSfAUcp2jW7D ebzmgJjn6QKdabhxoYRu/+Q56N56NJwW9iLn2wr3SAecTQTXTgF4mj8gdTczl3qVZVpjQY sTdN7cEjgKjjnuVFt5HjhZtFPBlcLyfAoG2/WdjTZEEDyMQImFoJqna4YRT2tFLUo4/neh wdZchInk2HQsxWzWidFvGIL+A5fOWu4/mL/9GGH+O/Q2sMGuI0lZkcYGU7kInQ== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Ehegan8D; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.66 X-Spam-Score: -2.66 X-Migadu-Queue-Id: 9C8D7BC3F X-TUID: FEg3RRVxTeCB Hi Timo, Did you have a chance to look into implementing Bruno=E2=80=99s suggestions? https://issues.guix.gnu.org/63877 Ludo=E2=80=99. Bruno Victal skribis: > On 2023-06-04 14:59, Timo Wilken wrote: >> @@ -1096,6 +1100,9 @@ (define php-fpm-shepherd-service >> #$@(if php-ini-file >> `("-c" ,php-ini-file) >> '())) >> + #:environment-variables >> + (append #$environment-variables >> + (default-environment-variables)) > > Ungexp-ing lists can be rather tricky since your snippet will expand to: > > ... > #:environment-variables (append ("FOO=3Dbar" ...) > (default-environment-variables)) > ... > > > Which is interpreted as a procedure call. (and results in a hanged shephe= rd) > > You need to quote the list here: > > #:environment-variables (append '#$environment-variables > (default-environment-variables)) > > Bonus points if you can write a small system test for this. (see > gnu/tests/web.scm for inspiration) > For our purposes, a pair of HTTP servers where one of them uses a > self-signed certificate will suffice.