From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KBLnFaFcoGTWZwAASxT56A (envelope-from ) for ; Sat, 01 Jul 2023 19:04:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cCvSFKFcoGRkVQAAG6o9tA (envelope-from ) for ; Sat, 01 Jul 2023 19:04:33 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EAF709A7D for ; Sat, 1 Jul 2023 19:04:32 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFe1G-0004qC-D2; Sat, 01 Jul 2023 13:04:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFe0w-0004jJ-Ex for guix-patches@gnu.org; Sat, 01 Jul 2023 13:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFe0v-0007Kg-TD for guix-patches@gnu.org; Sat, 01 Jul 2023 13:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFe0v-0007r8-PU for guix-patches@gnu.org; Sat, 01 Jul 2023 13:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64399] [PATCH] installer: Restore LatGrkCyr-8x16 console font depending on language. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 01 Jul 2023 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64399 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Denys Nykula Cc: 64399@debbugs.gnu.org, Mathieu Othacehe , Josselin Poiret Received: via spool by 64399-submit@debbugs.gnu.org id=B64399.168823102830174 (code B ref 64399); Sat, 01 Jul 2023 17:04:01 +0000 Received: (at 64399) by debbugs.gnu.org; 1 Jul 2023 17:03:48 +0000 Received: from localhost ([127.0.0.1]:58592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFe0h-0007qc-K0 for submit@debbugs.gnu.org; Sat, 01 Jul 2023 13:03:47 -0400 Received: from relay.yourmailgateway.de ([188.68.63.162]:41423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFe0e-0007qM-Li for 64399@debbugs.gnu.org; Sat, 01 Jul 2023 13:03:46 -0400 Received: from mors-relay-8201.netcup.net (localhost [127.0.0.1]) by mors-relay-8201.netcup.net (Postfix) with ESMTPS id 4QtdnC2bV5z3t3P; Sat, 1 Jul 2023 19:03:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pelzflorian.de; s=key2; t=1688231023; bh=SqcHkSKpp4Db3WW8BZ9gqWW7SCBcudL9mPmhkjgEdLg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YpsD+MTO76wbQDCk9dEQGd/zmOVHmL1kmERhYJhj9wpAv9oDyFZs0HiQH/FBY77y9 97LrIVuzJizlq6U0VZRWFGd29NgWU/R2UrD802IeRhM8pGj7/1SNSLxICmTpML8zVv WsWi8tWc49pnUzKJEeuv9vzoaz9FYqwEqT/s9jhbOAhqkXLyO6AfxbexGnCvDojl/P 8x1mhhvCX7AMiOeUMq+hjuQBNE+hg38D6DTKFWSnQCVLjFmwDhUd82y/+myL2EeKus GnScxSEwSU4gxon4AncEgbvkKs8+iN4oDnGNzi+fY40P+2L+eK/E5pVJEt+kMOLCg2 EHfQUsqp9mbQw== Received: from policy01-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8201.netcup.net (Postfix) with ESMTPS id 4QtdnC1sr6z3t3L; Sat, 1 Jul 2023 19:03:43 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy01-mors.netcup.net Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy01-mors.netcup.net (Postfix) with ESMTPS id 4Qtdn35P2Wz8sZk; Sat, 1 Jul 2023 19:03:35 +0200 (CEST) Received: from florianrock64 (ip92344de0.dynamic.kabel-deutschland.de [146.52.77.224]) by mxe217.netcup.net (Postfix) with ESMTPSA id D31FD8158C; Sat, 1 Jul 2023 19:03:25 +0200 (CEST) From: "pelzflorian (Florian Pelz)" References: <34ca88bad83d40c14346f18ddbc34e8d2884f88f.1688217377.git.vegan@libre.net.ua> Date: Sat, 01 Jul 2023 19:03:24 +0200 In-Reply-To: <34ca88bad83d40c14346f18ddbc34e8d2884f88f.1688217377.git.vegan@libre.net.ua> (Denys Nykula's message of "Sat, 1 Jul 2023 16:19:14 +0300") Message-ID: <87zg4fpns3.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D31FD8158C X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: xQX8Hluq5ge7E3juwgsf1z0BOeLqNsquG1RYyECgqOsBg7Pv6LduBFEr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688231073; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0jXtYBq7moz/7kWv4O2pZCwHIU/NxRhj+masB8DUfyc=; b=qRcwAF2FP9H+bVhKxg0NRffg8vVqNeLGEsyLPotpJw/zgmu4li/9yEE2eCHZwZgydTKcyo 2D6jVlV2VTtjPZ9XJQPsQt9i3ojhMhszEPSx5A67eMfMGfwDXG/Vfs+Xz7oNuCMe03rMJB DMqjtykhWltVTgk25fLI2Wk471EkY0QGNN741nkfF8BE9aNAu4y/qHwGLFbDpU2bCvzYoc UQPUBQK2jnIU0XejUtB3DSV2vTxWa6/S3pwi4/rdUDhOkuaE3C1K6EzjxlL4XyoSExMG4v Bf0sU/GlcjeLOUXruWE5ofxBnk5g5vcxIaHLm959LH0wO3C6faN4wflO/73ivA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=YpsD+MTO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688231073; a=rsa-sha256; cv=none; b=Gz5d1DWjtJ/IiHK2EOMrsjP90M70Vp2A63qnnfaIcysMHeT2mnl8nVO1jbRfJ6r3w+TsRE C9lPrWCjYrn5h8j858hNoTjD6V55zmoARpnJe/hn9ItisL8JP5XIEs6samDXOo71niw89r s6NhUJ3nC4pmI80JqPB43W2m6Y96T4AWcRRmQyij+NWx+KkPVdK89tfz7S5QqsNpAjcV+b gS6/Wvlqi8oFboHbPDNlawoHQ8MTKAsMeFymKcJMhNZIuZVNXcuA5+bMxHfjuTtjpSuJSd g3/jDdblM6Mm63+X8riA7foXslHD/QK+Zk5rvxw8Bxj664XddtPx38VhIa75bw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=pelzflorian.de header.s=key2 header.b=YpsD+MTO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EAF709A7D X-Spam-Score: -0.76 X-TUID: ljS4hQfH32f+ Hello Denys, this patch looks good mostly good to me, except in my opinion, `base-with-default-console-font' should be called `base' and what is called `base' in your patch should be called `services'. Consequently within the `let' body, the services field then could be set as (services ,services) instead of (services ,base). The one who commits the patch can fix it, but perhaps you could also indent properly and untabify your change and then resend a v2 of the patch? In the manual=E2=80=99s Contributing section, the recommended way i= s to use Emacs for automatic formatting, where you can press the tab key for automatic indentation. I have not tested yet. I put the installer team in Cc. If noone disagrees, I will make the above changes, test, and commit this patch next weekend. Regards, Florian