unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Denys Nykula <vegan@libre.net.ua>
Cc: 64399@debbugs.gnu.org, Mathieu Othacehe <othacehe@gnu.org>,
	Josselin Poiret <dev@jpoiret.xyz>
Subject: [bug#64399] [PATCH] installer: Restore LatGrkCyr-8x16 console font depending on language.
Date: Sat, 01 Jul 2023 19:03:24 +0200	[thread overview]
Message-ID: <87zg4fpns3.fsf@pelzflorian.de> (raw)
In-Reply-To: <34ca88bad83d40c14346f18ddbc34e8d2884f88f.1688217377.git.vegan@libre.net.ua> (Denys Nykula's message of "Sat, 1 Jul 2023 16:19:14 +0300")

Hello Denys,

this patch looks good mostly good to me, except in my opinion,
`base-with-default-console-font' should be called `base' and
what is called `base' in your patch should be called `services'.
Consequently within the `let' body, the services field then could be set
as (services ,services) instead of (services ,base).

The one who commits the patch can fix it, but perhaps you could also
indent properly and untabify your change and then resend a v2 of the
patch?  In the manual’s Contributing section, the recommended way is to
use Emacs for automatic formatting, where you can press the tab key for
automatic indentation.

I have not tested yet.

I put the installer team in Cc.  If noone disagrees, I will make the
above changes, test, and commit this patch next weekend.

Regards,
Florian




  reply	other threads:[~2023-07-01 17:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-01 13:19 [bug#64399] [PATCH] installer: Restore LatGrkCyr-8x16 console font depending on language Denys Nykula
2023-07-01 17:03 ` pelzflorian (Florian Pelz) [this message]
2023-07-01 20:48 ` [bug#64399] [PATCH v2] " Denys Nykula
2023-07-05 19:55   ` pelzflorian (Florian Pelz)
2023-07-06  8:56     ` Josselin Poiret via Guix-patches via
2023-07-06 14:27       ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg4fpns3.fsf@pelzflorian.de \
    --to=pelzflorian@pelzflorian.de \
    --cc=64399@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=othacehe@gnu.org \
    --cc=vegan@libre.net.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).