From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iHTIF77AuWSfaQEASxT56A (envelope-from ) for ; Fri, 21 Jul 2023 01:18:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QNnOF77AuWTJcgEA9RJhRA (envelope-from ) for ; Fri, 21 Jul 2023 01:18:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12B4D64E3B for ; Fri, 21 Jul 2023 01:18:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=MvhbuYFd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689895102; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eVUSQi/3HsHOx94Tg+HuILiEYzcxTNmtqz70Ij/kPHA=; b=VJor3aoNM/hwWzGA/Y879DK7jC4zST6AGSYmY6kqRcR01KBpqTKaidH5YN1wanKyomvven SXqkM6QCrtqQ97esdVUtgoI5ozDQAlVekA0oroC0B0yt6TL/N7SCWdtNYygqeXFuAa9u6/ 4bnUWul5RREtDnBxvRUfiC1uGgEkQsCx3IU4BN9oQhLGbxwYoD6Hd3M8rtnHfDNNwPRyib 5xlycnJyi+5fZWOFIPELjFtAdHsjhcrnt/zIPbJNt3lw/qLhiALZOZV/QFK2EEjIZwNRy6 GGlEt4geZhm8ewP1oOPEnBKIqm0hw1/1D+FC93Dw+oSXbF3xJvGC2AqmJ1PsNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=MvhbuYFd; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689895102; a=rsa-sha256; cv=none; b=Ia536WryOVB7M0/XdLwW3ZHQbQKMahTbYRkQ9bCY65WkagTjReAxgkLBvzjkQh2z5HkcTd kKaR/HSIAEddC9a3BaKr0Hpk58TAv00kL00HDhZmexH8rfuXkxv4/Esvad1efbZ6cRKTa+ YXZqFZXMGfG1w4q+EwGk/YY2um49imtpLbQySNa/ESFC4hhhZTMWhYbHkXeYHEynqiU815 zoNRiMMC276XjCK/tZGAXy1i/pkYVz4gODTqOysNApBniQlf4rix9e6/I0gOX++WYAto9o Lu2tw40IElEIW3L++l7LVZ0W13BHvEMReX3yFnE+WQJxDOXKdeX5ONowVDvzZA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMcuJ-0000Pk-N8; Thu, 20 Jul 2023 19:18:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMcuI-0000Nu-0k for guix-patches@gnu.org; Thu, 20 Jul 2023 19:18:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMcuH-0004Dx-Oq for guix-patches@gnu.org; Thu, 20 Jul 2023 19:18:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMcuH-0007Zg-L5 for guix-patches@gnu.org; Thu, 20 Jul 2023 19:18:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Resent-From: Distopico Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jul 2023 23:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64748 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Saku Laesvuori Cc: rg@raghavgururajan.name, 64748@debbugs.gnu.org, hako@ultrarare.space Received: via spool by 64748-submit@debbugs.gnu.org id=B64748.168989502729048 (code B ref 64748); Thu, 20 Jul 2023 23:18:01 +0000 Received: (at 64748) by debbugs.gnu.org; 20 Jul 2023 23:17:07 +0000 Received: from localhost ([127.0.0.1]:60185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMctP-0007YR-1Y for submit@debbugs.gnu.org; Thu, 20 Jul 2023 19:17:07 -0400 Received: from mx0.riseup.net ([198.252.153.6]:53056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMctL-0007Xs-4N for 64748@debbugs.gnu.org; Thu, 20 Jul 2023 19:17:06 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4R6T951qS5z9sm7; Thu, 20 Jul 2023 23:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1689895017; bh=eVUSQi/3HsHOx94Tg+HuILiEYzcxTNmtqz70Ij/kPHA=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=MvhbuYFdV5FkcCCJszX7h3IrA6QUNe++iZPAv+ebiXzOmRwE9HVhaH8Mhj6z0skO6 mjjY5kvUJh5kot1jxFIpUhek3qVSqppKH3bGbsdj00oc9c/3Yu1J+s5uq/1xt1vhrq qLyJCy1sTFlloi9lhgtUzEx8rGDZ/tNZvh+gyjk4= X-Riseup-User-ID: 257CDB5C2441C22D36B22B523696E8AD77C5F0E1539525541B99B619DAD5D44D Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4R6T9367RlzFqhN; Thu, 20 Jul 2023 23:16:55 +0000 (UTC) References: <20230720171841.31901-1-distopico@riseup.net> <20230720193353.gb75xe2ywl6nfvnr@X-kone> <87a5vq9vr7.fsf@riseup.net> <20230720210600.2zwjtcdnoa63rmo4@X-kone> From: Distopico Date: Thu, 20 Jul 2023 18:09:13 -0500 In-reply-to: <20230720210600.2zwjtcdnoa63rmo4@X-kone> Message-ID: <87zg3q897e.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 0.65 X-Migadu-Queue-Id: 12B4D64E3B X-Migadu-Spam-Score: 0.65 X-Migadu-Scanner: mx0.migadu.com X-TUID: t6fqrRKWfYja --=-=-= Content-Type: text/plain On 2023-07-21, Saku Laesvuori wrote: > > I mean the commit message. Now your commit message's ChangeLog only > mentions updating webrtc-for-telegram-desktop. See my last telegram > commit 6192acf8b77 for an example of what I'm talking about. > > I would assume the ChangeLog file is autogenerated based on the commit > messages. > Make sense, I'll update the patch to add more description > > You would probably have to patch the `CMakeLists.txt` so it doesn't try > to build libsrtp from source, see what I did with crc32c in the > mentioned commit for reference. It is quite possible that telegram > doesn't actually need the source code and they are simply using a git > submodule to simplify their own dependency versioning and development. > > You might also have to add a new libsrtp version because the one > packaged in Guix is not configured to use openssl unlike telegram > expects. I'd still try the packaged version first if compiling telegram > a few more times isn't a big problem for you. > I tried but didn't work, this change is similar to **libyuv**, that have reference to the source code of that external library: example https://github.com/desktop-app/tg_owt/blob/83-sdk/src/api/video/i010_buffer.cc#L17 So the case of **libsrtp** is similar, check for example: - https://github.com/desktop-app/tg_owt/blob/master/src/pc/srtp_session_unittest.cc#L25 - https://github.com/desktop-app/tg_owt/blob/master/src/pc/external_hmac.cc#L18 - https://github.com/desktop-app/tg_owt/blob/master/src/pc/BUILD.gn#L174 So change that will require patch several files, not just `CMakeLists.txt`, patch all those file will be make this package hard to maintain. but you can try if you want and let me know if works. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmS5wGUVHGRpc3RvcGlj b0ByaXNldXAubmV0AAoJEJgJOoByVGvzATMH/2XU0ss7XBJATPE++FkVvYL3TQe1 6mxgnTGh5uHF9PbmG4T/J5fN2R54y8ub/riyKDwAtKnxWCT13X51rWphn4Y6y1r7 03IVzVov1NzvzFh8UMtTUOp2dXcv0gSMs+9EAbLPibTauy2vVwCivso5jBmMR0g3 kVi9C0xY/yFfb5yNyQ/d7Q5Fdrsvh2VOa49np/+MmsjpAVc7ANECsjNYOzeJqSix 2en9IIKJUcpKH7fAlanZN6SBq2rG/QQqm4BptkHkqqdFdS6SeRyPgVBXUTHtdr2S IbsrGD5TiBzkel/5ohRwjq701klEEidB7wSgbs6RQwAQYQbgkbU6uLaPR7Q= =Bi9D -----END PGP SIGNATURE----- --=-=-=--