On 2023-07-21, Saku Laesvuori wrote: > > I mean the commit message. Now your commit message's ChangeLog only > mentions updating webrtc-for-telegram-desktop. See my last telegram > commit 6192acf8b77 for an example of what I'm talking about. > > I would assume the ChangeLog file is autogenerated based on the commit > messages. > Make sense, I'll update the patch to add more description > > You would probably have to patch the `CMakeLists.txt` so it doesn't try > to build libsrtp from source, see what I did with crc32c in the > mentioned commit for reference. It is quite possible that telegram > doesn't actually need the source code and they are simply using a git > submodule to simplify their own dependency versioning and development. > > You might also have to add a new libsrtp version because the one > packaged in Guix is not configured to use openssl unlike telegram > expects. I'd still try the packaged version first if compiling telegram > a few more times isn't a big problem for you. > I tried but didn't work, this change is similar to **libyuv**, that have reference to the source code of that external library: example https://github.com/desktop-app/tg_owt/blob/83-sdk/src/api/video/i010_buffer.cc#L17 So the case of **libsrtp** is similar, check for example: - https://github.com/desktop-app/tg_owt/blob/master/src/pc/srtp_session_unittest.cc#L25 - https://github.com/desktop-app/tg_owt/blob/master/src/pc/external_hmac.cc#L18 - https://github.com/desktop-app/tg_owt/blob/master/src/pc/BUILD.gn#L174 So change that will require patch several files, not just `CMakeLists.txt`, patch all those file will be make this package hard to maintain. but you can try if you want and let me know if works.